application / sources / model / hd / data

MAlarmVolumeData.h

Clone Tools

Stats

Commits this week: 0
Total Committers: 1
Last Commit: 20 Nov
Commits this week: 0

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Tuesday 31 Jan 2023
11:48 pm

Behrouz NematiPour

Monday 09 Jan 2023
7:03 am

Dara Navaei

UI-DEN-8058_Alarm Volume Brightness
UI-DEN-8058_Alarm Volume Brightness
Tuesday 11 May 2021
9:48 am

plucia  (deleted user)

Friday 07 May 2021
10:29 am

pmontazemi  (deleted user)

Thursday 06 May 2021
7:21 pm

Behrouz NematiPour

6:39 pm

Behrouz NematiPour

RESOLVED

RESOLVED

6:39 pm

Behrouz NematiPour

RESOLVED

RESOLVED

6:28 pm

Behrouz NematiPour

RESOLVED

RESOLVED

5:54 pm

Behrouz NematiPour

RESOLVED

RESOLVED

4:41 pm

Behrouz NematiPour

RESOLVED

RESOLVED

4:29 pm

Behrouz NematiPour

RESOLVED

RESOLVED

4:28 pm

Behrouz NematiPour

RESOLVED

RESOLVED

4:28 pm

Behrouz NematiPour

RESOLVED

RESOLVED

3:40 pm

Behrouz NematiPour

RESOLVED.

RESOLVED.

Tuesday 04 May 2021
2:53 pm

plucia  (deleted user)

Done

Done

2:49 pm

Peter Lucia <plucia@diality.com>

DEN-8064: Addressed code review comments

Options
    • -74
    • +0
    ./MAlarmVolumeData.h
  2. … 5 more files in changeset.
2:49 pm

plucia  (deleted user)

Fixed

Fixed

2:49 pm

plucia  (deleted user)

Done

Done

1:06 pm

plucia  (deleted user)

That works too. No need for tee here. I've updated it

That works too. No need for tee here. I've updated it

12:59 pm

plucia  (deleted user)

I think VDateTime.h is less safe in this case. It should be updated to match if (_process.state() != QProcess::NotRunning) { return; } to prevent re-starting the process when its already in the "S...

I think VDateTime.h is less safe in this case. It should be updated to match 

if (_process.state() != QProcess::NotRunning) { return; }

to prevent re-starting the process when its already in the "Starting" state as well as the "Running" state.

    enum ProcessState {
        NotRunning,
        Starting,
        Running
    };
12:51 pm

plucia  (deleted user)

I've removed it now. It's the same CAN channel as in the parent class so no need to override it.

I've removed it now. It's the same CAN channel as in the parent class so no need to override it.

12:51 pm

plucia  (deleted user)

AlarmVolumeTemp has been removed

AlarmVolumeTemp has been removed

12:51 pm

plucia  (deleted user)

It is removed now

It is removed now

12:50 pm

plucia  (deleted user)

Done

Done

Thursday 29 Apr 2021
11:24 am

Behrouz NematiPour

The one which has been used in the VDateTime is much cleaner: if (_process.state() == QProcess::Running) { return; }

The one which has been used in the VDateTime is much cleaner:

if (_process.state() == QProcess::Running) {
    return;
}
10:56 am

Behrouz NematiPour

Please don't use "%0" as we discussed.

Please don't use "%0" as we discussed.

10:54 am

Behrouz NematiPour

Regarding our discussion, this will be replaced by a new enum ID_AlarmVolumeSetRsp next to ID_AlarmVolumeSetReq.

Regarding our discussion, this will be replaced by a new enum ID_AlarmVolumeSetRsp next to ID_AlarmVolumeSetReq.

10:51 am

Behrouz NematiPour

please also use the 'a' not only it is consistent with most of the cases but also makes it executable for other user groups(if any).

please also use the 'a' not only it is consistent with most of the cases but also makes it executable for other user groups(if any).

10:48 am

Behrouz NematiPour

Was there a reason the tee command is being used, instead of simply using > like : echo "$1" > /sys/class/backlight/backlight-mipi/brightness ?

Was there a reason the tee command is being used, instead of simply using > like :

echo "$1" > /sys/class/backlight/backlight-mipi/brightness

?

10:30 am

Behrouz NematiPour

What is this line used for?

What is this line used for?