application / sources

view

Clone Tools

Stats

Commits this week: 0
Total Committers: 12
Last Commit: 27 Mar
Commits this week: 0

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Friday 28 Jul 2023
5:00 am

vduong  (deleted user)

This I will align similar to how the others look in the AppController. The SLOT/SIGNAL keywords are aligned.

This I will align similar to how the others look in the AppController. The SLOT/SIGNAL keywords are aligned.

1:46 am

Behrouz NematiPour

this is incorrect connection usage. it should be moved to the applicationController class. The rule of API design: *the API is just emitting the signal *and is not responsible for the usage. *an...

this is incorrect connection usage.
it should be moved to the applicationController class.

The rule of API design:

  • the API is just emitting the signal
  • and is not responsible for the usage.
  • any object which needs to use it will connect and use (connects the signal to its own slot and runs the logic in its own thread)


Please move to ApplicationController class.

1:41 am

Behrouz NematiPour

please check, lists are not empty. can be checked by private member variable: isConfigOk = isConfigOk && ! _<Property Name>.isEmpty();

please check, lists are not empty.
can be checked by private member variable: 

isConfigOk = isConfigOk && ! _<Property Name>.isEmpty();
1:38 am

Behrouz NematiPour

add an empty line before and after

add an empty line before and after

1:34 am

Behrouz NematiPour

please align SIGNAL(did SLOT( on

please align
SIGNAL(did
SLOT( on

1:33 am

Behrouz NematiPour

please do not use else. make it like the others on top. Look at lines 79 - 83. And insert it in between lines 89,90 with two empty line on top and bottom of the if block if ( ! codition ) { err ...

please do not use else.
make it like the others on top.
Look at lines 79 - 83.
And insert it in between lines 89,90
with two empty line on top and bottom of the if block 

if ( ! codition ) {
  err = ;
  LOG_ ;
  return err;
}


thanks

Wednesday 26 Jul 2023
4:03 pm

Dara Navaei

UI-DEN-15833_UI VD S101 - UI - Post Settings Check - [ READY ]
UI-DEN-15833_UI VD S101 - UI - Post Settings Check - [ READY ]
9:13 am

vduong  (deleted user)

Tuesday 25 Jul 2023
1:20 pm

vduong  (deleted user)

1:12 pm

Behrouz NematiPour

[~msuleiman], thanks for the comment. this is fine to be consistent with the rest of the models, which are organized this way.

[~msuleiman],
thanks for the comment.
this is fine to be consistent with the rest of the models, which are organized this way.

10:15 am

Tiffany Mejia

10:13 am

Tiffany Mejia

9:03 am

msuleiman  (deleted user)

use braces for if statement

use braces for if statement

Monday 24 Jul 2023
8:11 pm

Behrouz NematiPour

7:16 pm

Behrouz NematiPour

2:16 pm

jishii  (deleted user)

11:52 am

Behrouz NematiPour

11:39 am

Tiffany Mejia and vduong  (deleted user)

10:57 am

vduong  (deleted user)

RESOLVED

RESOLVED

10:57 am

vduong  (deleted user)

RESOLVED

RESOLVED

10:56 am

vduong  (deleted user)

RESOLVED

RESOLVED

10:56 am

vduong  (deleted user)

RESOLVED

RESOLVED

10:56 am

vduong  (deleted user)

RESOLVED

RESOLVED

10:56 am

vduong  (deleted user)

RESOLVED

RESOLVED

10:54 am

Behrouz NematiPour

removed

removed

10:53 am

Behrouz NematiPour

thank for catching that, it has been fixed.

thank for catching that,
it has been fixed.

10:24 am

Behrouz NematiPour

this will automatically get corrected when the file name is changed in the file explorer of the QtCreator.

this will automatically get corrected when the file name is changed in the file explorer of the QtCreator.

10:22 am

Behrouz NematiPour

the file and the actual Class name does not necessary should be the same. to make sure these are not dependent, I use alias in the qrc. so although the name was not correct this still works.

the file and the actual Class name does not necessary should be the same.
to make sure these are not dependent, I use alias in the qrc.
so although the name was not correct this still works.

10:19 am

Behrouz NematiPour

Correct, that is for clarification since in each of the child(ish) classes in stack back and confirm have different meaning.

Correct, that is for clarification since in each of the child(ish) classes in stack back and confirm have different meaning.

Friday 21 Jul 2023
5:21 am

vduong  (deleted user)

If the file is indeed incorrectly named, please also correct here

If the file is indeed incorrectly named, please also correct here