application / sources

view

Clone Tools

Stats

Commits this week: 0
Total Committers: 12
Last Commit: 23 Mar
Commits this week: 0

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Tuesday 01 Aug 2023
12:59 pm

Behrouz NematiPour

DEN-15514: UI: In-Progress Indicator Missing During Cartridge Priming Steps

- Added some possible solution and will see what is the feedback.

Options
    • -0
    • +13
    ./hd/data/pretreatment/VPreTreatmentStatesData.cpp
    • -0
    • +5
    ./hd/data/pretreatment/VPreTreatmentStatesData.h
  3. … 2 more files in changeset.
Monday 31 Jul 2023
3:27 pm

Vy <vduong@sunriselabs.com>

DEN-15112: Added - UI: UI Does not Display (Pending) Treatment Logs on Export Logs Screen

Updated the filemodel to have a proxyModel for filtering and sorting actions

Options
    • -0
    • +1
    ./VView.h
    • -0
    • +61
    ./settings/VLogSortFilterProxyModel.cpp
    • -0
    • +44
    ./settings/VLogSortFilterProxyModel.h
    • -98
    • +73
    ./settings/VSDCardFilesModel.cpp
    • -7
    • +9
    ./settings/VSDCardFilesModel.h
  6. … 9 more files in changeset.
4:33 am

vduong  (deleted user)

RESOLVED

RESOLVED

4:33 am

vduong  (deleted user)

RESOLVED

RESOLVED

Sunday 30 Jul 2023
1:11 pm

Behrouz NematiPour

added

added

1:11 pm

Behrouz NematiPour

Added

Added

Saturday 29 Jul 2023
8:29 pm

vduong  (deleted user)

Please put //DEBUG

Please put //DEBUG

8:29 pm

vduong  (deleted user)

Please put //DEBUG

Please put //DEBUG

8:18 pm

Behrouz NematiPour

Friday 28 Jul 2023
2:03 pm

Dara Navaei

DEN-15905 - DEN-15548 - UI-BN-S102-Log178 - Application [ Ready ]
DEN-15905 - DEN-15548 - UI-BN-S102-Log178 - Application [ Ready ]
5:36 am

vduong  (deleted user)

Changed

Changed

5:35 am

vduong  (deleted user)

Added.

Added.

5:35 am

vduong  (deleted user)

Added.

Added.

5:35 am

vduong  (deleted user)

Changed based on how GuiView handles the connection from a created-in-QML object.

Changed based on how GuiView handles the connection from a created-in-QML object.

5:33 am

Vy <vduong@sunriselabs.com>

DEN-15487: Updated - UI: POST: UI needs to report an error if the configuration files, or parameter(s) are missing.

Updated with changes per CR request

Options
    • -2
    • +14
    ./hd/data/VTreatmentRanges.cpp
  2. … 4 more files in changeset.
5:00 am

vduong  (deleted user)

This I will align similar to how the others look in the AppController. The SLOT/SIGNAL keywords are aligned.

This I will align similar to how the others look in the AppController. The SLOT/SIGNAL keywords are aligned.

1:46 am

Behrouz NematiPour

this is incorrect connection usage. it should be moved to the applicationController class. The rule of API design: *the API is just emitting the signal *and is not responsible for the usage. *an...

this is incorrect connection usage.
it should be moved to the applicationController class.

The rule of API design:

  • the API is just emitting the signal
  • and is not responsible for the usage.
  • any object which needs to use it will connect and use (connects the signal to its own slot and runs the logic in its own thread)


Please move to ApplicationController class.

1:41 am

Behrouz NematiPour

please check, lists are not empty. can be checked by private member variable: isConfigOk = isConfigOk && ! _<Property Name>.isEmpty();

please check, lists are not empty.
can be checked by private member variable: 

isConfigOk = isConfigOk && ! _<Property Name>.isEmpty();
1:38 am

Behrouz NematiPour

add an empty line before and after

add an empty line before and after

1:34 am

Behrouz NematiPour

please align SIGNAL(did SLOT( on

please align
SIGNAL(did
SLOT( on

1:33 am

Behrouz NematiPour

please do not use else. make it like the others on top. Look at lines 79 - 83. And insert it in between lines 89,90 with two empty line on top and bottom of the if block if ( ! codition ) { err ...

please do not use else.
make it like the others on top.
Look at lines 79 - 83.
And insert it in between lines 89,90
with two empty line on top and bottom of the if block 

if ( ! codition ) {
  err = ;
  LOG_ ;
  return err;
}


thanks

Wednesday 26 Jul 2023
4:03 pm

Dara Navaei

UI-DEN-15833_UI VD S101 - UI - Post Settings Check - [ READY ]
UI-DEN-15833_UI VD S101 - UI - Post Settings Check - [ READY ]
2:43 pm

Vy <vduong@sunriselabs.com>

DEN-15487: Added - UI: POST: UI needs to report an error if the configuration files, or parameter(s) are missing.

- the checking of POST for settings CRC

- error handling when reading the settings file

- error handling when configuration parameters are incorrect

Options
    • -72
    • +79
    ./hd/data/VTreatmentRanges.cpp
    • -0
    • +2
    ./hd/data/VTreatmentRanges.h
  3. … 7 more files in changeset.
9:13 am

vduong  (deleted user)

Tuesday 25 Jul 2023
4:40 pm

Dara Navaei

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

Options
    • -2
    • +2
    ./hd/alarm/VAlarmActiveList.cpp
    • -1
    • +1
    ./settings/VDateTime.cpp
    • -2
    • +2
    ./settings/VDateTime.h
  4. … 14 more files in changeset.
3:53 pm

Behrouz NematiPour

Merge remote-tracking branch 'origin/DEN-15833-UI-VD-S101-UI_HD_RTC_sync' into staging

Options
    • -23
    • +44
    ./settings/VDateTime.cpp
  2. … 3 more files in changeset.
1:20 pm

vduong  (deleted user)

1:12 pm

Behrouz NematiPour

[~msuleiman], thanks for the comment. this is fine to be consistent with the rest of the models, which are organized this way.

[~msuleiman],
thanks for the comment.
this is fine to be consistent with the rest of the models, which are organized this way.

10:15 am

Tiffany Mejia

10:13 am

Tiffany Mejia