application / sources

view

Clone Tools

Stats

Commits this week: 0
Total Committers: 12
Last Commit: 03 Apr
Commits this week: 0

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few minutes ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Tuesday 01 Aug 2023
7:36 pm

Behrouz NematiPour

yes I did.

yes I did.

7:34 pm

Behrouz NematiPour

these are combined/bundled states. look into the cpp. that is I added an extra _ in the name to distinguish them.

these are combined/bundled states.
look into the cpp.
that is I added an extra _ in the name to distinguish them.

6:24 pm

Behrouz NematiPour

Thanks for reminding me the situation with the comment. that is right in View classes we need to. maybe later we can move these checks all in the settings controller, from this view. RESOLVED.

Thanks for reminding me the situation with the comment.
that is right in View classes we need to.
maybe later we can move these checks all in the settings controller, from this view.

RESOLVED.

6:23 pm

Behrouz NematiPour

RESOLVED

RESOLVED

6:22 pm

Behrouz NematiPour

RESOLVED

RESOLVED

6:22 pm

Behrouz NematiPour

RESOLVED

RESOLVED

6:21 pm

Behrouz NematiPour

RESOLVED

RESOLVED

5:18 pm

vduong  (deleted user)

Do you have the HD state for these like the other ones we have ? If yes, can you please put the ///<

Do you have the HD state for these like the other ones we have ? If yes, can you please put the ///<

5:18 pm

vduong  (deleted user)

Type in the name, reservoir missing an r

Type in the name, reservoir missing an r

5:16 pm

vduong  (deleted user)

//DEBUG, please

//DEBUG, please

5:16 pm

vduong  (deleted user)

Did you intentionally left this commented out ?

Did you intentionally left this commented out ?

5:16 pm

vduong  (deleted user)

Please add //DEBUG

Please add //DEBUG

Monday 31 Jul 2023
4:33 am

vduong  (deleted user)

RESOLVED

RESOLVED

4:33 am

vduong  (deleted user)

RESOLVED

RESOLVED

Sunday 30 Jul 2023
1:11 pm

Behrouz NematiPour

added

added

1:11 pm

Behrouz NematiPour

Added

Added

Saturday 29 Jul 2023
8:29 pm

vduong  (deleted user)

Please put //DEBUG

Please put //DEBUG

8:29 pm

vduong  (deleted user)

Please put //DEBUG

Please put //DEBUG

8:18 pm

Behrouz NematiPour

Friday 28 Jul 2023
2:03 pm

Dara Navaei

DEN-15905 - DEN-15548 - UI-BN-S102-Log178 - Application [ Ready ]
DEN-15905 - DEN-15548 - UI-BN-S102-Log178 - Application [ Ready ]
5:36 am

vduong  (deleted user)

Changed

Changed

5:35 am

vduong  (deleted user)

Added.

Added.

5:35 am

vduong  (deleted user)

Added.

Added.

5:35 am

vduong  (deleted user)

Changed based on how GuiView handles the connection from a created-in-QML object.

Changed based on how GuiView handles the connection from a created-in-QML object.

5:00 am

vduong  (deleted user)

This I will align similar to how the others look in the AppController. The SLOT/SIGNAL keywords are aligned.

This I will align similar to how the others look in the AppController. The SLOT/SIGNAL keywords are aligned.

1:46 am

Behrouz NematiPour

this is incorrect connection usage. it should be moved to the applicationController class. The rule of API design: *the API is just emitting the signal *and is not responsible for the usage. *an...

this is incorrect connection usage.
it should be moved to the applicationController class.

The rule of API design:

  • the API is just emitting the signal
  • and is not responsible for the usage.
  • any object which needs to use it will connect and use (connects the signal to its own slot and runs the logic in its own thread)


Please move to ApplicationController class.

1:41 am

Behrouz NematiPour

please check, lists are not empty. can be checked by private member variable: isConfigOk = isConfigOk && ! _<Property Name>.isEmpty();

please check, lists are not empty.
can be checked by private member variable: 

isConfigOk = isConfigOk && ! _<Property Name>.isEmpty();
1:38 am

Behrouz NematiPour

add an empty line before and after

add an empty line before and after

1:34 am

Behrouz NematiPour

please align SIGNAL(did SLOT( on

please align
SIGNAL(did
SLOT( on

1:33 am

Behrouz NematiPour

please do not use else. make it like the others on top. Look at lines 79 - 83. And insert it in between lines 89,90 with two empty line on top and bottom of the if block if ( ! codition ) { err ...

please do not use else.
make it like the others on top.
Look at lines 79 - 83.
And insert it in between lines 89,90
with two empty line on top and bottom of the if block 

if ( ! codition ) {
  err = ;
  LOG_ ;
  return err;
}


thanks