application

sources

Clone Tools

Stats

Commits this week: 3
Total Committers: 14
Last Commit: 16:06
Commits this week: 3

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Thursday 01 Apr 2021
11:22 am

Peter Lucia <plucia@diality.com>

DEN-7054: Addressed code review comments

Options
    • -4
    • +4
    ./gui/qml/pages/SettingsHome.qml
    • -8
    • +2
    ./view/VNetworkModel.cpp
    • -1
    • +1
    ./view/VNetworkModel.h
    • -20
    • +22
    ./wifi/WifiInterface.cpp
    • -0
    • +5
    ./wifi/WifiInterface.h
  6. … 3 more files in changeset.
10:29 am

pmontazemi  (deleted user)

Clarify comment..."...and will a response..." Not clear on what that means.

Clarify comment..."...and will a response..." Not clear on what that means.

9:27 am

pmontazemi  (deleted user)

...cannot...

...cannot...

9:26 am

pmontazemi  (deleted user)

Note...will not (instead of won't informal language)...for more than...

Note...will not (instead of won't informal language)...for more than...

9:26 am

pmontazemi  (deleted user)

...each instruction...

...each instruction...

9:26 am

pmontazemi  (deleted user)

...instruction-based...

...instruction-based...

9:25 am

pmontazemi  (deleted user)

...that has...for each instruction-based...

...that has...for each instruction-based...

9:25 am

pmontazemi  (deleted user)

, the application

, the application

9:25 am

pmontazemi  (deleted user)

When...VM, (comma after VM)...the application

When...VM, (comma after VM)...the application

9:24 am

pmontazemi  (deleted user)

This...required...application...instruction-based.

This...required...application...instruction-based.

9:24 am

pmontazemi  (deleted user)

It..., for application...

It..., for application...

12:14 am

Behrouz NematiPour

DEN-7147: Fixed a bug on arterial/venous pressures

- which was causing user to move low/high other than current default to be able to confirm for FW validation.

Options
    • -0
    • +2
    ./gui/qml/components/RangeSlider.qml
    • -4
    • +8
    ./gui/qml/pages/pretreatment/create/PreTreatmentCreate.qml
  3. … 1 more file in changeset.
Wednesday 31 Mar 2021
6:03 pm

Behrouz NematiPour

DEN-7147: Fixed a bug on Sub-StepIndicator on bottom of the instructions

- Which was causing that to not to show correct number of the steps and titles.

- removed #include "MModel.h" in all the possible cases and include the specific model since the MModel has too much include.

- Showing the Heparin setup in the CART_INSTALL state only if we have a heparin volume setup.

- created a common template function name enumString in Gui namespace to get the enum name as string.

Options
    • -8
    • +15
    ./ApplicationController.cpp
    • -6
    • +1
    ./ApplicationController.h
    • -1
    • +0
    ./gui/GuiGlobals.cpp
    • -0
    • +26
    ./gui/GuiGlobals.h
    • -4
    • +11
    ./gui/qml/components/StepIndicator.qml
    • -1
    • +1
    ./gui/qml/pages/pretreatment/PreTreatmentBase.qml
    • -2
    • +18
    ./gui/qml/pages/pretreatment/PreTreatmentDisposablesStack.qml
    • -5
    • +5
    ./main.h
    • -0
    • +5
    ./model/MModel.h
    • -0
    • +2
    ./model/settings/MSettings.h
    • -1
    • +0
    ./storage/Settings.cpp
    • -1
    • +1
    ./view/VPowerOff.h
    • -7
    • +1
    ./view/VTreatmentCreate.cpp
    • -1
    • +2
    ./view/dg/data/VDGAccelerometerData.h
    • -1
    • +1
    ./view/dg/data/VDGDrainPumpData.h
  16. … 58 more files in changeset.
Tuesday 30 Mar 2021
5:00 pm

Behrouz NematiPour

DEN-7147: preTx: Code Review 0

- The little count down progress circles become bigger.

- The completed text on the bottom of some screens with check marks become settable by code.

- Duplicate group removed from instruction file

- "Recirculate ..." text has been removed from the priming screen

- Added syringe pump state

Options
    • -1
    • +2
    ./gui/qml/compounds/CheckListView.qml
    • -1
    • +1
    ./gui/qml/globals/Fonts.qml
    • -1
    • +1
    ./gui/qml/globals/Variables.qml
    • -4
    • +8
    ./gui/qml/pages/pretreatment/PreTreatmentBase.qml
    • -0
    • +1
    ./gui/qml/pages/pretreatment/PreTreatmentConsumablesStack.qml
    • -10
    • +15
    ./gui/qml/pages/pretreatment/PreTreatmentPrimeStack.qml
    • -0
    • +1
    ./view/hd/data/VPreTreatmentStatesData.cpp
    • -0
    • +1
    ./view/hd/data/VPreTreatmentStatesData.h
    • -6
    • +11
    ./view/settings/VSettings.cpp
  10. … 2 more files in changeset.
Monday 29 Mar 2021
12:17 pm

Behrouz NematiPour

DEN-7137: preTx: Update Design Documents

- Filled all the screen with the dynamic instruction so be able to capture for SDD.

- Removed the idea of reset and clear the stack, since it is not working.

Options
    • -2
    • +2
    ./gui/qml/pages/pretreatment/PreTreatmentWaterSampleStack.qml
  2. … 1 more file in changeset.
10:40 am

Behrouz NematiPour

UI-DEN-7135_UI Pre Treatment
UI-DEN-7135_UI Pre Treatment
10:25 am

Behrouz NematiPour

Why Network being registered?

Why Network being registered?

9:35 am

Behrouz NematiPour

Please take a closer look at the code. At this moment you are still in the main thread and not in the Wifi Thread.

Please take a closer look at the code.
At this moment you are still in the main thread and not in the Wifi Thread.

9:31 am

Behrouz NematiPour

This is an exception that you have a view which you don't have access to its object but in general: whoever wants to use it to connect to a signal of another class should connect to that signal in ...

This is an exception that you have a view which you don't have access to its object but in general:
whoever wants to use it to connect to a signal of another class should connect to that signal in its own scop/class and do it with its private slots.
So in a case like this, these connections should be moved to the interface.
But as I said it is an exception and there no better way than what has been done here.

9:24 am

Behrouz NematiPour

If you made sure your threading is fine please remove these debug which will fill up the log so fast. Please remove the other ones as well if not needed.

If you made sure your threading is fine please remove these debug which will fill up the log so fast.
Please remove the other ones as well if not needed.

9:18 am

Behrouz NematiPour

This one might be on_ not do_. and should be private! A little confusing that if the signal comes from the interface how come the doAdd.... is public access? What happens if it has been called on t...

This one might be on_ not do_. and should be private!
A little confusing that if the signal comes from the interface how come the doAdd.... is public access?
What happens if it has been called on the qml side.
Could you please explain?

9:11 am

Behrouz NematiPour

This screen is a child of ScreenItem and not a StackItem. How come the pop() function is working here! Which Push, pop methods is being called here? If that's the one from SettingsStack, would be m...

This screen is a child of ScreenItem and not a StackItem.
How come the pop() function is working here!
Which Push, pop methods is being called here?
If that's the one from SettingsStack, would be more cleaner to move the push and pop functions in the SettingsStack.
It's fine for now but keep that in mind for later.

9:04 am

Behrouz NematiPour

Please Just make sure that the Alarm can show up and cover any dialog also.

Please Just make sure that the Alarm can show up and cover any dialog also.

8:54 am

Behrouz NematiPour

Would be better to use a non-profit website for the internet test.

Would be better to use a non-profit website for the internet test.

8:44 am

Behrouz NematiPour

This line caused some issues, we need to remove the log of the application output for now. please change it to by adding & and # before 2>>: $HOME/denali -u & # 2>> $HOME/filesystem.err &

This line caused some issues,
we need to remove the log of the application output for now.
please change it to by adding & and # before 2>>:
$HOME/denali -u & # 2>> $HOME/filesystem.err &

8:25 am

Behrouz NematiPour

8:16 am

Behrouz NematiPour

DEN-7377: preTx: Implementation [Dynamic Instruction Loading] ( 2 )

DEN-7457: Meetings & Support - General purpose

Options
    • -6
    • +59
    ./ApplicationController.cpp
    • -5
    • +28
    ./ApplicationController.h
    • -8
    • +0
    ./Threads.h
    • -0
    • +1
    ./gui/GuiGlobals.cpp
    • -0
    • +11
    ./gui/qml/components/StackItem.qml
    • -36
    • +47
    ./gui/qml/compounds/InstructionView.qml
    • -0
    • +4
    ./gui/qml/main.qml
    • -2
    • +5
    ./gui/qml/pages/MainStack.qml
    • -1
    • +15
    ./gui/qml/pages/pretreatment/PreTreatmentBase.qml
    • -2
    • +0
    ./gui/qml/pages/pretreatment/PreTreatmentConsumablesStack.qml
    • -8
    • +0
    ./gui/qml/pages/pretreatment/PreTreatmentDisposablesStack.qml
    • -12
    • +0
    ./gui/qml/pages/pretreatment/PreTreatmentMainStack.qml
    • -8
    • +2
    ./gui/qml/pages/pretreatment/PreTreatmentWaterSampleStack.qml
    • -4
    • +0
    ./gui/qml/pages/pretreatment/connection/PreTreatmentConnectionStack.qml
    • -3
    • +1
    ./gui/qml/pages/pretreatment/create/PreTreatmentCreateStack.qml
  16. … 37 more files in changeset.
Friday 26 Mar 2021
4:59 pm

Peter Lucia <plucia@diality.com>

DEN-7521: Ensure wifi reconnects on reboot

Options
    • -0
    • +17
    ./storage/StorageGlobals.cpp
    • -0
    • +14
    ./storage/StorageGlobals.h
    • -4
    • +4
    ./view/VNetworkModel.cpp
    • -8
    • +130
    ./wifi/WifiInterface.cpp
    • -1
    • +6
    ./wifi/WifiInterface.h
  6. … 5 more files in changeset.
10:58 am

Peter Lucia <plucia@diality.com>

DEN-7521: Adding rest of support for static IP assignments.

Options
    • -97
    • +0
    ./gui/qml/dialogs/JoinNetwork.qml
    • -0
    • +103
    ./gui/qml/dialogs/WifiJoinDisconnect.qml
    • -1
    • +1
    ./gui/qml/main.qml
    • -10
    • +28
    ./gui/qml/pages/SettingsWifi.qml
    • -0
    • +2
    ./storage/StorageGlobals.cpp
    • -0
    • +2
    ./storage/StorageGlobals.h
    • -15
    • +73
    ./view/VNetworkModel.cpp
    • -0
    • +7
    ./view/VNetworkModel.h
    • -15
    • +70
    ./wifi/WifiInterface.cpp
    • -1
    • +6
    ./wifi/WifiInterface.h
  11. … 9 more files in changeset.
Thursday 25 Mar 2021
1:37 am

Behrouz NematiPour

DEN-7408: Code improvement for navigation

- VTreatmentCreate is cleaned up. (still needs a lot of work)

Options
    • -8
    • +8
    ./gui/qml/components/ConfirmTreatmentTable.qml
    • -3
    • +4
    ./gui/qml/components/ConfirmTreatmentTableEntry.qml
    • -4
    • +11
    ./gui/qml/pages/MainHome.qml
    • -2
    • +10
    ./gui/qml/pages/MainStack.qml
    • -8
    • +5
    ./gui/qml/pages/pretreatment/create/PreTreatmentCreateStack.qml
    • -1
    • +1
    ./gui/qml/pages/treatment/TreatmentStack.qml
    • -0
    • +577
    ./view/VTreatmentCreate (legacy).cpp
    • -0
    • +258
    ./view/VTreatmentCreate (legacy).h
    • -569
    • +47
    ./view/VTreatmentCreate.cpp
    • -79
    • +31
    ./view/VTreatmentCreate.h
  11. … 2 more files in changeset.