application

sources

Clone Tools

Stats

Commits this week: 1
Total Committers: 14
Last Commit: 10 Feb
Commits this week: 1

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Tuesday 14 Mar 2023
11:16 am

Vy <vduong@sunriselabs.com>

DEN-14912 Quick Start- Sliders - Change default bool value for rounding rangeSlider to true based on CR comment

Options
    • -1
    • +1
    ./gui/qml/components/RangeSlider.qml
11:09 am

Vy <vduong@sunriselabs.com>

DEN-14912 Quick Start : Sliders - Remove Component and Loaders from TickMarks and changed to Rectangle - Made additional fixes based on CR comments

Options
    • -2
    • +2
    ./gui/qml/components/RangeRect.qml
    • -1
    • +1
    ./gui/qml/components/RangeSlider.qml
    • -9
    • +4
    ./gui/qml/components/Slider.qml
    • -68
    • +24
    ./gui/qml/components/TickMarks.qml
    • -0
    • +3
    ./gui/qml/globals/Variables.qml
    • -1
    • +2
    ./gui/qml/pages/pretreatment/create/PreTreatmentCreate.qml
11:08 am

vduong  (deleted user)

Yes, i will remove the Retangle and set the color as we did before, with the change that the Slider's color for active will be a SliderHighlightColor / Orange instead of the light blue

Yes, i will remove the Retangle and set the color as we did before, with the change that the Slider's color for active will be a SliderHighlightColor / Orange instead of the light blue

11:02 am

jishii  (deleted user) and Behrouz NematiPour

11:02 am

jishii  (deleted user) and Behrouz NematiPour

11:00 am

Behrouz NematiPour

RESOLVED

RESOLVED

10:59 am

Behrouz NematiPour

RESOLVED

RESOLVED

10:59 am

Behrouz NematiPour

RESOLVED

RESOLVED

10:59 am

Behrouz NematiPour

RESOLVED

RESOLVED

10:59 am

Behrouz NematiPour

RESOLVED

RESOLVED

10:58 am

Behrouz NematiPour

RESOLVED

RESOLVED

10:58 am

Behrouz NematiPour

RESOLVED

RESOLVED

10:58 am

Behrouz NematiPour

RESOLVED

RESOLVED

10:46 am

vduong  (deleted user)

I have a possible better solution that will avoid both. I will implement and push the code.

I have a possible better solution that will avoid both. I will implement and push the code.

10:44 am

jishii  (deleted user)

10:17 am

Dara Navaei

10:07 am

Dara Navaei

UI-DEN-14866_UI BN S92
UI-DEN-14866_UI BN S92
6:57 am

Vy <vduong@sunriselabs.com>

DEN-14912 Quick Start: Arrows - Bind visibility of the slider to the switch's check status

Options
    • -0
    • +1
    ./gui/qml/pages/pretreatment/create/PreTreatmentCreate.qml
6:52 am

Vy <vduong@sunriselabs.com>

DEN-14912 Quick Start: Arrows - Additional changes based on Behrouz's feedback

Options
    • -2
    • +4
    ./gui/qml/components/SliderCreateTreatment.qml
    • -1
    • +2
    ./gui/qml/globals/Variables.qml
    • -1
    • +3
    ./gui/qml/pages/pretreatment/create/PreTreatmentCreate.qml
  4. … 2 more files in changeset.
2:15 am

Behrouz NematiPour

DEN-13152 : Flow Rate Settings Display "--" or "0" When Treatment is Paused

- Messages 0x0500 and 0x0800 has been updated and the Prescribed Flow Rate is being used.

- The diagnostics screen updated.

- The treatment main screen updated.

- The treatment flow adjustment screen updated.

- the Flows on the commit has 10f39b63ce8a992280ab123f05a5eb44a27c121b has been separated which has to be reverted back since these two messages almost all the time have the same payloads.

Options
    • -2
    • +2
    ./canbus/MessageGlobals.h
    • -0
    • +6
    ./gui/qml/dialogs/DiagnosticsDialog.qml
    • -2
    • +2
    ./gui/qml/pages/treatment/adjustments/TreatmentAdjustmentFlow.qml
    • -2
    • +2
    ./gui/qml/pages/treatment/sections/TreatmentFlows.qml
    • -0
    • +4
    ./model/hd/data/treatment/MTreatmentBloodFlowData.cpp
    • -1
    • +3
    ./model/hd/data/treatment/MTreatmentBloodFlowData.h
    • -1
    • +8
    ./model/hd/data/treatment/MTreatmentDialysateFlowData.cpp
    • -0
    • +7
    ./model/hd/data/treatment/MTreatmentDialysateFlowData.h
    • -0
    • +1
    ./view/hd/data/treatment/VTreatmentBloodFlow.cpp
    • -0
    • +1
    ./view/hd/data/treatment/VTreatmentBloodFlow.h
    • -0
    • +2
    ./view/hd/data/treatment/VTreatmentDialysateFlow.cpp
    • -0
    • +2
    ./view/hd/data/treatment/VTreatmentDialysateFlow.h
Monday 13 Mar 2023
11:49 pm

Behrouz NematiPour

DEN-14640 : Change Request: BP Set Flow Rate Shown during Blood Prime/Rinseback

- Added the message 0x0500#P1

|0x0500| 5 |0x040 |1 Hz |N |HD |All |Blood Flow Data Flow Set Pt (S32)|

regarding our conversation with @Sean.

Options
    • -1
    • +0
    ./gui/qml/pages/endtreatment/rinseback/EndTreatmentRinseback.qml
    • -0
    • +10
    ./gui/qml/pages/treatment/TreatmentBloodPrime.qml
2:08 pm

Behrouz NematiPour

RESOLVED. Thanks for the test, that is what I remembered. Fine then

RESOLVED.

Thanks for the test, that is what I remembered.
Fine then

2:02 pm

Behrouz NematiPour

1 - The component instance has been used in the same file, and that is the new feature, and previously we have to create a file to use the component instance, or directly return the created compone...

1 - The component instance has been used in the same file, and that is the new feature, and previously we have to create a file to use the component instance, or directly return the created component for one instance use.
2 - The Loader is used inside of the component, which doesn't seem right, the idea is to use inline components so, if possible, avoid loaders.
3 - Multiple components for the line tickmarks and round ones are created since it seems only a property change to make it rounded, since QML doesn't have a line or circle and all are Rectangle, it makes sense to update the underlying rectangle properties to get the desired shape.

1:43 pm

Behrouz NematiPour

Thanks, Sorry for the confusion. Yes, please, as we talked, the active progress should be orange, and the background I think can stay as it was. Then you can remove that extra Rectangle.

Thanks,
Sorry for the confusion.
Yes, please, as we talked, the active progress should be orange, and the background I think can stay as it was.
Then you can remove that extra Rectangle.

1:00 pm

vduong  (deleted user)

This may be a new concept for the project, but it's something that I've used and have seen used before in other QML projects. This also guarantees that you are only loading the object when you nee...

This may be a new concept for the project, but it's something that I've used and have seen used before in other QML projects.

This also guarantees that you are only loading the object when you need it when you use it with the Loader.

The Component itself, if you look at the Qt documentation, you will find "The component encapsulates the QML types within, as if they were defined in a separate QML file, and is not loaded until requested (in this case, by the two Loader objects)."

So, I am sure this is efficient.

12:56 pm

vduong  (deleted user)

We had this discussion this morning, I have already tested it also. It is working as we expected. It only prints out the round tick's Component.onCompleted log messages of the round tick marks and ...

We had this discussion this morning, I have already tested it also. It is working as we expected. It only prints out the round tick's Component.onCompleted log messages of the round tick marks and not both the round and lined tick marks. This is operating as we expected.

12:55 pm

vduong  (deleted user)

Ok, easy change over.

Ok, easy change over.

12:55 pm

vduong  (deleted user)

We had a discussion about what needed to be done and you had mentioned that the progressRect would be transparent. In order for that to be transparent, we needed a background rectangle color. BUT w...

We had a discussion about what needed to be done and you had mentioned that the progressRect would be transparent. In order for that to be transparent, we needed a background rectangle color. BUT we had talked this morning and I will remove this rectangle and just set the progress rect's color as w/e the active color is.

12:54 pm

vduong  (deleted user)

I believe this is leftover code that I missed from the slider bug fixes. I'll remove it for this branch.

I believe this is leftover code that I missed from the slider bug fixes. I'll remove it for this branch.

10:26 am

Vy <vduong@sunriselabs.com>

DEN-14912 Quick Start - Arrows - Modify code based on feedback from Behrouz -- take out the CircleButton and make use of TouchRect -- Add left and right arrow images

Options
    • -62
    • +0
    ./gui/qml/components/CircleButton.qml
    • -0
    • +99
    ./gui/qml/components/SliderArrows.qml
    • -42
    • +9
    ./gui/qml/components/SliderCreateTreatment.qml
    • -2
    • +1
    ./gui/qml/globals/Variables.qml
  5. … 3 more files in changeset.