sources

Clone Tools
  • last updated a few minutes ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
DEN-15738: UI: Cybersecurity: Move the Treatment log to the Encrypted partition

DEN-15737 UI: Call the lockdown.sh before quits

- DEN-15402 is disabled for now, just to release the Cybersecurity release

# I set to always enabled for now to always go to the manufacturing mode

# 1 - Even for normal setup start is moving files to /home/root, so the lockdown needs to run to move files.

# 2 - The UI still needs to be executed to decrypt the /var/configurations, otherwise the configurations can not be updated,

# and I don't have the ability to just decrypt and exit right now.

# Note: after the Cybersecurity release I will improve the user experience and will make it easier for manufacturing.

    • -2
    • +9
    ./gui/qml/pages/settings/SettingsStack.qml
  1. … 3 more files in changeset.
Minor fix, make script executable.

[~pvedantam] The Ethernet POST is not a requirement, and if it fails UI will not fail the POST.

[~pvedantam]
The Ethernet POST is not a requirement, and if it fails UI will not fail the POST.

It appears that we are checking string fields of the ethernet driver and not performing a POST for the driver, is that being performed elsewhere ?, for example ethtool or similar

It appears that we are checking string fields of the ethernet driver and not performing a POST for the driver, is that being performed elsewhere ?, for example ethtool or similar

The comment " Exit code is not used", if case of a failure, what would be the state of the instrument ?

The comment " Exit code is not used", if case of a failure, what would be the state of the instrument ?

[~vduong], This CR is done and the branch is merged into staging. Please close the branch at your earliest convenience.

[~vduong],
This CR is done and the branch is merged into staging.
Please close the branch at your earliest convenience.

[~vduong], This CR is done and the branch is merged into staging. Please close the branch at your earliest convenience.

[~vduong],
This CR is done and the branch is merged into staging.
Please close the branch at your earliest convenience.

Bamboo Commit: Updated MAlarmMapping.cpp

    • -14
    • +20
    ./model/hd/alarm/MAlarmMapping.cpp
Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

    • -2
    • +2
    ./gui/qml/pages/treatment/TreatmentStack.qml
    • -20
    • +14
    ./model/hd/alarm/MAlarmMapping.cpp
Merge branch 'DEN-15530-UI-VD-S99-Cybersecurity-BN-branch-off' into DEN-15279-UI-BN-S97-Cybersecurity

    • -4
    • +18
    ./gui/qml/pages/settings/SettingsStack.qml
  1. … 1 more file in changeset.
Bruce as we had discussed, please investigate if we forking the CAN, BT, WiFI, Touchscreen helps from a startup time, i.e. the individual process could wait for a certain state to happen or you cou...

Bruce as we had discussed, please investigate if we forking the CAN, BT, WiFI, Touchscreen helps from a startup time, i.e. the individual process could wait for a certain state to happen or you could reorder the startup sequence.

Please add function headers as needed

Please add function headers as needed

It would be nice to be consistent on the casing of the messages, "YES" , "NO" or "Yes" / "No"

It would be nice to be consistent on the casing of the messages, "YES" , "NO" or "Yes" / "No"

DEN-15211 : CS: CloudSync Configuration Should Preserve after setup

- Made the code testable for CloudSync Device Registration.

    • -1
    • +1
    ./gui/qml/pages/settings/SettingsHome.qml
    • -1
    • +1
    ./gui/qml/pages/settings/SettingsStack.qml
DEN-15211 : CS: CloudSync Configuration Should Preserve after setup

DEN-15294 : UI: Cybersecurity: Clean up the device after manufacturing [remove the setup.sh]

DEN-15293 : UI: Cybersecurity: Clean up the device after manufacturing [remove./.ssh]

  1. … 4 more files in changeset.
missing doxygen comment

missing doxygen comment

Doxygen comment incorrect for below function

Doxygen comment incorrect for below function

This comment is incorrect

This comment is incorrect

"reenalbe" -> "reenable"

"reenalbe" -> "reenable"

"trasnlated" - > "translated"

"trasnlated" - > "translated"

Very minor, but do you want this to be "eError_No_SettingsFile" where settings is plural?

Very minor, but do you want this to be "eError_No_SettingsFile" where settings is plural?

Missing doxygen comment

Missing doxygen comment

Function name here does not match the actual function

Function name here does not match the actual function

typo, "Continueing" -> "Continuing"

typo, "Continueing" -> "Continuing"