application

sources

Clone Tools

Stats

Commits this week: 1
Total Committers: 14
Last Commit: 10 Feb
Commits this week: 1

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Friday 28 Jul 2023
5:36 am

vduong  (deleted user)

Changed

Changed

5:35 am

vduong  (deleted user)

Added.

Added.

5:35 am

vduong  (deleted user)

Added.

Added.

5:35 am

vduong  (deleted user)

Changed based on how GuiView handles the connection from a created-in-QML object.

Changed based on how GuiView handles the connection from a created-in-QML object.

5:00 am

vduong  (deleted user)

This I will align similar to how the others look in the AppController. The SLOT/SIGNAL keywords are aligned.

This I will align similar to how the others look in the AppController. The SLOT/SIGNAL keywords are aligned.

4:50 am

vduong  (deleted user)

4:46 am

vduong  (deleted user)

RESOLVED

RESOLVED

1:46 am

Behrouz NematiPour

this is incorrect connection usage. it should be moved to the applicationController class. The rule of API design: *the API is just emitting the signal *and is not responsible for the usage. *an...

this is incorrect connection usage.
it should be moved to the applicationController class.

The rule of API design:

  • the API is just emitting the signal
  • and is not responsible for the usage.
  • any object which needs to use it will connect and use (connects the signal to its own slot and runs the logic in its own thread)


Please move to ApplicationController class.

1:41 am

Behrouz NematiPour

please check, lists are not empty. can be checked by private member variable: isConfigOk = isConfigOk && ! _<Property Name>.isEmpty();

please check, lists are not empty.
can be checked by private member variable: 

isConfigOk = isConfigOk && ! _<Property Name>.isEmpty();
1:38 am

Behrouz NematiPour

add an empty line before and after

add an empty line before and after

1:34 am

Behrouz NematiPour

please align SIGNAL(did SLOT( on

please align
SIGNAL(did
SLOT( on

1:33 am

Behrouz NematiPour

please do not use else. make it like the others on top. Look at lines 79 - 83. And insert it in between lines 89,90 with two empty line on top and bottom of the if block if ( ! codition ) { err ...

please do not use else.
make it like the others on top.
Look at lines 79 - 83.
And insert it in between lines 89,90
with two empty line on top and bottom of the if block 

if ( ! codition ) {
  err = ;
  LOG_ ;
  return err;
}


thanks

1:11 am

Behrouz NematiPour

yes, to easily checkout on all the relevant repositories.

yes, to easily checkout on all the relevant repositories.

Thursday 27 Jul 2023
4:49 am

vduong  (deleted user)

Was this intentionally added for the pre-build steps ?

Was this intentionally added for the pre-build steps ?

Wednesday 26 Jul 2023
4:03 pm

Dara Navaei

UI-DEN-15833_UI VD S101 - UI - Post Settings Check - [ READY ]
UI-DEN-15833_UI VD S101 - UI - Post Settings Check - [ READY ]
9:13 am

vduong  (deleted user)

9:13 am

vduong  (deleted user)

Tuesday 25 Jul 2023
1:20 pm

vduong  (deleted user)

1:12 pm

Behrouz NematiPour

[~msuleiman], thanks for the comment. this is fine to be consistent with the rest of the models, which are organized this way.

[~msuleiman],
thanks for the comment.
this is fine to be consistent with the rest of the models, which are organized this way.

1:00 pm

vduong  (deleted user)

That was pre-existing and unrelated to the changes I had made for this CR.

That was pre-existing and unrelated to the changes I had made for this CR.

10:21 am

Dara Navaei

UI-DEN-15905-UI-BN-S102 - UpdateOnly - Application [ Ready ]
UI-DEN-15905-UI-BN-S102 - UpdateOnly - Application [ Ready ]
10:15 am

Tiffany Mejia

10:14 am

Tiffany Mejia

10:13 am

Tiffany Mejia

9:04 am

msuleiman  (deleted user)

use braces for if statement

use braces for if statement

9:03 am

msuleiman  (deleted user)

use braces for if statement

use braces for if statement

Monday 24 Jul 2023
8:11 pm

Behrouz NematiPour

7:22 pm

Behrouz NematiPour

7:16 pm

Behrouz NematiPour

7:13 pm

Behrouz NematiPour