Activity application/sources

Tree
Accordion

Stats

Commits this week: 2

Total Committers:	14
Last Commit:	05 Feb
Commits this week:	2

Lines of code count not available

Commit Activity

last updated a few seconds ago

Constraints

Constraints: committers

Committer:

Log Comment:

Constraints: files

File Extension:

File Name:

Constraints: dates

Start Date:

Start Date:

End Date:

End Date:

Thursday 07 Sep 2023

6:11 am

Vy <vduong@sunriselabs.com>

More
c1031c7
changed 5 files
@Environement_Swith, CWN-VD-Software-Update-UI and 93 more UI-DEN-16335-5

DEN-16256: Updated - UI.P1B : Display UF Rate

Added QML text to display the rate

Include the 11th parameter

- -1
- +1
./canbus/MessageGlobals.h
- History
- Source
- Diff
./canbus/MessageGlobals.h
- -0
- +1
./gui/qml/globals/Fonts.qml
- History
- Source
- Diff
./gui/qml/globals/Fonts.qml
- -0
- +14
./gui/qml/pages/treatment/sections/TreatmentUltrafiltration.qml
- History
- Source
- Diff
./gui/qml/.../TreatmentUltrafiltration.qml
- -1
- +2
./view/hd/data/treatment/VTreatmentUltrafiltration.cpp
- History
- Source
- Diff
./view/hd/.../VTreatmentUltrafiltration.cpp
- -0
- +1
./view/hd/data/treatment/VTreatmentUltrafiltration.h
- History
- Source
- Diff
./view/hd/.../VTreatmentUltrafiltration.h

Wednesday 06 Sep 2023

8:12 pm

Behrouz NematiPour

More
Re: UI-DEN-16335-5
commented on review

update the length check of the message in MessageGlobals.h const QHash<Gui::GuiActionType ,quint8> payloadLen { . . {Gui::GuiActionType::ID_DialysateOutletFlow , 10 * 4 }...

update the length check of the message in MessageGlobals.h

const QHash<Gui::GuiActionType ,quint8> payloadLen {
.
.
{Gui::GuiActionType::ID_DialysateOutletFlow                     ,  10 * 4       }, //10 parameters each 4bytes
.
.
}

7:50 pm

Behrouz NematiPour

More
Re: UI-DEN-16335-5
commented on review

param 11 is missing 01 F32-refUFVolMl 02 F32-measUFVolMl 03 F32-measRotSpdRPM 04 F32-measSpdRPM 05 F32-measMCSpdRPM ...

param 11 is missing

01    F32-refUFVolMl	              
02    F32-measUFVolMl	              
03    F32-measRotSpdRPM	            
04    F32-measSpdRPM	              
05    F32-measMCSpdRPM	            
06    F32-measMCCurrmA	            
07    F32-setPWMpct	                
08    F32-dopCorrOffset	            
09    F32-dopCalcRate	              
10    F32-ufCalcRate	              
11    U32-rotorHall	                
12    F32-currentSetUFRate

7:49 pm

Behrouz NematiPour

More
Re: UI-DEN-16335-5
commented on review

param 11 is missing 01 F32-refUFVolMl 02 F32-measUFVolMl 03 F32-measRotSpdRPM 04 F32-measSpdRPM 05 F32-measMCSpdRPM ...

param 11 is missing

01    F32-refUFVolMl	              
02    F32-measUFVolMl	              
03    F32-measRotSpdRPM	            
04    F32-measSpdRPM	              
05    F32-measMCSpdRPM	            
06    F32-measMCCurrmA	            
07    F32-setPWMpct	                
08    F32-dopCorrOffset	            
09    F32-dopCalcRate	              
10    F32-ufCalcRate	              
11    U32-rotorHall	                
12    F32-currentSetUFRate

7:39 pm

Behrouz NematiPour

More
Re: UI-DEN-16335-5
commented on review

I think we should use mL/min as is. and do not convert to Liter.

I think we should use mL/min as is. and do not convert to Liter.

7:31 pm

Behrouz NematiPour

More
Re: UI-DEN-16335-5
commented on review

Update the cpp as well

Update the cpp as well

2:04 pm

Vy <vduong@sunriselabs.com>

More
c841000
changed 3 files
@Environement_Swith, CWN-VD-Software-Update-UI and 93 more UI-DEN-16335-5

DEN-16256: Added - UI.P1B : Display UF Rate

Add the variable to the 0x0B00 message model to include UF Current set rate

Setting of the value received from HD for UF Current Set Rate

- -0
- +6
./model/hd/data/treatment/MTreatmentOutletFlowData.h
- History
- Source
- Diff
./model/hd/.../MTreatmentOutletFlowData.h
- -0
- +1
./view/hd/data/treatment/VTreatmentUltrafiltration.cpp
- History
- Source
- Diff
./view/hd/.../VTreatmentUltrafiltration.cpp
- -0
- +1
./view/hd/data/treatment/VTreatmentUltrafiltration.h
- History
- Source
- Diff
./view/hd/.../VTreatmentUltrafiltration.h

11:35 am

vduong (deleted user)

More
UI-DEN-16335-3
started review

UI-DEN-16335_UI VD S105 Disable confirm device config - [READY]

UI-DEN-16335_UI VD S105 Disable confirm device config - [READY]

11:32 am

vduong (deleted user)

More
UI-DEN-16335-1
started review

UI-DEN-16335_UI VD S105 Bluetooth Missing Connect Logs - [READY]

UI-DEN-16335_UI VD S105 Bluetooth Missing Connect Logs - [READY]

10:53 am

vduong (deleted user)

More
UI-DEN-16335-3
Closed

10:05 am

Dara Navaei

More
UI-DEN-16335-5
started review

UI-DEN-16335_UI VD S105 - P1B - Display UF Rate - [READY]

UI-DEN-16335_UI VD S105 - P1B - Display UF Rate - [READY]

9:50 am

msuleiman (deleted user)

More
UI-DEN-16335-3
finished reviewing

9:00 am

Vy <vduong@sunriselabs.com>

More
9528cd6
changed 2 files
@Environement_Swith, CWN-VD-Software-Update-UI and 93 more UI-DEN-16335-3

DEN-16235: Updated - UI Device Setup - Device Configuration screen "Confirm" button should not be allowed to be pressed more than once

Remove unnecessary whitespace added in last commit

- -1
- +0
./device/DeviceController.cpp
- History
- Source
- Diff
./device/DeviceController.cpp
- -1
- +0
./storage/FileHandler.cpp
- History
- Source
- Diff
./storage/FileHandler.cpp

8:21 am

Vy <vduong@sunriselabs.com>

More
f3fa6fc
changed 8 files
@Environement_Swith, CWN-VD-Software-Update-UI and 93 more UI-DEN-16335-3

DEN-16235: Updated - UI Device Setup - Device Configuration screen "Confirm" button should not be allowed to be pressed more than once

Per Code Review Discussions:

- Remove the directory comparison function

- Remove the added variables from last commit (isExited, etc)

- Change logic for cryptSetupEnabled property setting

- -2
- +0
./device/DeviceController.cpp
- History
- Source
- Diff
./device/DeviceController.cpp
- -1
- +0
./device/DeviceModels.h
- History
- Source
- Diff
./device/DeviceModels.h
- -2
- +3
./device/DeviceView.cpp
- History
- Source
- Diff
./device/DeviceView.cpp
- -1
- +0
./device/DeviceView.h
- History
- Source
- Diff
./device/DeviceView.h
- -1
- +1
./gui/qml/pages/settings/SettingsManufacturingSetup.qml
- History
- Source
- Diff
./gui/qml/.../SettingsManufacturingSetup.qml
- -29
- +0
./storage/FileHandler.cpp
- History
- Source
- Diff
./storage/FileHandler.cpp
- -1
- +0
./storage/FileHandler.h
- History
- Source
- Diff
./storage/FileHandler.h
- -1
- +0
./storage/Settings.cpp
- History
- Source
- Diff
./storage/Settings.cpp

6:22 am

vduong (deleted user)

More
UI-DEN-16335-1
Closed

Tuesday 05 Sep 2023

4:46 pm

Behrouz NematiPour

More
Re: UI-DEN-16335-1
replied to vduong (deleted user)

RESOLVED

RESOLVED

4:45 pm

Behrouz NematiPour

More
Re: UI-DEN-16335-1
replied to vduong (deleted user)

RESOLVED

RESOLVED

4:44 pm

Behrouz NematiPour

More
Re: UI-DEN-16335-1
replied to vduong (deleted user)

RESOLVED

RESOLVED

4:43 pm

Behrouz NematiPour

More
Re: UI-DEN-16335-1
replied to vduong (deleted user)

RESOLVED

RESOLVED

4:41 pm

Behrouz NematiPour

More
Re: UI-DEN-16335-1
replied to vduong (deleted user)

RESOLVED

RESOLVED

4:40 pm

msuleiman (deleted user)

More
UI-DEN-16335-1
finished reviewing

4:38 pm

msuleiman (deleted user)

More
UI-DEN-13226-1
finished reviewing

4:32 pm

msuleiman (deleted user)

More
UI-DEN-13226-1
joined review

3:56 pm

vduong (deleted user)

Done.

Done.

3:56 pm

vduong (deleted user)

Per our call, you have agreed to leave it above in this location. No change in location

Per our call, you have agreed to leave it above in this location. No change in location

3:55 pm

vduong (deleted user)

More
Re: UI-DEN-16335-1
replied to vduong (deleted user)

We clarify this thread with a call.

We clarify this thread with a call.

3:55 pm

vduong (deleted user)

This is no longer applicable due to the changes from our conversation.

This is no longer applicable due to the changes from our conversation.

3:55 pm

vduong (deleted user)

I made the changes based on the call we had.

I made the changes based on the call we had.

3:52 pm

Vy <vduong@sunriselabs.com>

More
a3260d6
changed 2 files
@Environement_Swith, CWN-VD-Software-Update-UI and 93 more UI-DEN-16335-1

DEN-16319: Updated - UI log does not record blood pressure cuff bluetooth pairing

Modify the logged message to better indicate the bluetooth connection and paired status

- -1
- +1
./bluetooth/BluetoothInterface.cpp
- History
- Source
- Diff
./bluetooth/BluetoothInterface.cpp
- -3
- +4
./view/settings/VBluetooth.cpp
- History
- Source
- Diff
./view/settings/VBluetooth.cpp

3:08 pm

Vy <vduong@sunriselabs.com>

More
e3cfef3
changed 5 files
@Environement_Swith, CWN-VD-Software-Update-UI and 93 more UI-DEN-16335-1

DEN-16319: Updated - UI log does not record blood pressure cuff bluetooth pairing

Remove unused bt model constructors in MBluetooth

Make use of the devicePair member variable, removing added isPaired

Remove pairing getter function

- -19
- +4
./bluetooth/BluetoothInterface.cpp
- History
- Source
- Diff
./bluetooth/BluetoothInterface.cpp
- -1
- +0
./bluetooth/BluetoothInterface.h
- History
- Source
- Diff
./bluetooth/BluetoothInterface.h
- -24
- +0
./model/settings/MBluetooth.cpp
- History
- Source
- Diff
./model/settings/MBluetooth.cpp
- -17
- +0
./model/settings/MBluetooth.h
- History
- Source
- Diff
./model/settings/MBluetooth.h
- -6
- +2
./view/settings/VBluetooth.cpp
- History
- Source
- Diff
./view/settings/VBluetooth.cpp

Atlassian Fisheye Git analysis with Crucible code review. (Version:4.8.14 Build:20240111091859 2024-01-11 09:20) - Administration - Page generated 2026-02-10 15:12 -0800