sources

Clone Tools
  • last updated a few minutes ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Addressing code review comments

RESOLVE

RESOLVE

Yes, that's the other typo.

Yes, that's the other typo.

I fixed both, isn't it? that is what I see.

I fixed both,
isn't it?
that is what I see.

You're missing an n in the "clickDeboucing" same issue with the others

You're missing an n in the "clickDeboucing" same issue with the others

fixed, thanks for pointing that out.

fixed,
thanks for pointing that out.

Used your exact suggestion. thanks,

Used your exact suggestion.
thanks,

Addressing Code Review comments

    • -11
    • +10
    ./gui/qml/components/TouchRect.qml
Suggestion (spell check): // When alarm status 0 is sent from HD to clear/hide the AlarmDialog, it comes with priority 0 // priority 0 has no clear definition; therefore, UI will set the coloring ...

Suggestion (spell check):

// When alarm status 0 is sent from HD to clear/hide the AlarmDialog, it comes with priority 0
// priority 0 has no clear definition; therefore, UI will set the coloring to the default system theme: blue.
// The blue color is confusing users, so we skip this coloring.

typo for debounce in the property name and also the timer's ID.

typo for debounce in the property name and also the timer's ID.

UI-DEN-16526-UI-BN-S109-3 [ application ]
UI-DEN-16526-UI-BN-S109-3 [ application ]
DENBUG-182 , DENBUG-185

DENBUG-185: UI shows version without period in between (ECO-11648, ECO-11616)

DENBUG-182: Phantom Alarm Screen Appears After Clearing Last Alarm

  1. … 1 more file in changeset.
Bamboo Commit: Updated MAlarmMapping.cpp

DEN-16531: UI: The reservoir message structure has changed on FW and UI needs to adjust.

    • -12
    • +0
    ./model/dg/data/MDGReservoirData.cpp
DENBUG-204: UI: The reservoir message structure has changed on FW and UI needs to adjust.

DEN-16531: UI: The reservoir message structure has changed on FW and UI needs to adjust.

    • -12
    • +0
    ./model/dg/data/MDGReservoirData.cpp
DEN-16532 UI: Remove any comma from the texts being added in the Treatment Report

UI-DEN-16526-UI-BN-S109-2 [ application ]
UI-DEN-16526-UI-BN-S109-2 [ application ]