application

Clone Tools
  • last updated a few seconds ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
DEN-1617 : Implementation - Alarm Logging and Acknowledgment

- Added Threading for :

. Can Frame

. Can Message

. USB Watcher

- Changed the File Handler implementation

- Changed the Singleton from pointer to static reference

// TODO :

- We still need to work on threading on other classes

- We need to have a singleton parent class

- Some code has been added to debug can interface (We still have swap frames)

- Thread Objects need to be gathered all together in one place to be handled easily.

    • -17
    • +12
    /sources/applicationcontroller.cpp
    • -38
    • +84
    /sources/canbus/caninterface.cpp
    • -10
    • +38
    /sources/canbus/messagedispatcher.cpp
    • -0
    • +20
    /sources/canbus/messageglobals.cpp
  1. … 7 more files in changeset.
DEN-1617 : Implementation - Alarm Logging and Acknowledgment

- Added Threading structure for USBWatcher and FileHandler

    • -51
    • +18
    /sources/storage/filehandler.cpp
DEN-1403 : Static Code Analysis

- cppCheck does not understand QML so even if a function is going to be used later in qml it still says not uded.

DEN-1617 : Implementation - Alarm Logging and Acknowledgment

- Added a simple none secure Denali application update through USB drive

- Added check for the mount folders of the USB & SD-Card

DEN-1617 : Implementation - Alarm Logging and Acknowledgment

- Alarm Logging has been added

- Some other changes has been done to the code and messaging.

- Acknowledgment is not done [ Had an agreement with Sean for design but needs more time and we need to do it all together.]

    • -0
    • +95
    /sources/abstract/singleton.h
    • -0
    • +19
    /sources/canbus/alarminterpreter.cpp
    • -0
    • +41
    /sources/canbus/alarminterpreter.h
    • -116
    • +242
    /sources/canbus/messageinterpreter.cpp
    • -10
    • +30
    /sources/canbus/messageinterpreter.h
  1. … 22 more files in changeset.
Updated the Copyright with the current year and replaced tabs with 4 spaces

  1. … 38 more files in changeset.
Merge branch 'DEN-1090_MessageHandler' into DEN-1396_LogHandler

DEN-1090 : UI Message Handler / Error Handler

- Incomplete merge of the added feature for First parameter of the BloodFlow has to be unsigned int and changed to S32.

- Updated the unit tests.

    • -1
    • +11
    /sources/canbus/messageinterpreter.cpp
    • -0
    • +8
    /sources/gui/qml/pages/TreatmentStart.qml
Merge branch 'DEN-1090_MessageHandler' into DEN-1396_LogHandler

- Added the changes to the BloodFlow first parameter form unsigned to signed to be updated.

    • -3
    • +3
    /sources/canbus/messageinterpreter.cpp
    • -2
    • +2
    /sources/gui/qml/pages/TreatmentStart.qml
DEN-1090 : UI Message Handler / Error Handler

- First parameter of the BloodFlow has to be unsigned int and changed to S32.

    • -3
    • +7
    /sources/canbus/messageinterpreter.cpp
    • -7
    • +8
    /sources/gui/qml/pages/TreatmentStart.qml
DEN-1396 : UI Log Handler

MISC :

- Updated the Singleton defines to delete the instance.

- Added/moved the floatCompare in the types.cpp and created the file to do so.

LOGGING :

- Implemented logging

- Added LOG_EVENT / LOG_DATUM / LOG_ERROR in code instead of qDebug() as sample of the log event .

- Added export to USB feature.

- Added "Export Button"

    • -4
    • +15
    /sources/canbus/messageinterpreter.cpp
  1. … 11 more files in changeset.
DEN-1396 : UI Log Handler

- Added USB Drive Mount/Umount/Removed detection

- Added USB Drive mounting process error handling

- Added USB Button

- Made File Handler a singleton class which is connected to Main Timer to detect USB insertion and remove.

- Added series of connections in ApplicationController, Guicontroller, GuiView, FileHandler.

- Updated TouchRect to be able to notify user for reaction by fading in/out.

- Modified and added button colors for normal and selected.

- Added disabled functionality to the TouchRect

- Added USB button as a test into Home Screen.

    • -1
    • +1
    /sources/gui/qml/components/MainMenu.qml
    • -9
    • +53
    /sources/gui/qml/components/TouchRect.qml
    • -0
    • +51
    /sources/gui/qml/components/USBButton.qml
    • -15
    • +16
    /sources/gui/qml/globals/Colors.qml
    • -1
    • +1
    /sources/gui/qml/pages/SettingsHome.qml
    • -0
    • +2
    /sources/gui/qml/pages/TreatmentHome.qml
    • -32
    • +92
    /sources/storage/filehandler.cpp
DEN-1396 : UI Log Handler

- Added Detect/Mount USB drive (draft)

- It needs to be revised since it calls two part of the code that I don't know if it's reasonable.

DEN-1434 : UI In-Treatment Screen (Monitoring)

- Added "PWM Duty Cycle" parameter to BloodFlow Monitoring command

    • -2
    • +17
    /sources/canbus/messageinterpreter.cpp
    • -6
    • +15
    /sources/gui/qml/pages/TreatmentStart.qml
DEN-1090 : UI Message Handler / Error Handler

- Fixed a typo

DEN-1090 : UI Message Handler / Error Handler

- Fixed Comment Spacing [Code Review]

DEN-1090 : UI Message Handler / Error Handler

- Updated the constants by enums [Code Review]

    • -1
    • +1
    /sources/canbus/messageinterpreter.cpp
DEN-1090 : UI Message Handler / Error Handler

- Ran cppcheck and skiped unittests folder from cppcheck folders list.

Merge branch 'master' into DEN-1090_MessageHandler

DEN-1090 : UI Message Handler / Error Handler

- Trying a solution to have separate unit tests for each feature.

- Changed the unittests class to tst_canbus since this is the unit test for implemented canbus messages and interaction.

- removed .pro.user from gitignore since denali.pro.user contains configurations for local unit tests setup and need to be cloned for the new ones.

- Fixed issues which has been found during the unit tests.

    • -0
    • +1
    /sources/canbus/messageinterpreter.cpp
    • -0
    • +277
    /unittests/tst_canbus.cpp
    • -0
    • +62
    /unittests/tst_canbus.h
DEN-1090 : UI Message Handler / Error Handler

- renamed MessageHandler to FrameInterface to understand easier in SDD.

    • -0
    • +168
    /sources/canbus/frameinterface.cpp
    • -0
    • +102
    /sources/canbus/frameinterface.h
    • -168
    • +0
    /sources/canbus/messagehandler.cpp
    • -101
    • +0
    /sources/canbus/messagehandler.h
DEN-1090 : UI Message Handler / Error Handler

- The keepAlive implementation was against the design.

    • -29
    • +0
    /sources/canbus/messagedispatcher.cpp
DEN-1090 : UI Message Handler / Error Handler

- Added id for the ModalDialog background rectangle to be able to better define of the object in SquishQt.

    • -1
    • +1
    /sources/gui/qml/components/ModalDialog.qml
DEN-1090 : UI Message Handler / Error Handler

- Added code documentation for the message dispatcher.

    • -2
    • +37
    /sources/canbus/messagedispatcher.cpp
    • -47
    • +61
    /sources/canbus/messagedispatcher.h
DEN-1090 : UI Message Handler / Error Handler

- Fixed build issues

DEN-1090 : UI Message Handler / Error Handler

- Documented the code

- Added gcc flag to use all the warning as errors and don't let the application compile.

- Modified the build frame structure to return bool true as of successful build message and moved the frame list into the function parameter list.

This way by using __attribute_warn_unused_result__ we can force the code who uses this method to check for the return value of successful build.

- Same has been done for some other methods.

    • -11
    • +11
    /sources/canbus/caninterface.cpp
    • -26
    • +187
    /sources/canbus/messagebuilder.cpp
    • -10
    • +11
    /sources/canbus/messageglobals.h
    • -27
    • +27
    /sources/canbus/messagehandler.cpp
    • -56
    • +56
    /sources/canbus/messageinterpreter.cpp
DEN-1090 : UI Message Handler / Error Handler

- Fixed application close which wasn't closing Can Device connection.

- Changed to date to 2019 in copyright section.

- In MessageInterpreter, named getBloodFlowData method parameters to the meaningful data names.

- Moved fromVariant method to Format utility class.

- Added Code documentation and description.

    • -39
    • +46
    /sources/canbus/caninterface.cpp
    • -12
    • +38
    /sources/canbus/messagehandler.h
    • -45
    • +118
    /sources/canbus/messageinterpreter.cpp
  1. … 47 more files in changeset.
DEN-1090 : UI Message Handler / Error Handler

- Moved toHexString to a place more general so can be used everywhere.

- added command line switches to enable the can messages debugging easier.

- Added an Unhandled console out message.

- Added two other alarm message to the registered list but will console out the Unhandled message.

    • -10
    • +26
    /sources/canbus/messageinterpreter.cpp
    • -0
    • +27
    /sources/utility/format.cpp
    • -0
    • +28
    /sources/utility/format.h
DEN-1090 : UI Message Handler / Error Handler

- Added CRC to the messages [added to the sent message and checked for the received message]

- Added ability to to enable/disable crc and keepAlive from project during build

- Added a feature to write the can messages in color formatted to the console in Can interface and Message Handler for easier debugging. Which can also be disabled by code.

- Added Animation to the TouchRect Touch to better understand if it has been touch.

- Added a demo/sample data text to display the corrent Blood Flow values on the StartTreatment Screen.

    • -15
    • +13
    /sources/canbus/caninterface.cpp
    • -26
    • +85
    /sources/canbus/messagebuilder.cpp
    • -12
    • +21
    /sources/canbus/messagebuilder.h
    • -19
    • +3
    /sources/canbus/messagedispatcher.cpp
    • -15
    • +17
    /sources/canbus/messageglobals.h
    • -20
    • +130
    /sources/canbus/messageinterpreter.cpp
    • -0
    • +13
    /sources/gui/qml/components/TouchRect.qml
    • -0
    • +1
    /sources/gui/qml/pages/SettingsHome.qml
  1. … 4 more files in changeset.
DEN-1090 : UI Message Handler / Error Handler

- Modified enum to be enum class for clarification of the code.

- Added Message Interpreter

- Updated Message Builder to check CRC as a placeholder.

- Fixed Message Builder for messages with exactly 255 data length.

- Updated Message Builder methods scope for clarification of the code.

- Updated Message (Model) isComplete method.

- Updated Message Dispatcher to accept only command which has been defined for channel.

- Updated Message Dispatcher to remove the message from model when it has been transmitted.

    • -20
    • +38
    /sources/canbus/caninterface.cpp
    • -41
    • +52
    /sources/canbus/messagebuilder.cpp
    • -35
    • +35
    /sources/canbus/messagebuilder.h
    • -1
    • +115
    /sources/canbus/messagedispatcher.cpp
    • -7
    • +36
    /sources/canbus/messagedispatcher.h
    • -10
    • +16
    /sources/canbus/messageglobals.h
    • -82
    • +48
    /sources/canbus/messagehandler.cpp
    • -14
    • +14
    /sources/canbus/messagehandler.h
    • -21
    • +0
    /sources/canbus/messageinterface.cpp
    • -0
    • +113
    /sources/canbus/messageinterpreter.cpp
  1. … 4 more files in changeset.