UI-UCOMMITS-4 UI Staging Unreviewed Commits

closed on 03 Aug 23

Author

Moderator

Reviewers

UI Staging Unreviewed Commits

Activity

Details
Objectives
General Comments 0
Unresolved
Resolved
Number of files included: 175

application 0
- Folder resources/images 0
  - File Omron-bp7000.png 0 Remove
- Folder scripts 0
  - File run.sh 0 Remove
- Folder sources 0
  - Folder bluetooth 0
    - File BluetoothInterface.cpp 0 Remove
    - File BluetoothInterface.h 0 Remove
  - Folder canbus 0
    - File FrameInterface.cpp 0 Remove
    - File MessageDispatcher.cpp 0 Remove
    - File MessageGlobals.h 0 Remove
    - File MessageInterpreter.cpp 0 Remove
    - File caninterface.cpp 0 Remove
    - File caninterface.h 0 Remove
    - File messagedispatcher.cpp 0 Remove
    - File messagehandler.cpp 0 Remove
    - File messagehandler.cpp 0 Remove
    - File messagehandler.h 0 Remove
    - File messageinterpreter.cpp 0 Remove
    - File messageinterpreter.h 0 Remove
  - Folder cloudsync 0
    - File CloudSyncController.cpp 0 Remove
    - File CloudSyncController.h 0 Remove
  - Folder configuration 0
    - File display.cpp 0 Remove
    - File display.h 0 Remove
    - File sound.cpp 0 Remove
    - File sound.h 0 Remove
  - Folder device 0
    - File DeviceController.cpp 0 Remove
    - File DeviceModels.cpp 0 Remove
    - File DeviceModels.h 0 Remove
  - Folder gui 0
    - Folder qml 0
      - Folder components 0
        
        File BackButton.qml 0 Remove
        
        File ConfirmTreatmentTable.qml 0 Remove
        
        File DebugDataColumn.qml 0 Remove
        
        File ExportButton.qml 0 Remove
        
        File LogoD.qml 0 Remove
        
        File MainMenu.qml 0 Remove
        
        File ModalDialog.qml 0 Remove
        
        File NotificationBar.qml 0 Remove
        
        File RangeSlider.qml 0 Remove
        
        File ScreenItem.qml 0 Remove
        
        File Slider.qml 0 Remove
        
        File StackItem.qml 0 Remove
        
        File StepBullet.qml 0 Remove
        
        File StepIndicator.qml 0 Remove
        
        File TextEntry.qml 0 Remove
        
        File TitleBarCreateTreatment.qml 0 Remove
        
        File TitleText.qml 0 Remove
        
        File TouchRect.qml 0 Remove
        
        File USBButton.qml 0 Remove
      - Folder dialogs 0
        
        File NotificationDialog.qml 0 Remove
        
        File PowerOff.qml 0 Remove
      - Folder globals 0
        
        File Colors.qml 0 Remove
        
        File Fonts.qml 0 Remove
        
        File Variables.qml 0 Remove
        
        File Variables.qml 0 Remove
      - Folder pages 0
        
        Folder endtreatment 0
        
        File EndTreatmentRecirculateStack.qml 0 Remove
        
        Folder posttreatment 0
        
        File PostTreatmentReview.qml 0 Remove
        
        Folder pretreatment 0
        
        Folder create 0
        
        File PreTreatmentConfirm.qml 0 Remove
        
        File PreTreatmentCreate.qml 0 Remove
        
        Folder prime 0
        
        File PreTreatmentPrime.qml 0 Remove
        
        File PreTreatmentUltrafiltration.qml 0 Remove
        
        Folder sample 0
        
        File PreTreatmentWaterSample.qml 0 Remove
        
        File PreTreatmentBase.qml 0 Remove
        
        File PreTreatmentCreateStack.qml 0 Remove
        
        Folder settings 0
        
        File SettingsDateTime.qml 0 Remove
        
        File SettingsExportLogs.qml 0 Remove
        
        File SettingsStack.qml 0 Remove
        
        Folder treatment 0
        
        Folder adjustments 0
        
        File TreatmentAdjustmentUltrafiltrationConfirm.qml 0 Remove
        
        Folder sections 0
        
        File TreatmentHeparin.qml 0 Remove
        
        File TreatmentSaline.qml 0 Remove
        
        File TreatmentCreate.qml 0 Remove
        
        File TreatmentStack.qml 0 Remove
        
        File MainStack.qml 0 Remove
        
        File ManagerHome.qml 0 Remove
        
        File ManagerStack.qml 0 Remove
        
        File SettingsHome.qml 0 Remove
        
        File SettingsStack.qml 0 Remove
        
        File TreatmentCreate.qml 0 Remove
        
        File TreatmentHome.qml 0 Remove
        
        File TreatmentStack.qml 0 Remove
        
        File TreatmentStart.qml 0 Remove
      - File main.qml 0 Remove
      - File main.qml 0 Remove
    - File GuiView.cpp 0 Remove
    - File guiactions.cpp 0 Remove
    - File guiactions.h 0 Remove
    - File guicontroller.cpp 0 Remove
    - File guicontroller.h 0 Remove
    - File guiglobals.cpp 0 Remove
    - File guiglobals.h 0 Remove
    - File guiview.cpp 0 Remove
    - File guiview.h 0 Remove
  - Folder model 0
    - Folder hd 0
      - Folder adjustment 0
        
        Folder disinfect 0
        
        File MDisinfectAdjustModeRequests.h 0 Remove
        
        File MDisinfectAdjustResponse.cpp 0 Remove
        
        File MDisinfectAdjustResponse.h 0 Remove
        
        File MTreatmentAdjustRequests.h 0 Remove
      - Folder alarm 0
        
        File MAlarmMapping.cpp 0 Remove
        
        File MAlarmStatusData.cpp 0 Remove
      - Folder data 0
        
        File MPreTreatmentPrimeData.h 0 Remove
    - Folder settings 0
      - File MBluetooth.cpp 0 Remove
      - File MBluetooth.h 0 Remove
    - File MModel.h 0 Remove
    - File mtreatmentadjustultrafiltrationresponse.cpp 0 Remove
    - File mtreatmentadjustultrafiltrationresponse.h 0 Remove
  - Folder storage 0
    - File DriveWatcher.cpp 0 Remove
    - File DriveWatcher.h 0 Remove
    - File FileHandler.cpp 0 Remove
    - File FileHandler.h 0 Remove
    - File Logger.cpp 0 Remove
    - File Logger.h 0 Remove
    - File StorageGlobals.cpp 0 Remove
    - File StorageGlobals.h 0 Remove
    - File TreatmentLog.cpp 0 Remove
    - File TreatmentLog.h 0 Remove
    - File filehandler.cpp 0 Remove
    - File filehandler.cpp 0 Remove
    - File filehandler.h 0 Remove
    - File filehandler.h 0 Remove
    - File logger.cpp 0 Remove
    - File logger.cpp 0 Remove
    - File logger.h 0 Remove
    - File settings.cpp 0 Remove
    - File settings.h 0 Remove
  - Folder view 0
    - Folder dg/data 0
      - File VDGValvesStatesData.cpp 0 Remove
    - Folder hd 0
      - Folder adjustment 0
        
        Folder disinfect 0
        
        File VDisinfectAdjustDisinfect.cpp 0 Remove
        
        File VDisinfectAdjustDisinfect.h 0 Remove
        
        Folder posttreatment 0
        
        File VPostTreatmentAdjustTreatmentLog.cpp 0 Remove
        
        File VPostTreatmentAdjustTreatmentLog.h 0 Remove
        
        Folder pretreatment 0
        
        File VPreTreatmentAdjustmentDisposablesConfirm.cpp 0 Remove
        
        File VTreatmentAdjustmentUltrafiltrationState.cpp 0 Remove
      - Folder alarm 0
        
        File VAlarmStatus.cpp 0 Remove
      - Folder data 0
        
        File VHDTreatmentStatesData.cpp 0 Remove
        
        File VHDTreatmentStatesData.h 0 Remove
    - Folder settings 0
      - File VAdjustmentVersions.cpp 0 Remove
      - File VAdjustmentVersions.h 0 Remove
      - File VBluetooth.cpp 0 Remove
    - File VTreatmentCreate.cpp 0 Remove
    - File valarmstatus.cpp 0 Remove
    - File valarmstatus.h 0 Remove
    - File vtreatmentadjustmentultrafiltration.cpp 0 Remove
    - File vtreatmentadjustmentultrafiltration.h 0 Remove
  - File applicationcontroller.cpp 0 Remove
  - File applicationcontroller.h 0 Remove
  - File applicationpost.cpp 0 Remove
  - File applicationpost.h 0 Remove
  - File main.h 0 Remove
  - File maintimer.cpp 0 Remove
  - File maintimer.cpp 0 Remove
  - File maintimer.h 0 Remove
- Folder unittests 0
  - File tst_acknow.cpp 0 Remove
  - File tst_canbus.cpp 0 Remove
  - File tst_logging.cpp 0 Remove
  - File tst_logging.h 0 Remove
  - File tst_messaging.cpp 0 Remove
  - File unittests.cpp 0 Remove
  - File unittests.h 0 Remove
- File AlarmMapping.csv 0 Remove
- File cppcheck.err 0 Remove
- File cppcheck.log 0 Remove
- File cppcheck.sh 0 Remove
- File denali.pro 0 Remove
- File denali.pro.user 0 Remove
- File denali.pro.user 0 Remove
- File denali.qrc 0 Remove
- File emailMessage.txt 0 Remove
- File en_US.udic 0 Remove
- File main.cpp 0 Remove
- File main.cpp 0 Remove
common 0
- File .gitignore 0 Remove
- File AlarmDefs.h 0 Remove
- File AlarmDefs.h 0 Remove
- File AlarmDefs.h 0 Remove
- File AlarmDefs.h 0 Remove
- File Compatible.h 0 Remove
- File DGDefs.h 0 Remove
- File DGDefs.h 0 Remove
- File HDDefs.h 0 Remove
- File MsgDefs.h 0 Remove
- File MsgDefs.h 0 Remove
- File MsgDefs.h 0 Remove

#permalink

Details

Warning: no files are visible, they have all been filtered.

Participant	Role	Time Spent	Comments
wbracken (deleted user)	Author & Moderator	0m
Dara Navaei	Reviewer - Complete	9m
Sean Nash	Reviewer - Complete	4m
Behrouz NematiPour	Reviewer - 0% reviewed
Total		14m	0

#permalink

Objectives

There are no specific objectives for this review.

Branches in review

#permalink

Issues Raised From Comments

Key	Summary	State	Assignee

#permalink

General Comments

There are no general comments on this review.

Click to load diff

Notation	Description
[Crucible Review CR-1\|CR-1]	Creates a link to a Crucible review or FishEye artifact using the internal key reference for the item. Example: [Crucible Review CR-1\|CR-1]
[Atlassian Crucible\|http://atlassian.com/crucible]	Creates a link to an external resource, special characters that come after the URL and are not part of it must be separated with a space. External links are denoted with an arrow icon. Example: Atlassian Crucible
{cs:id=1\|rep=repository-key}	Render a link to the changeset Example: 1
bold	Makes text appear bold.
_italic_	Makes text appear in italics.
+underline+	Makes text appear underlined.
??citation??	Makes text appear in citation form.
-strikethrough-	Makes text appear ~~struck through~~.
^superscript^	Makes text appear in ^superscript.
~subscript~	Makes text appear in _subscript.
{{ monospaced }}	Placing double curly-brackets around text makes it appear `monospaced`.
{code} // Some comments here public String getFoo() { return foo; } {code}	The code macro displays a preformatted block for showing code with syntax highlighting. Example: // Some comments here public String getFoo() { return foo; }
bq. Block Quote	To make an entire paragraph into a block quotation, place "bq. " before it. Example: Block Quote
{quote} here is quoteable content to be quoted {quote}	Quote a block of text that's longer than one paragraph. Example: here is quoteable content to be quoted
{color:red} look ma, red text!{color}	Changes the color of a block of text. Example: look ma, red text!
* A list with bullets * Second item ** Indented item	Example: A list with bullets Second item Indented item
# A list with numbers # Second item ## Indented item	Example: A list with numbers Second item Indented item

UI-UCOMMITS-4

UI Staging Unreviewed Commits

UI-UCOMMITS-4 0

Details

Objectives

Branches in review

Issues Raised From Comments

General Comments

Log time

UI Staging Unreviewed Commits

UI-UCOMMITS-4 0

Summarize the review outcomes (optional)

Details

Objectives

Branches in review

Issues Raised From Comments

General Comments

Log time