Controllers

Clone Tools
  • last updated a few seconds ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Fixed it

Fixed it

Updated

Updated

Fixed

Fixed

Remove extra blank line.

Remove extra blank line.

It is your comment, so please resolve it.

It is your comment, so please resolve it.

This function also not using u32ArrayOverride()

This function also not using u32ArrayOverride()

is it possible to use the function u32ArrayOverride() here ?

is it possible to use the function u32ArrayOverride() here ?

Are we sure about the reversing of states here? If we had this backward, I would think the Systems team would have had a much bigger complaint. The description of their issue suggests that the 8 BC...

Are we sure about the reversing of states here? If we had this backward, I would think the Systems team would have had a much bigger complaint.
The description of their issue suggests that the 8 BC valves were correctly commanded to requested state except for the one they separately commanded earlier.
If we had this backward, I would think they would have said that all 8 valves did the wrong thing.

I don't think mask or pos require initialization either.

I don't think mask or pos require initialization either.

I don't think valve needs to be initialized here. The for loop initializes it.

I don't think valve needs to be initialized here. The for loop initializes it.

It is replied by Vinay , there is no need to maintain two different rpm. so we can close this.

It is replied by Vinay , there is no need to maintain two different rpm. so we can close this.

For these functions that set specific valves, we should specify which (e.g. recovery valves or balancing chamber valves, or ...).

For these functions that set specific valves, we should specify which (e.g. recovery valves or balancing chamber valves, or ...).

Remove blank line.

Remove blank line.

LEAHI-DD-FIRMWARE-LDT-3222_Command to override all balancing chamber valves states should be the same priority as setting individual valve state overrides
LEAHI-DD-FIRMWARE-LDT-3222_Command to override all balancing chamber valves states should be the same priority as setting individual valve state overrides
It will be fixed in Balancing chamber re-implementation

It will be fixed in Balancing chamber re-implementation

I would prefer to fix this in balancing chamber new algorithm implementation. That is why i didn't mark it as Unresolved.

I would prefer to fix this in balancing chamber new algorithm implementation. That is why i didn't mark it as Unresolved.

fixed it

fixed it

fixed it

fixed it

This state machine running continuously. fill request is initiated for every 1 minutes of balancing chamber exec (since right now level sensor is not working ) //Increment counter for dry bicarb c...

This state machine running continuously. fill request is initiated for every 1 minutes of balancing chamber exec (since right now level sensor is not working )

//Increment counter for dry bicarb chamber fill
bicarbChamberPeriodicFillCounter += 1;
// Fill bicarb chamber once every 60secs.
if ( bicarbChamberPeriodicFillCounter >= BICARB_CHAMBER_PERIODIC_FILL_TIME )

Unknown macro: { setBicarbChamberFillRequested(); bicarbChamberPeriodicFillCounter = 0; }


The request is cleared here. for consistency I am moving to the end of the fill cycle

LEAHI-DD-FIRMWARE-LDT-3343_DD FW control stops IOFP manual control
LEAHI-DD-FIRMWARE-LDT-3343_DD FW control stops IOFP manual control
Mis-spelled "Stabilized".

Mis-spelled "Stabilized".

I think you can do this in 1 line of code using the RANGE macro in Common.h.

I think you can do this in 1 line of code using the RANGE macro in Common.h.

Remove blank line.

Remove blank line.

Add a blank line before return statement.

Add a blank line before return statement.

Why is this commented out?

Why is this commented out?

d48PumpSpeed is an input.

d48PumpSpeed is an input.