dd-firmware / firmware / App

Modes

Clone Tools

Stats

Commits this week: 7
Total Committers: 16
Last Commit: 12 May
Commits this week: 7

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Tuesday 12 May
10:22 am

Raghu Kallala

LDT-4413 fixed the order how data1 and data2 parsed in FP event calls

Options
    • -0
    • +2
    ./FPModes/FPOperationModes.c
    • -1
    • +1
    ./FPModes/ModeGenPermeate.c
    • -1
    • +1
    ./FPModes/ModeGenPermeateDefeatured.c
    • -1
    • +1
    ./FPModes/ModePreGenPermeate.c
    • -1
    • +1
    ./FPModes/ModePreGenPermeateDefeatured.c
Monday 11 May
11:55 am

Vinayakam Mani

Why did we remove this? This is needed for BC Switch only condition.

Why did we remove this? This is needed for BC Switch only condition.

11:14 am

Vinayakam Mani

LDT-3958 reolving merge conflicts

Options
    • -4
    • +2
    ./ModeGenDialysate.c
  2. … 5 more files in changeset.
9:42 am

Raghu Kallala

8:51 am

Sean Nash

Friday 08 May
1:21 pm

Sean Nash

Again, I don't like these oriented this way. Please change to #ifndef DISABLE_ALARM_4

Again, I don't like these oriented this way. Please change to #ifndef DISABLE_ALARM_4

1:19 pm

Sean Nash

If BC switching period is Zero, I would expect the Qd from TD to also be zero, right? But what if it's not? What if Qd from TD is 600 and switching period is zero? You are going to run the pump pre...

If BC switching period is Zero, I would expect the Qd from TD to also be zero, right? But what if it's not? What if Qd from TD is 600 and switching period is zero? You are going to run the pump pretty fast with no BC switching in that case.

1:10 pm

Sean Nash

We shouldn't require something to be defined to do the right thing. We should require something to be defined to do the wrong thing (i.e. this should say #ifndef _BAD_MSG_CRC_ALARM_DISABLED_) And t...

We shouldn't require something to be defined to do the right thing. We should require something to be defined to do the wrong thing (i.e. this should say #ifndef _BAD_MSG_CRC_ALARM_DISABLED_)
And then, we don't need a TODO. These #defines are only possible in DEBUG builds. A RELEASE build will never allow thing build flags to disable things.

Thursday 07 May
2:29 pm

Vendor - TEL - Jashwant Gantyada

LDT-3963 addressed code review/vinay's comments

Options
    • -6
    • +5
    ./ModeGenDialysate.c
    • -1
    • +1
    ./ModeGenDialysate.h
  3. … 1 more file in changeset.
Wednesday 06 May
1:52 pm

Dara Navaei

LEAHI-DD-FIRMWARE-LDT-3958_Dialysate Temperature - FW Implementation - 2/2:
LEAHI-DD-FIRMWARE-LDT-3958_Dialysate Temperature - FW Implementation - 2/2:
1:41 pm

Vinayakam Mani

LDT-3958 heater control update

Options
    • -2
    • +0
    ./ModeGenDialysate.c
  2. … 7 more files in changeset.
9:59 am

Vinayakam Mani

LDT-872 heater control update

Options
    • -0
    • +1
    ./ModeGenDialysate.c
    • -9
    • +0
    ./ModeGenDialysate.h
  3. … 1 more file in changeset.
9:39 am

Vinayakam Mani

LDT-872 heater control update

Options
    • -2
    • +2
    ./ModeGenDialysate.c
  2. … 5 more files in changeset.
9:26 am

Michael Garthwaite

Merge branch 'staging' into LDT-3975-Boost-Pump

Options
    • -4
    • +4
    ./FPModes/ModePreGenPermeate.c
    • -5
    • +5
    ./FPModes/StateFlushConcentrate.c
    • -6
    • +5
    ./FPModes/StateFlushPermeate.c
8:48 am

Dara Navaei

LEAHI-DD-FIRMWARE-LDT-4246_FW Support for UI Demo
LEAHI-DD-FIRMWARE-LDT-4246_FW Support for UI Demo
Tuesday 05 May
12:35 pm

Vinayakam Mani

Remove this flag.

Remove this flag.

12:31 pm

Vinayakam Mani

Remove this code.

Remove this code.

11:57 am

Vinayakam Mani

Remove this condition to apply the speed for BC switch only as well.

Remove this condition to apply the speed for BC switch only as well.

10:55 am

Michael Garthwaite and Vinayakam Mani

10:38 am

Raghu Kallala

LEAHI-DD-FIRMWARE-LDT-4188_SW/FW integration to run a Treatment from UI
LEAHI-DD-FIRMWARE-LDT-4188_SW/FW integration to run a Treatment from UI
10:20 am

Vinayakam Mani

Check the else portion and do the required changes.

Check the else portion and do the required changes.

9:37 am

Vendor - TEL - Jashwant Gantyada

Merge branch 'staging' into feature/LDT-3963-dialysate-flow-rate---fw-implem

Options
    • -2
    • +3
    ./ModeGenDialysate.c
    • -10
    • +1
    ./ModeGenDialysate.h
  3. … 1 more file in changeset.
6:58 am

Dara Navaei

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

Options
    • -2
    • +2
    ./ModeGenDialysate.c
    • -1
    • +1
    ./ModeGenDialysate.h
  3. … 2 more files in changeset.
6:53 am

Raghu Kallala

LDT-4188 resolved merge conflict with satging

Options
    • -5
    • +5
    ./ModeGenDialysate.c
Monday 04 May
4:15 pm

Vinayakam Mani

Name something similar to 'BCSwitchingBasedOnClosePeriodCounter'?

Name something similar to 'BCSwitchingBasedOnClosePeriodCounter'?

4:03 pm

Vinayakam Mani

I guess, all these checks should be moved to FillEndState.

I guess, all these checks should be moved to FillEndState.

3:52 pm

Vinayakam Mani

after one state of BC switching completed. update the next comment as well.

after one state of BC switching completed. update the next comment as well.

2:39 pm

Vendor - TEL - Jashwant Gantyada

LDT-3963 dialysate flow rate algorithm changes and testing

Options
    • -8
    • +35
    ./ModeGenDialysate.c
    • -1
    • +2
    ./ModeGenDialysate.h
  3. … 10 more files in changeset.
9:59 am

Vendor - TEL - Arpita Srivastava

Should we add a TODO to remove this one as well?

Should we add a TODO to remove this one as well?

9:57 am

Vendor - TEL - Arpita Srivastava

If we are removing this call, then where are we calling the function testDDFloaterLevelStateOverride?

If we are removing this call, then where are we calling the function testDDFloaterLevelStateOverride?