Clone Tools
  • last updated a few seconds ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Remove extra blank line.

Remove extra blank line.

It is your comment, so please resolve it.

It is your comment, so please resolve it.

Merged LDT-2030 and resolved the conflicts

  1. … 6 more files in changeset.
It is replied by Vinay , there is no need to maintain two different rpm. so we can close this.

It is replied by Vinay , there is no need to maintain two different rpm. so we can close this.

LDT-2004-4 drybicart updates

  1. … 1 more file in changeset.
For these functions that set specific valves, we should specify which (e.g. recovery valves or balancing chamber valves, or ...).

For these functions that set specific valves, we should specify which (e.g. recovery valves or balancing chamber valves, or ...).

Remove blank line.

Remove blank line.

It will be fixed in Balancing chamber re-implementation

It will be fixed in Balancing chamber re-implementation

I would prefer to fix this in balancing chamber new algorithm implementation. That is why i didn't mark it as Unresolved.

I would prefer to fix this in balancing chamber new algorithm implementation. That is why i didn't mark it as Unresolved.

Merge branch staing into LDT-2004-drybicarb---dd

  1. … 13 more files in changeset.
LDT-3343 added valve actuation per water recovery

  1. … 4 more files in changeset.
LDT-3343 implemented test config to run DD alone and wait for IOFP gen mode

  1. … 2 more files in changeset.
LDT-2004-3 dry bicart updates

  1. … 1 more file in changeset.
fixed it

fixed it

fixed it

fixed it

This state machine running continuously. fill request is initiated for every 1 minutes of balancing chamber exec (since right now level sensor is not working ) //Increment counter for dry bicarb c...

This state machine running continuously. fill request is initiated for every 1 minutes of balancing chamber exec (since right now level sensor is not working )

//Increment counter for dry bicarb chamber fill
bicarbChamberPeriodicFillCounter += 1;
// Fill bicarb chamber once every 60secs.
if ( bicarbChamberPeriodicFillCounter >= BICARB_CHAMBER_PERIODIC_FILL_TIME )

Unknown macro: { setBicarbChamberFillRequested(); bicarbChamberPeriodicFillCounter = 0; }


The request is cleared here. for consistency I am moving to the end of the fill cycle

LEAHI-DD-FIRMWARE-LDT-3343_DD FW control stops IOFP manual control
LEAHI-DD-FIRMWARE-LDT-3343_DD FW control stops IOFP manual control
Mis-spelled "Stabilized".

Mis-spelled "Stabilized".

I think you can do this in 1 line of code using the RANGE macro in Common.h.

I think you can do this in 1 line of code using the RANGE macro in Common.h.

Remove blank line.

Remove blank line.

Add a blank line before return statement.

Add a blank line before return statement.

Why is this commented out?

Why is this commented out?

d48PumpSpeed is an input.

d48PumpSpeed is an input.

LEAHI-DD-FIRMWARE-LDT-2004_Dialysate Composition - DD
LEAHI-DD-FIRMWARE-LDT-2004_Dialysate Composition - DD
What should trimmer heater be doing in these spent/bicarb chamber states?

What should trimmer heater be doing in these spent/bicarb chamber states?

I would think this would be enabled by default.

I would think this would be enabled by default.

Why is this flag set to FALSE here in start state while the other request flags are set to FALSE in their completed states?

Why is this flag set to FALSE here in start state while the other request flags are set to FALSE in their completed states?