· /firmware/App/Controllers/DialysatePumps.c	(-7, +7)	| History	| Source	| Diff
· /firmware/App/Modes/ModeInitPOST.c	(-2, +2)	| History	| Source	| Diff
· /firmware/App/Services/Messaging.c	(-1, +3)	| History	| Source	| Diff
· /firmware/App/Services/NVJobQ.c	(-0, +320)	| History	| Source
· /firmware/App/Services/NVJobQ.h	(-0, +81)	| History	| Source
· /firmware/App/Services/NVMessaging.c	(-0, +764)	| History	| Source
· /firmware/App/Services/NVMessaging.h	(-0, +51)	| History	| Source
· /firmware/App/Services/NVMgmtDD.c	(-74, +91)	| History	| Source	| Diff
· /firmware/App/Services/NVMgmtDD.h	(-4, +9)	| History	| Source	| Diff
· /firmware/App/Services/NVMsgQ.c	(-1033, +0)	| History	| Source	| Diff
· /firmware/App/Services/NVMsgQ.h	(-90, +0)	| History	| Source	| Diff
· /firmware/App/Services/NVRecordsDD.c	(-20, +21)	| History	| Source	| Diff
· /firmware/App/Services/NVRecordsDD.h	(-3, +3)	| History	| Source	| Diff
· /firmware/App/Tasks/TaskBG.c	(-2, +2)	| History	| Source	| Diff
· /firmware/App/Tasks/TaskGeneral.c	(-2, +2)	| History	| Source	| Diff

]]> Sun, 26 Apr 2026 14:42:31 -0700 Sean Nash https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3735-1/#c28684 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3735-1/#c28684 Sean Nash commented on LEAHI-DD-FIRMWARE-LDT-3735-1

So this unit manages the sending of record messages, right? I don't see a unit managing read/write/erase jobs. Where is that queue?

I think this enum should be in a different header file. I don't think this unit uses this enum.

Slot size and offsets can probably be private and maybe better placed in a different header file? I don't see why a msg Q would need/use/be responsible for this kind of thing.

These addresses should be calculated in init function from sector start addresses (call driver get function to get these) and your offsets and stored in static variables within the .c file.

Do these need to be public?
I think only the driver should have to know sector addresses and sizes.
If other units want to know these things, they should call a function in this driver to get them.

I think isSectorStartAddress is a better function name.

Be careful with bufferSize. Make sure you understand what it means (e.g. is it bytes or words). I believe the FAPI functions deal in 4-byte words and it caused some issues for Dara because he thought this was bytes.

don't forget to add function headers.

// **************** private functions **************

I think this driver should be moved to FWCommon folder as it should work the same for both DD and TD firmware.

Add a blank line before group end marker.

No load cells in Leahi.

I think this enum belongs to NVRecords (these are records, not jobs).

I think this enum belongs to the Q (these are Q jobs), not in driver.

What about TD record CRC errors?

Are we only doing DD messages?
And since these could be coming from UI now, these shouldn't be considered "Dialin" messages anymore and should be moved up to section before 0x8000 IDs where normal system messages are defined.