Activity dgfirmware/

Tree
Accordion

Stats

Commits this week: 0

Total Committers:	17
Last Commit:	19 Nov 25
Commits this week:	0

Lines of code count not available

Commit Activity

last updated a few seconds ago

Constraints

Constraints: committers

Committer:

Log Comment:

Constraints: files

File Extension:

File Name:

Constraints: dates

Start Date:

Start Date:

End Date:

End Date:

Friday 17 Mar 2023

2:19 pm

Michael Garthwaite

More
6989d68
changed 0 files
DEN-14316-chemical-disinfect, DEN-14646-fpga-alarm-properties-and-timing-3 and 144 more

Merge branch 'DEN-14689-messaging-bugs' into staging

2:18 pm

Michael Garthwaite

More
91de942
changed 1 file
DEN-14316-chemical-disinfect, DEN-14646-fpga-alarm-properties-and-timing-3 and 145 more DG-DEN-14689-1

DEN-14689: Fixed duplicate case

- -4
- +0
/firmware/App/Services/SystemComm.c
- History
- Source
- Diff
/firmware/App/Services/SystemComm.c

2:11 pm

Michael Garthwaite

More
62ab9ef
changed 1 file
DEN-14316-chemical-disinfect, DEN-14646-fpga-alarm-properties-and-timing-3 and 145 more DG-DEN-14689-1

DEN-14689: sync'd out of message naming

- -1
- +1
/firmware/App/Services/SystemComm.c
- History
- Source
- Diff
/firmware/App/Services/SystemComm.c

1:48 pm

Michael Garthwaite

More
e7fefa4
changed 0 files
DEN-14316-chemical-disinfect, DEN-14646-fpga-alarm-properties-and-timing-3 and 145 more

Merge branch 'staging' into DEN-14689-messaging-bugs

8:56 am

jtaylor (deleted user)

More
Re: DG-DEN-14763-1
commented on review

I would suggest a more consistent naming for the enum items. "DISINFECT_USAGE_" rather than USAGE_INFO_ in the enum elements, and eliminating the "_DIS". This would be more specific since "USAGE" a...

I would suggest a more consistent naming for the enum items. "DISINFECT_USAGE_" rather than USAGE_INFO_ in the enum elements, and eliminating the "_DIS".
This would be more specific since "USAGE" and "INFO" are redundant, and "DIS" can be confused with "dis-", the Latin prefix.

Thursday 16 Mar 2023

10:08 pm

wbracken (deleted user)

More
Re: DG-DEN-14763-1
commented on review

Comment alignment.

Comment alignment.

8:34 pm

Dara Navaei

More
cd78f2d
changed 0 files
DEN-14316-chemical-disinfect, DEN-14646-fpga-alarm-properties-and-timing-3 and 143 more

Merge branch 'staging' into DEN-14763-dg_hd_dev-hd_dg_dvt-update-part-10

8:33 pm

Dara Navaei

More
ae07878
changed 1 file
DEN-14316-chemical-disinfect, DEN-14646-fpga-alarm-properties-and-timing-3 and 143 more DG-DEN-14763-1

DEN-14763 updated the heat disinfect active cool per the requirements

- -24
- +38
/firmware/App/Modes/ModeHeatDisinfectActiveCool.c
- History
- Source
- Diff
/firmware/.../ModeHeatDisinfectActiveCool.c

2:04 pm

Dara Navaei

Bamboo Commit: Updated DGCommon.h with build versions from Bamboo

- -1
- +1
/firmware/App/DGCommon.h
- History
- Source
- Diff
/firmware/App/DGCommon.h

2:01 pm

Michael Garthwaite

Merge branch 'DIAL-243-integrated-volume-is-not-working' into develop

- -1
- +1
/firmware/App/Modes/ModeFill.c
- History
- Source
- Diff
/firmware/App/Modes/ModeFill.c
- -1
- +1
/firmware/App/Services/SystemCommMessages.c
- History
- Source
- Diff
/firmware/App/.../SystemCommMessages.c

2:00 pm

Michael Garthwaite

More
34ccae6
changed 1 file
DEN-14316-chemical-disinfect, DEN-14646-fpga-alarm-properties-and-timing-3 and 145 more DG-DEN-14788-3

DIAL-243: Fixed header.

- -1
- +1
/firmware/App/Modes/ModeFill.h
- History
- Source
- Diff
/firmware/App/Modes/ModeFill.h

1:57 pm

Michael Garthwaite

More
957988f
changed 2 files
DEN-14316-chemical-disinfect, DEN-14646-fpga-alarm-properties-and-timing-3 and 145 more DG-DEN-14788-3

DIAL-243: fixed integrated volume data type from u32 to f32

- -1
- +1
/firmware/App/Modes/ModeFill.c
- History
- Source
- Diff
/firmware/App/Modes/ModeFill.c
- -1
- +1
/firmware/App/Services/SystemCommMessages.c
- History
- Source
- Diff
/firmware/App/.../SystemCommMessages.c

12:12 pm

wbracken (deleted user)

RESOLVED IN CODE WALKTHROUGH

RESOLVED IN CODE WALKTHROUGH

12:11 pm

wbracken (deleted user)

RESOLVED IN CODE WALKTHROUGH

RESOLVED IN CODE WALKTHROUGH

12:10 pm

wbracken (deleted user)

RESOLVED IN CODE WALKTHROUGH

RESOLVED IN CODE WALKTHROUGH

12:08 pm

wbracken (deleted user)

RESOLVED IN CODE WALKTHROUGH

RESOLVED IN CODE WALKTHROUGH

12:07 pm

wbracken (deleted user)

RESOLVED IN CODE WALKTHROUGH

RESOLVED IN CODE WALKTHROUGH

12:07 pm

wbracken (deleted user)

RESOLVED IN CODE WALKTHROUGH

RESOLVED IN CODE WALKTHROUGH

12:07 pm

wbracken (deleted user)

RESOLVED IN CODE WALKTHROUGH

RESOLVED IN CODE WALKTHROUGH

12:06 pm

wbracken (deleted user)

RESOLVED IN CODE WALKTHROUGH

RESOLVED IN CODE WALKTHROUGH

11:37 am

wbracken (deleted user)

RESOLVED IN CODE WALKTHROUGH

RESOLVED IN CODE WALKTHROUGH

11:22 am

wbracken (deleted user)

RESOLVED IN CODE WALKTHROUGH

RESOLVED IN CODE WALKTHROUGH

11:21 am

wbracken (deleted user)

RESOLVED IN CODE WALKTHROUGH

RESOLVED IN CODE WALKTHROUGH

11:20 am

wbracken (deleted user)

RESOLVED IN CODE WALKTHROUGH

RESOLVED IN CODE WALKTHROUGH

9:44 am

jtaylor (deleted user)

RESOLVED IN CODE WALKTHROUGH.

RESOLVED IN CODE WALKTHROUGH.

9:38 am

Dara Navaei

Bamboo Commit: Updated DGCommon.h with build versions from Bamboo

- -1
- +1
/firmware/App/DGCommon.h
- History
- Source
- Diff
/firmware/App/DGCommon.h

9:34 am

Michael Garthwaite

Merge branch 'DIAL-222-sys-request' into develop

- -0
- +5
/firmware/App/Controllers/Heaters.c
- History
- Source
- Diff
/firmware/App/Controllers/Heaters.c

9:33 am

Michael Garthwaite

More
eb3d609
changed 1 file
DEN-14316-chemical-disinfect, DEN-14646-fpga-alarm-properties-and-timing-3 and 143 more DG-DEN-14788-4

DIAL-222: fixed heaters override reset.

- -0
- +5
/firmware/App/Controllers/Heaters.c
- History
- Source
- Diff
/firmware/App/Controllers/Heaters.c

9:10 am

jtaylor (deleted user)

More
Re: DG-DEN-14646-1
replied to wbracken (deleted user)

RESOLVED IN CODE WALKTHROUGH.

RESOLVED IN CODE WALKTHROUGH.

Wednesday 15 Mar 2023

5:19 pm

Dara Navaei

More
184ee0c
changed 8 files
DEN-14316-chemical-disinfect, DEN-14646-fpga-alarm-properties-and-timing-3 and 143 more DG-DEN-14763-1

DEN-14763 addressed the code review comments and added inlet water conditions to the heat disinfect active cool

- -0
- +1
/firmware/App/Controllers/ConductivitySensors.c
- History
- Source
- Diff
/firmware/App/.../ConductivitySensors.c
- -0
- +1
/firmware/App/Controllers/Pressures.c
- History
- Source
- Diff
/firmware/App/Controllers/Pressures.c
- -1
- +5
/firmware/App/Controllers/ROPump.c
- History
- Source
- Diff
/firmware/App/Controllers/ROPump.c
- -0
- +1
/firmware/App/Controllers/TemperatureSensors.c
- History
- Source
- Diff
/firmware/App/.../TemperatureSensors.c
- -1
- +1
/firmware/App/Modes/ModeHeatDisinfect.c
- History
- Source
- Diff
/firmware/App/Modes/ModeHeatDisinfect.c
- -43
- +210
/firmware/App/Modes/ModeHeatDisinfectActiveCool.c
- History
- Source
- Diff
/firmware/.../ModeHeatDisinfectActiveCool.c
- -4
- +2
/firmware/App/Modes/ModeStandby.c
- History
- Source
- Diff
/firmware/App/Modes/ModeStandby.c
- -1
- +1
/firmware/App/Modes/OperationModes.c
- History
- Source
- Diff
/firmware/App/Modes/OperationModes.c

Atlassian Fisheye Git analysis with Crucible code review. (Version:4.8.14 Build:20240111091859 2024-01-11 09:20) - Administration - Page generated 2026-02-13 11:06 -0800