dgfirmware

Clone Tools

Stats

Commits this week: 0
Total Committers: 17
Last Commit: 19 Nov
Commits this week: 0

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Thursday 10 Dec 2020
3:19 pm

Dara Navaei

DEN-5855 addressed code review comments

Options
    • -28
    • +25
    /firmware/App/Controllers/ROPump.c
    • -0
    • +2
    /firmware/App/Modes/ModeInitPOST.c
    • -11
    • +5
    /firmware/App/Services/SystemCommMessages.c
    • -1
    • +0
    /firmware/App/Services/SystemCommMessages.h
    • -1
    • +1
    /results/Build_Status_Report.csv
    • -625
    • +4107
    /results/VectorCAST.log
    • -4
    • +4
    /results/cppcheckError.csv
1:39 pm

Dara Navaei

DEN-5855 merged DEN-5873, UV reactors and ran the script

Options
    • -1
    • +0
    /firmware/App/Controllers/ConcentratePumps.c
    • -0
    • +6
    /firmware/App/Modes/ModeInitPOST.c
    • -0
    • +12
    /firmware/App/Services/SystemComm.c
    • -29
    • +166
    /firmware/App/Services/SystemCommMessages.c
    • -0
    • +14
    /firmware/App/Services/SystemCommMessages.h
    • -2
    • +14
    /firmware/App/Tasks/TaskGeneral.c
    • -0
    • +2
    /firmware/source/sys_main.c
    • -12
    • +6
    /results/Build_Status_Report.csv
    • -1821
    • +3105
    /results/VectorCAST.log
    • -50
    • +52
    /results/cppcheck.log
    • -3
    • +3
    /results/cppcheckError.csv
Wednesday 09 Dec 2020
9:24 pm

Dara Navaei

DEN-5855 resolved merge conflicts and ran the script

Options
    • -11
    • +5
    /firmware/App/Controllers/ROPump.c
    • -9
    • +1
    /firmware/App/Services/SystemComm.c
    • -129
    • +20
    /firmware/App/Services/SystemCommMessages.c
    • -5
    • +2
    /firmware/App/Services/SystemCommMessages.h
    • -0
    • +94
    /results/Build_Status_Report.csv
    • -0
    • +37701
    /results/VectorCAST.log
    • -0
    • +158
    /results/cppcheck.log
    • -0
    • +84
    /results/cppcheckError.csv
3:05 pm

Dara Navaei

DEN-5855 merged DEN-5864-RO Pump

Options
    • -9
    • +8
    /firmware/App/Modes/ModeFill.c
    • -8
    • +0
    /firmware/App/Services/MessagePayloads.h
    • -0
    • +24
    /firmware/App/Services/SystemComm.c
    • -16
    • +185
    /firmware/App/Services/SystemCommMessages.c
    • -1
    • +14
    /firmware/App/Services/SystemCommMessages.h
1:54 pm

Dara Navaei

DEN-5855 resolved merge conflicts

Options
    • -30
    • +0
    /firmware/App/Services/SystemComm.c
    • -162
    • +1
    /firmware/App/Services/SystemCommMessages.c
    • -1
    • +2
    /firmware/App/Services/SystemCommMessages.h
1:36 pm

Dara Navaei

DEN-5855 mereged master into the branch and resolved the merge conflicts

Options
    • -0
    • +1
    /firmware/App/Controllers/ConcentratePumps.c
    • -0
    • +1
    /firmware/App/Controllers/ConductivitySensors.c
    • -0
    • +11
    /firmware/App/Modes/ModeInitPOST.c
    • -0
    • +42
    /firmware/App/Services/SystemComm.c
    • -869
    • +1215
    /firmware/App/Services/SystemCommMessages.c
    • -3
    • +22
    /firmware/App/Services/SystemCommMessages.h
    • -91
    • +0
    /results/Build_Status_Report.csv
    • -34356
    • +0
    /results/VectorCAST.log
    • -158
    • +0
    /results/cppcheck.log
    • -88
    • +0
    /results/cppcheckError.csv
1:11 pm

Dara Navaei

DEN-5846 ran the script

Options
    • -7
    • +3
    /results/Build_Status_Report.csv
    • -816
    • +920
    /results/VectorCAST.log
11:41 am

Dara Navaei

DEN-5846 addressed code review comment

Options
    • -1
    • +1
    /firmware/App/Services/SystemComm.c
    • -2
    • +2
    /firmware/App/Services/SystemCommMessages.c
    • -1
    • +1
    /firmware/App/Services/SystemCommMessages.h
11:37 am

Dara Navaei

DEN-5873 code review

Options
    • -17
    • +6
    /firmware/App/Controllers/UVReactors.c
9:24 am

Dara Navaei

DEN-5846 ran the script

Options
    • -9
    • +5
    /firmware/App/Controllers/Thermistors.c
    • -11
    • +6
    /results/Build_Status_Report.csv
    • -1143
    • +2449
    /results/VectorCAST.log
    • -1
    • +1
    /results/cppcheckError.csv
8:07 am

Dara Navaei

DEN-5855 addressed code review comments

Options
    • -12
    • +5
    /firmware/App/Controllers/DrainPump.c
    • -1
    • +1
    /firmware/App/Controllers/ROPump.c
    • -1
    • +1
    /firmware/App/Controllers/TemperatureSensors.c
    • -3
    • +2
    /results/Build_Status_Report.csv
    • -1113
    • +1157
    /results/VectorCAST.log
Tuesday 08 Dec 2020
1:59 pm

Dara Navaei

DEN-5864 addressed code review comments and continued with dev testing

Options
    • -48
    • +33
    /firmware/App/Controllers/ROPump.c
    • -1
    • +1
    /firmware/App/Controllers/TemperatureSensors.c
    • -4
    • +3
    /firmware/App/Modes/ModeFill.c
    • -4
    • +3
    /firmware/App/Services/SystemCommMessages.c
Monday 07 Dec 2020
6:34 pm

Dara Navaei

DEN-5873 addressed code review comments and continued with dev testing

Options
    • -1
    • +1
    /firmware/App/Controllers/TemperatureSensors.c
    • -15
    • +22
    /firmware/App/Controllers/UVReactors.c
    • -11
    • +10
    /firmware/App/Services/SystemCommMessages.c
    • -1
    • +1
    /results/Build_Status_Report.csv
    • -1077
    • +1087
    /results/VectorCAST.log
2:54 pm

Dara Navaei

DEN-5846 addressed code review comments and continued with dev testing

Options
    • -1
    • +1
    /firmware/App/Controllers/Fans.c
    • -33
    • +26
    /firmware/App/Controllers/TemperatureSensors.c
    • -0
    • +3
    /firmware/App/Controllers/Thermistors.c
    • -5
    • +5
    /firmware/App/Services/SystemCommMessages.c
12:36 pm

Dara Navaei

DEN-3421 fixed a typo

Options
    • -3
    • +3
    /firmware/App/Controllers/UVReactors.c
    • -1
    • +1
    /firmware/App/Services/AlarmMgmt.h
11:20 am

Quang Nguyen <qnguyen@diality.com>

Disable dialysate composition alarm

Options
    • -0
    • +2
    /firmware/App/Controllers/ConcentratePumps.c
    • -0
    • +2
    /firmware/App/Controllers/ConductivitySensors.c
    • -0
    • +2
    /firmware/App/Modes/ModeFill.c
Sunday 06 Dec 2020
10:06 am

Dara Navaei

DEN-5846 addressed code review comments and continued with dev testing

Options
    • -0
    • +4
    /firmware/.launches/DG.launch
    • -2
    • +3
    /firmware/App/Controllers/ConcentratePumps.c
    • -5
    • +8
    /firmware/App/Controllers/ConductivitySensors.c
    • -49
    • +37
    /firmware/App/Controllers/Fans.c
    • -2
    • +4
    /firmware/App/Controllers/Pressures.c
    • -154
    • +78
    /firmware/App/Controllers/TemperatureSensors.c
    • -14
    • +18
    /firmware/App/Controllers/Thermistors.c
    • -1
    • +3
    /firmware/App/Modes/ModeFill.c
    • -2
    • +2
    /firmware/App/Services/FPGA.c
    • -1
    • +1
    /firmware/App/Services/FPGA.h
    • -8
    • +0
    /firmware/App/Services/MessagePayloads.h
    • -3
    • +3
    /firmware/App/Services/SystemComm.c
    • -36
    • +36
    /firmware/App/Services/SystemCommMessages.c
    • -3
    • +3
    /firmware/App/Services/SystemCommMessages.h
    • -3
    • +16
    /results/Build_Status_Report.csv
  16. … 3 more files in changeset.
Friday 04 Dec 2020
4:06 pm

Quang Nguyen <qnguyen@diality.com>

Temporary fixes for check persistent alarms

Options
    • -2
    • +2
    /firmware/App/Controllers/ConcentratePumps.c
    • -5
    • +5
    /firmware/App/Controllers/ConductivitySensors.c
    • -2
    • +2
    /firmware/App/Controllers/Pressures.c
    • -2
    • +2
    /firmware/App/Controllers/TemperatureSensors.c
    • -1
    • +1
    /firmware/App/DGCommon.h
    • -1
    • +1
    /firmware/App/Modes/ModeFill.c
    • -1
    • +0
    /firmware/App/Modes/ModeFill.h
    • -8
    • +0
    /firmware/App/Services/MessagePayloads.h
    • -4
    • +4
    /firmware/App/Services/SystemComm.c
    • -0
    • +19
    /firmware/App/Services/SystemCommMessages.c
    • -1
    • +4
    /firmware/App/Services/SystemCommMessages.h
Thursday 03 Dec 2020
3:30 pm

Dara Navaei

DEN-5873 continued with dev testing

Options
    • -3
    • +13
    /results/Build_Status_Report.csv
    • -1218
    • +2279
    /results/VectorCAST.log
    • -48
    • +51
    /results/cppcheck.log
    • -25
    • +28
    /results/cppcheckError.csv
2:11 pm

Dara Navaei

DEN-5855 addressed code review comments and continued with dev testing

Options
    • -2
    • +3
    /firmware/App/Controllers/ConcentratePumps.c
    • -5
    • +8
    /firmware/App/Controllers/ConductivitySensors.c
    • -46
    • +11
    /firmware/App/Controllers/DrainPump.c
    • -1
    • +1
    /firmware/App/Controllers/DrainPump.h
    • -2
    • +4
    /firmware/App/Controllers/Pressures.c
    • -1
    • +1
    /firmware/App/Controllers/ROPump.c
    • -2
    • +3
    /firmware/App/Controllers/TemperatureSensors.c
    • -1
    • +3
    /firmware/App/Modes/ModeFill.c
    • -0
    • +8
    /firmware/App/Modes/ModeInitPOST.c
    • -8
    • +0
    /firmware/App/Services/MessagePayloads.h
    • -2
    • +2
    /firmware/App/Services/PIControllers.c
    • -1
    • +3
    /firmware/App/Services/PIControllers.h
    • -52
    • +19
    /firmware/App/Services/SystemCommMessages.c
    • -4
    • +0
    /firmware/App/Services/SystemCommMessages.h
    • -5
    • +12
    /results/Build_Status_Report.csv
  16. … 3 more files in changeset.
Wednesday 02 Dec 2020
4:58 pm

Dara Navaei

DEN-5864 addressed code review comments and continued with dev testing

Options
    • -47
    • +3
    /firmware/App/Controllers/ROPump.c
    • -1
    • +1
    /firmware/App/Controllers/ROPump.h
    • -3
    • +3
    /firmware/App/Modes/ModeFill.c
    • -2
    • +3
    /firmware/App/Modes/ModeRecirculate.c
    • -3
    • +3
    /firmware/App/Services/PIControllers.c
    • -0
    • +1
    /firmware/App/Services/PIControllers.h
    • -7
    • +3
    /firmware/App/Services/SystemComm.c
    • -54
    • +24
    /firmware/App/Services/SystemCommMessages.c
    • -6
    • +3
    /firmware/App/Services/SystemCommMessages.h
12:47 pm

Dara Navaei

DEN-5873 added TODO comments for the persistent alarm checks

Options
    • -0
    • +1
    /firmware/App/Controllers/ConcentratePumps.c
    • -0
    • +3
    /firmware/App/Controllers/ConductivitySensors.c
    • -0
    • +2
    /firmware/App/Controllers/Pressures.c
    • -0
    • +1
    /firmware/App/Controllers/TemperatureSensors.c
12:35 pm

Dara Navaei

DEN-5873 made some temporary changes in the code to be able to use the latest changed from peristent alarm driver

Options
    • -2
    • +2
    /firmware/App/Controllers/ConcentratePumps.c
    • -5
    • +5
    /firmware/App/Controllers/ConductivitySensors.c
    • -2
    • +2
    /firmware/App/Controllers/Pressures.c
    • -2
    • +2
    /firmware/App/Controllers/TemperatureSensors.c
    • -1
    • +1
    /firmware/App/Modes/ModeFill.c
    • -8
    • +0
    /firmware/App/Services/MessagePayloads.h
11:26 am

Dara Navaei

DEN-5873 addressed code review comments and continued with dev testing

Options
    • -19
    • +20
    /firmware/App/Controllers/UVReactors.c
    • -1
    • +1
    /firmware/App/Modes/ModeInitPOST.c
    • -8
    • +4
    /firmware/App/Services/SystemComm.c
    • -53
    • +22
    /firmware/App/Services/SystemCommMessages.c
    • -6
    • +3
    /firmware/App/Services/SystemCommMessages.h
    • -1
    • +1
    /firmware/source/sys_main.c
Tuesday 01 Dec 2020
2:30 pm

Dara Navaei

DEN-3421 addressed code review comments

Options
    • -12
    • +4
    /firmware/App/Controllers/TemperatureSensors.c
    • -1
    • +1
    /firmware/App/Controllers/UVReactors.c
    • -1
    • +1
    /firmware/App/Controllers/UVReactors.h
    • -1
    • +1
    /firmware/App/Tasks/TaskGeneral.c
12:57 pm

Dara Navaei

DEN-5846 addressed code review comments and continued with dev testing

Options
    • -16
    • +26
    /firmware/App/Controllers/Fans.c
10:56 am

Dara Navaei

DEN-5846 addressed code review comments

Options
    • -1
    • +1
    /firmware/App/Services/FPGA.c
10:38 am

Dara Navaei

DEN-5846 ran VectorCAST

Options
    • -19
    • +1
    /firmware/App/Controllers/Heaters.c
    • -0
    • +1
    /firmware/App/Controllers/Thermistors.c
    • -0
    • +8
    /firmware/App/Services/SystemComm.c
    • -0
    • +3
    /firmware/App/Services/SystemCommMessages.h
Monday 30 Nov 2020
10:02 pm

Dara Navaei

DEN-5846 ran vectorCAST and addressed code review comments

Options
    • -69
    • +60
    /firmware/App/Controllers/Fans.c
    • -4
    • +4
    /firmware/App/Controllers/Fans.h
    • -88
    • +166
    /firmware/App/Controllers/TemperatureSensors.c
    • -46
    • +44
    /firmware/App/Controllers/Thermistors.c
    • -2
    • +1
    /firmware/App/Controllers/Thermistors.h
    • -2
    • +2
    /firmware/App/Drivers/InternalADC.c
    • -0
    • +16
    /firmware/App/Modes/ModeInitPOST.c
    • -0
    • +48
    /firmware/App/Services/FPGA.c
    • -0
    • +6
    /firmware/App/Services/FPGA.h
    • -4
    • +0
    /firmware/App/Services/SystemComm.c
    • -3
    • +2
    /firmware/App/Services/SystemCommMessages.c
    • -7
    • +7
    /firmware/App/Services/SystemCommMessages.h
    • -2
    • +2
    /firmware/source/sys_main.c
Saturday 28 Nov 2020
5:26 pm

Dara Navaei

DEN-5873 initial commit of the unit test and integration test of the UV reactors

Options
    • -20
    • +33
    /firmware/App/Controllers/UVReactors.c
    • -0
    • +2
    /firmware/App/Modes/ModeInitPOST.c
    • -0
    • +2
    /firmware/source/sys_main.c