Clone Tools
  • last updated a few seconds ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Merge branch 'DEN-13460-dg_hd_dev-hd_dg_dvt-update-part-2' into develop

  1. … 5 more files in changeset.
Merge branch 'DEN-13786-hd_dg_dev-s78_bb' into develop

DEN-13786 DEN-13573 Correct MIN_INLET_TEMPERATURE_C value and minor logic bug. DEN-13786 DEN-13582 Delta temperature calculation requires fabs.

  1. … 1 more file in changeset.
Line 1902 is the same check but reverses the order.

Line 1902 is the same check but reverses the order.

This code is un-commented.

This code is un-commented.

Done.

Done.

In in DEN-13834.

In in DEN-13834.

Done.

Done.

Added TODO to un-comment this line of code.

Added TODO to un-comment this line of code.

"FAPI_CHECK_FSM_READY_BUSY" is a macro.

"FAPI_CHECK_FSM_READY_BUSY" is a macro.

Done.

Done.

DEN-13460 updated the heaters driver. Moved the heaters data broadcast structure to the fwcommon so the HD can use it too. Updated the temperature sensors FPGA persistent alarm

  1. … 3 more files in changeset.
Done.

Done.

Align on "*" maybe?

Align on "*" maybe?

What is the value of SEMAPHORE_IN_USE_TIMEOUT_MS? The timeout appears to only be check when getSemaphore is called. Seems like you could acquire the semaphore and the process that acquired the sema...

What is the value of SEMAPHORE_IN_USE_TIMEOUT_MS? The timeout appears to only be check when getSemaphore is called. Seems like you could acquire the semaphore and the process that acquired the semaphore could hold onto it for a time much longer than SEMAPHORE_IN_USE_TIMEOUT.

Should this function handle invalid hex characters?

Should this function handle invalid hex characters?

Set "status" to FALSE.

Set "status" to FALSE.

Should this be removed?

Should this be removed?

Should variables in if be reversed?

Should variables in if be reversed?

Should this be in or not?

Should this be in or not?

Some values have "U"?

Some values have "U"?

Are we moving away from initializing via definition?

Are we moving away from initializing via definition?

Merged DEN-13460

  1. … 6 more files in changeset.
DEN-13460 updated the trimmer heater's duty cycle cap control

  1. … 4 more files in changeset.
Remove comment.

Remove comment.

When will it be uncommented?

When will it be uncommented?

U64 implies Unsigned, but this is signed.

U64 implies Unsigned, but this is signed.

Remove todo in comment if it is resolved.

Remove todo in comment if it is resolved.

No comment to explain why it is all commented.

No comment to explain why it is all commented.

DEN-13460 merged staging

  1. … 9 more files in changeset.