dgfirmware / firmware / App / Controllers

ROPump.c

Clone Tools

Stats

Commits this week: 0
Total Committers: 10
Last Commit: 19 Nov
Commits this week: 0

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Tuesday 06 Sep 2022
10:32 am

Dara Navaei

DEN-13834 updated the heaters duty cycle record step. Tested the RO pump duty cycle feedback

Options
    • -1
    • +1
    ./ROPump.c
  2. … 2 more files in changeset.
Monday 05 Sep 2022
2:43 pm

Dara Navaei

DEN-13834 removed and addressed some of the TODOs in the code base and renamed the heaters' voltage enums for better clarification. Updated the DG RO volume generated calculations

Options
    • -4
    • +6
    ./ROPump.c
  2. … 19 more files in changeset.
Thursday 01 Sep 2022
9:35 am

Dara Navaei

Merge branch 'DEN-13460-dg_hd_dev-hd_dg_dvt-update-part-2' into develop

Options
    • -1
    • +1
    ./ROPump.c
  2. … 5 more files in changeset.
Wednesday 31 Aug 2022
4:22 pm

wbracken  (deleted user)

Line 1902 is the same check but reverses the order.

Line 1902 is the same check but reverses the order.

2:42 pm

Dara Navaei

This code is un-commented.

This code is un-commented.

2:41 pm

Dara Navaei

Done.

Done.

2:39 pm

Dara Navaei

In in DEN-13834.

In in DEN-13834.

2:38 pm

Dara Navaei

Done.

Done.

2:37 pm

Dara Navaei

Added TODO to un-comment this line of code.

Added TODO to un-comment this line of code.

2:35 pm

Dara Navaei

"FAPI_CHECK_FSM_READY_BUSY" is a macro.

"FAPI_CHECK_FSM_READY_BUSY" is a macro.

2:33 pm

Dara Navaei

Done.

Done.

9:27 am

Dara Navaei

DEN-13460 updated the heaters driver. Moved the heaters data broadcast structure to the fwcommon so the HD can use it too. Updated the temperature sensors FPGA persistent alarm

Options
    • -1
    • +1
    ./ROPump.c
  2. … 3 more files in changeset.
Tuesday 30 Aug 2022
6:04 pm

Dara Navaei

Done.

Done.

Monday 29 Aug 2022
4:38 pm

wbracken  (deleted user)

What is the value of SEMAPHORE_IN_USE_TIMEOUT_MS? The timeout appears to only be check when getSemaphore is called. Seems like you could acquire the semaphore and the process that acquired the sema...

What is the value of SEMAPHORE_IN_USE_TIMEOUT_MS? The timeout appears to only be check when getSemaphore is called. Seems like you could acquire the semaphore and the process that acquired the semaphore could hold onto it for a time much longer than SEMAPHORE_IN_USE_TIMEOUT.

4:31 pm

wbracken  (deleted user)

Should this function handle invalid hex characters?

Should this function handle invalid hex characters?

3:57 pm

wbracken  (deleted user)

Set "status" to FALSE.

Set "status" to FALSE.

3:51 pm

wbracken  (deleted user)

Should this be removed?

Should this be removed?

3:47 pm

wbracken  (deleted user)

Should variables in if be reversed?

Should variables in if be reversed?

3:42 pm

wbracken  (deleted user)

Should this be in or not?

Should this be in or not?

2:56 pm

wbracken  (deleted user)

Some values have "U"?

Some values have "U"?

2:49 pm

wbracken  (deleted user)

Are we moving away from initializing via definition?

Are we moving away from initializing via definition?

9:57 am

Dara Navaei

Merged DEN-13460

Options
    • -46
    • +47
    ./ROPump.c
  2. … 6 more files in changeset.
Sunday 28 Aug 2022
6:49 pm

Dara Navaei

DEN-13460 updated the FPGA persistent alarm functions

Options
    • -25
    • +24
    ./ROPump.c
  2. … 4 more files in changeset.
2:32 pm

Dara Navaei

DEN-13460 updated the trimmer heater's duty cycle cap control

Options
    • -16
    • +18
    ./ROPump.c
  2. … 4 more files in changeset.
Friday 26 Aug 2022
4:07 pm

wbracken  (deleted user)

Remove comment.

Remove comment.

1:40 pm

Darren Cox

When will it be uncommented?

When will it be uncommented?

1:38 pm

Darren Cox

U64 implies Unsigned, but this is signed.

U64 implies Unsigned, but this is signed.

12:24 pm

Darren Cox

Remove todo in comment if it is resolved.

Remove todo in comment if it is resolved.

12:18 pm

Darren Cox

No comment to explain why it is all commented.

No comment to explain why it is all commented.

9:17 am

Dara Navaei

DEN-13460 merged staging

Options
    • -1
    • +1
    ./ROPump.c
  2. … 9 more files in changeset.