dgfirmware / firmware

App

Clone Tools

Stats

Commits this week: 7
Total Committers: 17
Last Commit: 10 Jun
Commits this week: 7

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Friday 17 Mar 2023
2:11 pm

Michael Garthwaite

DEN-14689: sync'd out of message naming

Options
    • -1
    • +1
    ./Services/SystemComm.c
8:56 am

jtaylor  (deleted user)

I would suggest a more consistent naming for the enum items. "DISINFECT_USAGE_" rather than USAGE_INFO_ in the enum elements, and eliminating the "_DIS". This would be more specific since "USAGE" a...

I would suggest a more consistent naming for the enum items. "DISINFECT_USAGE_" rather than USAGE_INFO_ in the enum elements, and eliminating the "_DIS".
This would be more specific since "USAGE" and "INFO" are redundant, and "DIS" can be confused with "dis-", the Latin prefix.

Thursday 16 Mar 2023
10:08 pm

wbracken  (deleted user)

Comment alignment.

Comment alignment.

8:33 pm

Dara Navaei

DEN-14763 updated the heat disinfect active cool per the requirements

Options
    • -24
    • +38
    ./Modes/ModeHeatDisinfectActiveCool.c
2:04 pm

Dara Navaei

Bamboo Commit: Updated DGCommon.h with build versions from Bamboo

Options
    • -1
    • +1
    ./DGCommon.h
2:01 pm

Michael Garthwaite

Merge branch 'DIAL-243-integrated-volume-is-not-working' into develop

Options
    • -1
    • +1
    ./Modes/ModeFill.c
    • -1
    • +1
    ./Services/SystemCommMessages.c
2:00 pm

Michael Garthwaite

DIAL-243: Fixed header.

Options
    • -1
    • +1
    ./Modes/ModeFill.h
1:57 pm

Michael Garthwaite

DIAL-243: fixed integrated volume data type from u32 to f32

Options
    • -1
    • +1
    ./Modes/ModeFill.c
    • -1
    • +1
    ./Services/SystemCommMessages.c
12:12 pm

wbracken  (deleted user)

RESOLVED IN CODE WALKTHROUGH

RESOLVED IN CODE WALKTHROUGH

12:11 pm

wbracken  (deleted user)

RESOLVED IN CODE WALKTHROUGH

RESOLVED IN CODE WALKTHROUGH

12:10 pm

wbracken  (deleted user)

RESOLVED IN CODE WALKTHROUGH

RESOLVED IN CODE WALKTHROUGH

12:08 pm

wbracken  (deleted user)

RESOLVED IN CODE WALKTHROUGH

RESOLVED IN CODE WALKTHROUGH

12:07 pm

wbracken  (deleted user)

RESOLVED IN CODE WALKTHROUGH

RESOLVED IN CODE WALKTHROUGH

12:07 pm

wbracken  (deleted user)

RESOLVED IN CODE WALKTHROUGH

RESOLVED IN CODE WALKTHROUGH

12:07 pm

wbracken  (deleted user)

RESOLVED IN CODE WALKTHROUGH

RESOLVED IN CODE WALKTHROUGH

12:06 pm

wbracken  (deleted user)

RESOLVED IN CODE WALKTHROUGH

RESOLVED IN CODE WALKTHROUGH

11:37 am

wbracken  (deleted user)

RESOLVED IN CODE WALKTHROUGH

RESOLVED IN CODE WALKTHROUGH

11:22 am

wbracken  (deleted user)

RESOLVED IN CODE WALKTHROUGH

RESOLVED IN CODE WALKTHROUGH

11:21 am

wbracken  (deleted user)

RESOLVED IN CODE WALKTHROUGH

RESOLVED IN CODE WALKTHROUGH

11:20 am

wbracken  (deleted user)

RESOLVED IN CODE WALKTHROUGH

RESOLVED IN CODE WALKTHROUGH

9:44 am

jtaylor  (deleted user)

RESOLVED IN CODE WALKTHROUGH.

RESOLVED IN CODE WALKTHROUGH.

9:38 am

Dara Navaei

Bamboo Commit: Updated DGCommon.h with build versions from Bamboo

Options
    • -1
    • +1
    ./DGCommon.h
9:34 am

Michael Garthwaite

Merge branch 'DIAL-222-sys-request' into develop

Options
    • -0
    • +5
    ./Controllers/Heaters.c
9:33 am

Michael Garthwaite

DIAL-222: fixed heaters override reset.

Options
    • -0
    • +5
    ./Controllers/Heaters.c
9:10 am

jtaylor  (deleted user)

RESOLVED IN CODE WALKTHROUGH.

RESOLVED IN CODE WALKTHROUGH.

Wednesday 15 Mar 2023
5:19 pm

Dara Navaei

DEN-14763 addressed the code review comments and added inlet water conditions to the heat disinfect active cool

Options
    • -0
    • +1
    ./Controllers/ConductivitySensors.c
    • -0
    • +1
    ./Controllers/Pressures.c
    • -1
    • +5
    ./Controllers/ROPump.c
    • -0
    • +1
    ./Controllers/TemperatureSensors.c
    • -1
    • +1
    ./Modes/ModeHeatDisinfect.c
    • -43
    • +210
    ./Modes/ModeHeatDisinfectActiveCool.c
    • -4
    • +2
    ./Modes/ModeStandby.c
    • -1
    • +1
    ./Modes/OperationModes.c
5:18 pm

Dara Navaei

Revised the comment.

Revised the comment.

5:17 pm

Dara Navaei

Done.

Done.

5:08 pm

Dara Navaei

tempBelowTargetStartTimeMS is not longer set in this state.

tempBelowTargetStartTimeMS is not longer set in this state.

5:07 pm

Dara Navaei

Done.

Done.