dgfirmware / firmware

App

Clone Tools

Stats

Commits this week: 0
Total Committers: 17
Last Commit: 19 Nov
Commits this week: 0

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Tuesday 17 Nov 2020
10:39 am

Quang Nguyen <qnguyen@diality.com>

DEN-3504: Addressed code review

Options
    • -1
    • +1
    ./Services/SystemComm.c
    • -1
    • +1
    ./Services/SystemCommMessages.c
    • -1
    • +1
    ./Services/SystemCommMessages.h
Monday 16 Nov 2020
10:25 pm

Dara Navaei

DEN-3421 continued adding more details to the drivers and addressed code review comments

Options
    • -182
    • +188
    ./Controllers/DrainPump.c
    • -5
    • +6
    ./Controllers/DrainPump.h
    • -2
    • +2
    ./Controllers/Fans.c
    • -152
    • +158
    ./Controllers/ROPump.c
    • -8
    • +12
    ./Controllers/ROPump.h
    • -2
    • +2
    ./Modes/ModeDrain.c
    • -2
    • +2
    ./Modes/ModeHeatDisinfect.c
    • -0
    • +1
    ./Services/AlarmMgmt.h
    • -0
    • +13
    ./Services/SystemComm.c
    • -35
    • +100
    ./Services/SystemCommMessages.c
    • -3
    • +9
    ./Services/SystemCommMessages.h
2:13 pm

Quang Nguyen <qnguyen@diality.com>

DEN-3504: Refactor control pump separately and add reverse motor dir

Options
    • -84
    • +136
    ./Controllers/ConcentratePumps.c
    • -2
    • +2
    ./Controllers/ConcentratePumps.h
    • -2
    • +4
    ./Modes/ModeFill.c
    • -1
    • +2
    ./Modes/ModeRecirculate.c
    • -1
    • +2
    ./Modes/ModeStandby.c
    • -6
    • +6
    ./Services/SystemCommMessages.c
  7. … 3 more files in changeset.
Sunday 15 Nov 2020
5:59 pm

Dara Navaei

DEN-3421 addressed code review comments and reviewed all the doxygen texts in RO pump

Options
    • -16
    • +12
    ./Controllers/Fans.c
    • -2
    • +0
    ./Controllers/Fans.h
    • -298
    • +377
    ./Controllers/ROPump.c
    • -5
    • +8
    ./Controllers/ROPump.h
    • -10
    • +10
    ./Controllers/Thermistors.c
    • -2
    • +2
    ./Controllers/Thermistors.h
    • -71
    • +64
    ./Controllers/UVReactors.c
    • -1
    • +1
    ./Controllers/UVReactors.h
    • -1
    • +1
    ./DGCommon.h
    • -2
    • +7
    ./Modes/ModeHeatDisinfect.c
    • -0
    • +10
    ./Modes/ModeHeatDisinfect.h
    • -1
    • +2
    ./Services/AlarmMgmt.h
    • -2
    • +12
    ./Services/FPGA.c
    • -1
    • +1
    ./Services/FPGA.h
    • -1
    • +18
    ./Services/SystemComm.c
  16. … 3 more files in changeset.
Friday 13 Nov 2020
3:36 pm

Quang Nguyen <qnguyen@diality.com>

DEN-3504: Prevent division by zero when pumps on with zero flow rate

Options
    • -16
    • +18
    ./Controllers/ConcentratePumps.c
11:13 am

Quang Nguyen <qnguyen@diality.com>

DEN-3504: Turn concentrate pumps during mode transition

Options
    • -1
    • +3
    ./Modes/ModeRecirculate.c
    • -1
    • +2
    ./Modes/ModeStandby.c
    • -3
    • +1
    ./Services/Reservoirs.c
10:45 am

Quang Nguyen <qnguyen@diality.com>

DEN-3504: Removed operation mode clean up and refactor concentrate pumps

Options
    • -8
    • +29
    ./Controllers/ConcentratePumps.c
    • -13
    • +0
    ./Modes/ModeFill.c
    • -24
    • +0
    ./Modes/OperationModes.c
    • -1
    • +3
    ./Services/Reservoirs.c
    • -3
    • +5
    ./Tasks/TaskGeneral.c
9:37 am

Dara Navaei

DEN-3421 addressed code review comments

Options
    • -5
    • +5
    ./Controllers/Fans.c
    • -1
    • +1
    ./Controllers/Thermistors.c
    • -26
    • +48
    ./Controllers/UVReactors.c
    • -6
    • +6
    ./Controllers/UVReactors.h
    • -2
    • +2
    ./Drivers/InternalADC.c
    • -3
    • +4
    ./Services/AlarmMgmt.h
    • -19
    • +38
    ./Services/PIControllers.c
    • -2
    • +2
    ./Services/PIControllers.h
    • -2
    • +5
    ./Services/SystemComm.c
    • -13
    • +50
    ./Services/SystemCommMessages.c
    • -2
    • +5
    ./Services/SystemCommMessages.h
Thursday 12 Nov 2020
8:59 am

Quang Nguyen <qnguyen@diality.com>

DEN-3504: Added fill dialysate time out and concentrate pump speed check

Options
    • -5
    • +98
    ./Controllers/ConcentratePumps.c
    • -0
    • +2
    ./Controllers/ConcentratePumps.h
    • -9
    • +32
    ./Modes/ModeFill.c
    • -0
    • +1
    ./Modes/ModeFill.h
    • -0
    • +24
    ./Modes/OperationModes.c
    • -0
    • +4
    ./Services/SystemComm.c
    • -0
    • +32
    ./Services/SystemCommMessages.c
    • -0
    • +3
    ./Services/SystemCommMessages.h
Wednesday 11 Nov 2020
9:56 pm

Dara Navaei

DEN-3421 addressed code review comments

Options
    • -54
    • +77
    ./Controllers/DrainPump.c
    • -3
    • +13
    ./Controllers/DrainPump.h
    • -60
    • +154
    ./Controllers/Fans.c
    • -62
    • +66
    ./Controllers/ROPump.c
    • -1
    • +1
    ./Controllers/ROPump.h
    • -59
    • +160
    ./Controllers/Thermistors.c
    • -8
    • +12
    ./Controllers/Thermistors.h
    • -1
    • +2
    ./Controllers/UVReactors.h
    • -2
    • +2
    ./Drivers/InternalADC.c
    • -1
    • +3
    ./Drivers/InternalADC.h
    • -0
    • +3
    ./Services/AlarmMgmt.h
    • -6
    • +6
    ./Services/FPGA.c
    • -6
    • +6
    ./Services/FPGA.h
    • -9
    • +0
    ./Services/MessagePayloads.h
    • -15
    • +7
    ./Services/SystemCommMessages.c
    • -2
    • +3
    ./Services/SystemCommMessages.h
Tuesday 10 Nov 2020
2:17 pm

Quang Nguyen <qnguyen@diality.com>

DEN-3504: Addressed code review

Options
    • -38
    • +6
    ./Controllers/ConcentratePumps.c
    • -0
    • +1
    ./Controllers/ConductivitySensors.c
11:05 am

Quang Nguyen <qnguyen@diality.com>

DEN-3504: Addressed code reviews

Options
    • -86
    • +57
    ./Controllers/ConcentratePumps.c
    • -3
    • +2
    ./Controllers/ConcentratePumps.h
    • -43
    • +9
    ./Controllers/ConductivitySensors.c
    • -0
    • +2
    ./Controllers/ConductivitySensors.h
    • -1
    • +1
    ./Modes/ModeDrain.c
    • -3
    • +3
    ./Modes/ModeFill.c
    • -18
    • +18
    ./Services/Reservoirs.c
    • -2
    • +2
    ./Services/Reservoirs.h
    • -10
    • +3
    ./Services/SystemCommMessages.c
Monday 09 Nov 2020
11:57 am

Quang Nguyen <qnguyen@diality.com>

DEN-3504: Added probe type for cpi and check empty emstat read size

Options
    • -3
    • +6
    ./Controllers/ConductivitySensors.c
    • -1
    • +16
    ./Services/FPGA.c
    • -0
    • +1
    ./Services/FPGA.h
    • -4
    • +0
    ./Services/SystemComm.c
    • -29
    • +0
    ./Services/SystemCommMessages.c
    • -3
    • +0
    ./Services/SystemCommMessages.h
  7. … 3 more files in changeset.
Saturday 07 Nov 2020
9:44 pm

Dara Navaei

DEN-3421 worked on various drivers

Options
    • -28
    • +88
    ./Controllers/Fans.c
    • -0
    • +8
    ./Controllers/ROPump.c
    • -59
    • +196
    ./Controllers/Thermistors.c
    • -3
    • +8
    ./Controllers/Thermistors.h
    • -1
    • +1
    ./Controllers/UVReactors.c
    • -1
    • +1
    ./Modes/ModeHeatDisinfect.c
    • -7
    • +129
    ./Services/FPGA.c
    • -2
    • +13
    ./Services/FPGA.h
    • -0
    • +32
    ./Services/SystemCommMessages.c
    • -0
    • +3
    ./Services/SystemCommMessages.h
    • -15
    • +32
    ./Tasks/TaskGeneral.c
  12. … 3 more files in changeset.
Friday 06 Nov 2020
9:48 am

Quang Nguyen <qnguyen@diality.com>

DEN-3504: Fixed style issue

Options
    • -4
    • +4
    ./Controllers/ConductivitySensors.c
Thursday 05 Nov 2020
9:30 pm

Dara Navaei

DEN-3421 tested heat disinfection's big loop with heating up water

Options
    • -16
    • +14
    ./Controllers/DrainPump.c
    • -47
    • +65
    ./Controllers/ROPump.c
    • -5
    • +6
    ./Controllers/ROPump.h
    • -51
    • +54
    ./Modes/ModeHeatDisinfect.c
    • -1
    • +1
    ./Modes/ModeRecirculate.c
    • -1
    • +1
    ./Services/PIControllers.c
Wednesday 04 Nov 2020
11:36 am

Quang Nguyen <qnguyen@diality.com>

DEN-3504: Fixed compile issues and updated persistent alarm tests

Options
    • -0
    • +2
    ./Controllers/ConductivitySensors.c
    • -2
    • +5
    ./Controllers/TemperatureSensors.c
    • -1
    • +1
    ./Modes/ModeFill.c
    • -1
    • +1
    ./Services/SystemCommMessages.c
Monday 02 Nov 2020
6:15 pm

Dara Navaei

DEN-3421 worked on the Fans module

Options
    • -16
    • +383
    ./Controllers/Fans.c
    • -17
    • +32
    ./Controllers/Fans.h
    • -11
    • +11
    ./Controllers/ROPump.c
    • -7
    • +6
    ./Controllers/Thermistors.c
    • -1
    • +1
    ./Modes/ModeHeatDisinfect.c
    • -1
    • +1
    ./Modes/ModeStandby.c
    • -0
    • +3
    ./Services/AlarmMgmt.h
    • -0
    • +26
    ./Services/FPGA.c
    • -0
    • +3
    ./Services/FPGA.h
    • -7
    • +33
    ./Services/SystemCommMessages.c
    • -3
    • +7
    ./Services/SystemCommMessages.h
  12. … 1 more file in changeset.
5:55 pm

Quang Nguyen <qnguyen@diality.com>

DEN-3504: Added missing function header

Options
    • -0
    • +1
    ./Controllers/ConcentratePumps.c
    • -1
    • +16
    ./Modes/ModeFill.c
11:41 am

Quang Nguyen <qnguyen@diality.com>

DEN-3504: Fixed UT for system comm messages

Options
    • -0
    • +1
    ./Services/SystemCommMessages.c
  2. … 2 more files in changeset.
10:43 am

Quang Nguyen <qnguyen@diality.com>

DEN-3504: Addressed code reviews

Options
    • -0
    • +1
    ./DGCommon.h
    • -1
    • +1
    ./Modes/ModeDrain.c
10:28 am

Quang Nguyen <qnguyen@diality.com>

DEN-3504: Addressed code reviews

Options
    • -1
    • +18
    ./Controllers/ConcentratePumps.c
    • -6
    • +23
    ./Controllers/ConductivitySensors.c
    • -19
    • +4
    ./Services/SystemCommMessages.c
    • -2
    • +2
    ./Services/SystemCommMessages.h
Friday 30 Oct 2020
2:57 pm

Quang Nguyen <qnguyen@diality.com>

DEN-3504: Addressed code review

Options
    • -1
    • +1
    ./Controllers/ConductivitySensors.c
2:55 pm

Quang Nguyen <qnguyen@diality.com>

DEN-3504: Addressed code reviews

Options
    • -6
    • +6
    ./Controllers/ConductivitySensors.c
    • -1
    • +1
    ./Modes/ModeDrain.c
Thursday 29 Oct 2020
4:46 pm

Quang Nguyen <qnguyen@diality.com>

DEN-3504: Added concentrate pump publish data override functions

Options
    • -2
    • +72
    ./Controllers/ConcentratePumps.c
    • -0
    • +2
    ./Controllers/ConcentratePumps.h
    • -0
    • +4
    ./Services/SystemComm.c
    • -0
    • +32
    ./Services/SystemCommMessages.c
    • -0
    • +3
    ./Services/SystemCommMessages.h
Wednesday 28 Oct 2020
9:17 pm

Dara Navaei

DEN-3421 made modification to the UVReactors module and started the thermistors driver

Options
    • -1
    • +0
    ./Controllers/Fans.h
    • -4
    • +2
    ./Controllers/TemperatureSensors.c
    • -0
    • +365
    ./Controllers/Thermistors.c
    • -0
    • +57
    ./Controllers/Thermistors.h
    • -5
    • +27
    ./Controllers/UVReactors.c
    • -2
    • +2
    ./Controllers/UVReactors.h
    • -0
    • +3
    ./Services/AlarmMgmt.h
    • -0
    • +28
    ./Services/SystemCommMessages.c
    • -2
    • +6
    ./Services/SystemCommMessages.h
Monday 26 Oct 2020
9:37 am

Dara Navaei

DEN-3421 fixed a doxygen header function

Options
    • -2
    • +2
    ./Modes/ModeStandby.c
9:24 am

Dara Navaei

DEN-3421 addressed the code reivew comments

Options
    • -2
    • +0
    ./Controllers/DrainPump.c
    • -3
    • +0
    ./DGCommon.h
    • -6
    • +12
    ./Modes/ModeStandby.c
9:02 am

Dara Navaei

DEN-3421 addressed code review comments and worked on UV reactors driver

Options
    • -0
    • +1
    ./Controllers/DrainPump.c
    • -6
    • +6
    ./Controllers/ROPump.c
    • -2
    • +0
    ./Controllers/ROPump.h
    • -1
    • +1
    ./Controllers/TemperatureSensors.c
    • -38
    • +371
    ./Controllers/UVReactors.c
    • -8
    • +9
    ./Controllers/UVReactors.h
    • -1
    • +1
    ./Drivers/SafetyShutdown.c
    • -8
    • +1
    ./Modes/ModeHeatDisinfect.c
    • -0
    • +1
    ./Services/AlarmMgmt.h
    • -0
    • +8
    ./Services/SystemComm.c
    • -0
    • +63
    ./Services/SystemCommMessages.c
    • -0
    • +6
    ./Services/SystemCommMessages.h
Thursday 22 Oct 2020
5:38 pm

Dara Navaei

DEN-3421 addressed code review comments and added GIO ports for UV reactors

Options
    • -10
    • +19
    ./Controllers/DrainPump.c
    • -3
    • +3
    ./Controllers/DrainPump.h
    • -11
    • +16
    ./Controllers/ROPump.c
    • -1
    • +13
    ./Controllers/ROPump.h
    • -23
    • +174
    ./Controllers/UVReactors.c
    • -7
    • +25
    ./Controllers/UVReactors.h
    • -3
    • +3
    ./DGCommon.h
    • -28
    • +12
    ./Modes/ModeHeatDisinfect.c
    • -1
    • +0
    ./Modes/ModeHeatDisinfect.h
    • -0
    • +16
    ./Modes/ModeStandby.c
    • -0
    • +2
    ./Modes/ModeStandby.h
    • -0
    • +1
    ./Services/AlarmMgmt.h
    • -10
    • +0
    ./Services/MessagePayloads.h
    • -12
    • +32
    ./Services/SystemCommMessages.c
    • -3
    • +8
    ./Services/SystemCommMessages.h
  16. … 7 more files in changeset.