dialin

Clone Tools

Stats

Commits this week: 0
Total Committers: 21
Last Commit: 19 Nov 25
Commits this week: 0

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Wednesday 23 Feb 2022
11:38 am

Dara Navaei

Merge branch 'DEN-11750-dg_dev-dg-dialysate-temperature-control-tune-up' into develop

Options
    • -1
    • +1
    /dialin/dg/ro_pump.py
11:38 am

Dara Navaei

DEN-11750 updated the code

Options
    • -2
    • +2
    /tests/hd_nvm_scripts.py
11:27 am

Dara Navaei

DEN-11750 addressed the code review comments

Options
    • -4
    • +4
    /dialin/dg/alarms.py
    • -5
    • +8
    /dialin/dg/calibration_record.py
    • -1
    • +1
    /dialin/dg/ro_pump.py
    • -4
    • +6
    /dialin/dg/sw_config.py
    • -19
    • +19
    /dialin/dg/temperatures.py
    • -7
    • +10
    /dialin/hd/calibration_record.py
    • -4
    • +6
    /dialin/hd/sw_config.py
    • -1
    • +1
    /dialin/utils/nv_ops_utils.py
    • -39
    • +0
    /tests/hd_blood_leak_data.py
    • -24
    • +1
    /tests/test_hd_dg_fans.py
11:24 am

Dara Navaei

I made it like HD.

I made it like HD.

11:18 am

Dara Navaei

Done.

Done.

11:17 am

Dara Navaei

Agreed. I will clean them up gradually. Removed the commented code.

Agreed. I will clean them up gradually. Removed the commented code.

11:15 am

Dara Navaei

Done.

Done.

11:13 am

Dara Navaei

This class is used to wait for the results to be received from firmware. I fixed the order.

This class is used to wait for the results to be received from firmware. I fixed the order.

11:13 am

Dara Navaei

Done.

Done.

10:57 am

Michael Garthwaite

Please see comment in hd_blood_leak_data.py.

Please see comment in hd_blood_leak_data.py.

10:56 am

Michael Garthwaite

For files in the peter folder I understand. However, with the repo scripts in this folder are typically shared with cross-functional teams and are "forward facing."

For files in the peter folder I understand. However, with the repo scripts in this folder are typically shared with cross-functional teams and are "forward facing."

10:56 am

Michael Garthwaite

RESOLVED.

RESOLVED.

10:56 am

Michael Garthwaite

RESOLVED.

RESOLVED.

10:55 am

Michael Garthwaite

RESOLVED.

RESOLVED.

10:55 am

Michael Garthwaite

RESOLVED.

RESOLVED.

10:55 am

Michael Garthwaite

RESOLVED.

RESOLVED.

10:28 am

Dara Navaei

Fixed it.

Fixed it.

10:19 am

Dara Navaei

The software configurations and calibration excel reports are protected. They are protected because the format of the reports do not have to change the scripts rely on them to read the data back an...

The software configurations and calibration excel reports are protected. They are protected because the format of the reports do not have to change the scripts rely on them to read the data back and send them to the firmware. The only cells that are not protected are the cells that the users can changed the values (i.e. the calibration values). This feature is optional a report can be created that is not protected.

10:17 am

Dara Navaei

This script is in the tests folder. The tests folder is not controlled in the way the Dialin files are controlled so I might go back and forth in between different tests. This is not affecting any ...

This script is in the tests folder. The tests folder is not controlled in the way the Dialin files are controlled so I might go back and forth in between different tests. This is not affecting any of the Dialin features. Last time it was used to program the HD RTC clock.

10:16 am

Dara Navaei

This script is in the tests folder. The tests folder is not controlled in the way the Dialin files are controlled so I might go back and forth in between different tests. This is not affecting any ...

This script is in the tests folder. The tests folder is not controlled in the way the Dialin files are controlled so I might go back and forth in between different tests. This is not affecting any of the Dialin features.

10:16 am

Dara Navaei

This script is in the tests folder. The tests folder is not controlled in the way the Dialin files are controlled so I might go back and forth in between different tests. This is not affecting any ...

This script is in the tests folder. The tests folder is not controlled in the way the Dialin files are controlled so I might go back and forth in between different tests. This is not affecting any of the Dialin features.

10:16 am

Dara Navaei

This script is in the tests folder. The tests folder is not controlled in the way the Dialin files are controlled so I might go back and forth in between different tests. This is not affecting any ...

This script is in the tests folder. The tests folder is not controlled in the way the Dialin files are controlled so I might go back and forth in between different tests. This is not affecting any of the Dialin features.

10:15 am

Dara Navaei

This script is in the tests folder. The tests folder is not controlled in the way the Dialin files are controlled so I might go back and forth in between different tests. This is not affecting any ...

This script is in the tests folder. The tests folder is not controlled in the way the Dialin files are controlled so I might go back and forth in between different tests. This is not affecting any of the Dialin features.

Tuesday 22 Feb 2022
4:49 pm

Michael Garthwaite

Please remove comments if they are no longer applicable to the test.

Please remove comments if they are no longer applicable to the test.

4:47 pm

Michael Garthwaite

Please remove comments if they are no longer applicable to the test.

Please remove comments if they are no longer applicable to the test.

4:46 pm

Michael Garthwaite

Please remove comments if they are no longer applicable to the test.

Please remove comments if they are no longer applicable to the test.

4:45 pm

Michael Garthwaite

Please remove comments if they are no longer applicable to the test.

Please remove comments if they are no longer applicable to the test.

4:44 pm

Michael Garthwaite

Why is this test commented out but not the HD?

Why is this test commented out but not the HD?

4:42 pm

Michael Garthwaite

Who and/or what are we trying to write protect against?

Who and/or what are we trying to write protect against?

4:39 pm

Michael Garthwaite

Shouldn't the dictionary format for HD/DG sensors be the same? Do we need dictionaries within the dictionary?

Shouldn't the dictionary format for HD/DG sensors be the same? Do we need dictionaries within the dictionary?