dialin / dialin / ui

hd_proxy.py

Clone Tools

Stats

Commits this week: 0
Total Committers: 2
Last Commit: 19 Nov
Commits this week: 0

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few minutes ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Friday 16 Oct 2020
2:42 pm

plucia  (deleted user)

2:41 pm

qnguyen  (deleted user) and Sean Nash

Wednesday 14 Oct 2020
5:26 pm

qnguyen  (deleted user)

RESOLVED.

RESOLVED.

4:22 pm

qnguyen  (deleted user)

RESOLVED.

RESOLVED.

4:22 pm

qnguyen  (deleted user)

RESOLVED.

RESOLVED.

4:07 pm

plucia  (deleted user)

The version of crucible we're using has an issue where duplicate files show in the file viewer on the left. If you look at the more recent hemodialysis_device.py file (see the files viewer on the ...

The version of crucible we're using has an issue where duplicate files show in the file viewer on the left.

If you look at the more recent hemodialysis_device.py file (see the files viewer on the left), this message id is removed: http://dvm-linux02:8060/cru/DIALIN-DEN-4856-1#CFR-19219

It is also removed from both msg_defs.py: http://dvm-linux02:8060/cru/DIALIN-DEN-4856-1#CFR-19027 and http://dvm-linux02:8060/cru/DIALIN-DEN-4856-1#CFR-19203

3:57 pm

plucia  (deleted user)

Done

Done

3:57 pm

plucia  (deleted user)

Yes, if it's already there no reason to remove it. I've added it back

Yes, if it's already there no reason to remove it. I've added it back

Monday 12 Oct 2020
9:18 am

qnguyen  (deleted user)

This message id is not being used.

This message id is not being used.

9:16 am

qnguyen  (deleted user)

The file should be renamed to match this.

The file should be renamed to match this.

9:13 am

qnguyen  (deleted user)

should we keep the copyright?

should we keep the copyright?

Wednesday 07 Oct 2020
11:54 am

plucia  (deleted user)

DIALIN-DEN-4856_Sprint_27
DIALIN-DEN-4856_Sprint_27
Wednesday 26 Aug 2020
12:02 pm

plucia  (deleted user)

12:01 pm

Sean Nash and Behrouz NematiPour

11:52 am

Behrouz NematiPour

RESOLVED.

RESOLVED.

11:49 am

plucia  (deleted user)

Okay. It's "Projects" now

Okay. It's "Projects" now

11:47 am

Behrouz NematiPour

Reminded him again and he is aware of it and has plan to do so. We use "Projects" and if meanwhile anyone has a non-updated VM will update the folder name manually for now.

Reminded him again and he is aware of it and has plan to do so.
We use "Projects" and if meanwhile anyone has a non-updated VM will update the folder name manually for now.

11:29 am

Behrouz NematiPour

Yes I told him to update that. Will remind him again.

Yes I told him to update that.
Will remind him again.

11:28 am

Behrouz NematiPour

Great, RESOLVED

Great,
RESOLVED

11:28 am

Behrouz NematiPour

great, RESOLVED

great,
RESOLVED

10:44 am

plucia  (deleted user)

Have you checked with Dara on this? I think the VM's are setup with the "~/projects" directory. Systems and V&V both have v4 of those VM's already...

Have you checked with Dara on this? I think the VM's are setup with the "~/projects" directory. Systems and V&V both have v4 of those VM's already...

10:41 am

plucia  (deleted user)

I had the same thought awhile ago and begin investigating it. It may be possible - but will take some time. I previously created a Jira ticket to make sure we implement this feature in the future: ...

I had the same thought awhile ago and begin investigating it. It may be possible - but will take some time. I previously created a Jira ticket to make sure we implement this feature in the future: http://dvm-linux02:8080/browse/DIAL-23.

10:40 am

plucia  (deleted user)

I had the same thought awhile ago and begin investigating it. It may be possible - but will take some time. I previously created a Jira ticket to make sure we implement this feature in the future: ...

I had the same thought awhile ago and begin investigating it. It may be possible - but will take some time. I previously created a Jira ticket to make sure we implement this feature in the future: http://dvm-linux02:8080/browse/DIAL-23.

10:33 am

Behrouz NematiPour

Is there a way to get these values right from c code of firmware? Like a scripts which reads the c file and generates this py code.

Is there a way to get these values right from c code of firmware?
Like a scripts which reads the c file and generates this py code.

10:33 am

Behrouz NematiPour

Is there a way to get these values right from c code of firmware? Like a scripts which reads the c file and generates this py code.

Is there a way to get these values right from c code of firmware?
Like a scripts which reads the c file and generates this py code.

10:25 am

Behrouz NematiPour

It has been updated in scripts to "Projects"

It has been updated in scripts to "Projects"

Tuesday 25 Aug 2020
11:09 am

Sean Nash

RESOLVED

RESOLVED

Friday 21 Aug 2020
12:01 pm

plucia  (deleted user)

It is so during the import process, the modules in the common directory are found. It's used to mark directories as python package directories. If you remove it, then python will no longer find sub...

It is so during the import process, the modules in the common directory are found. It's used to mark directories as python package directories.
If you remove it, then python will no longer find submodules.

https://docs.python.org/3/reference/import.html#regular-packages

If we add the following to _init.py then the user doesn't have to know the exact file location of a particular class:

So in dialin.init_.py, we could add:
from hd.hemodialysis_device.py import HD

Then, a dialin script could do:

from dialin import HD

instead of

from dialin.hd.hemodialysis_device import HD


It abstracts away the file location so if we can rename files without the API user being affected.

Your comment reminded me that we weren't doing this yet and so I've added those changes to this review.

10:45 am

Sean Nash

Why is this empty?

Why is this empty?

10:14 am

plucia  (deleted user)

DIALIN-DEN-4344_Sprint 25
DIALIN-DEN-4344_Sprint 25