fwcommon

Clone Tools

Stats

Commits this week: 0
Total Committers: 13
Last Commit: 19 Nov 25
Commits this week: 0

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Tuesday 06 Sep 2022
5:55 pm

Dara Navaei

Merge branch 'DEN-13834-dg_hd_dev-hd_dg_dvt-update-part-3' into develop

Options
    • -16
    • +30
    /NVDataMgmt.c
    • -1
    • +1
    /RTC.c
4:29 pm

Dong Nguyen <dnguyen@diality.com>

DEN-13598 Updated code for RAM error checking.

Options
    • -0
    • +59
    /Integrity.c
    • -0
    • +1
    /Integrity.h
10:36 am

Dara Navaei

DEN-13834 updated the DG service record.

Options
    • -3
    • +3
    /NVDataMgmt.c
    • -1
    • +1
    /NVDataMgmtDGRecords.h
Monday 05 Sep 2022
12:38 pm

Dara Navaei

DEN-13834 updated the service record to add the last time that a record was reset. Added a new software configuration to disable the serive time and disinfects in DG. Changed the DG RTC broadcast message.

Options
    • -10
    • +26
    /NVDataMgmt.c
    • -0
    • +3
    /NVDataMgmtDGRecords.h
    • -1
    • +1
    /RTC.c
Saturday 03 Sep 2022
4:39 pm

Dara Navaei

DEN-13834 moved some of the broadcast data into the common file in the fwcommon to be shared with HD.

Options
    • -10
    • +45
    /Common.h
    • -5
    • +3
    /NVDataMgmt.c
Thursday 01 Sep 2022
9:36 am

Dara Navaei

Merge branch 'DEN-13460-dg_hd_dev-hd_dg_dvt-update-part-2' into develop

Options
    • -19
    • +6
    /NVDataMgmt.c
Wednesday 31 Aug 2022
4:22 pm

wbracken  (deleted user)

Line 1902 is the same check but reverses the order.

Line 1902 is the same check but reverses the order.

2:45 pm

Dara Navaei

DEN-13460 addressed the code review comments and changed the way the FPGA persistent alarms are initialized so the isConditionClear is set to TRUE and the persistent is not alarmed with the first cout out of range

Options
    • -17
    • +3
    /NVDataMgmt.c
    • -17
    • +15
    /PersistentAlarm.c
2:42 pm

Dara Navaei

This code is un-commented.

This code is un-commented.

2:41 pm

Dara Navaei

Done.

Done.

2:39 pm

Dara Navaei

In in DEN-13834.

In in DEN-13834.

2:38 pm

Dara Navaei

Done.

Done.

2:37 pm

Dara Navaei

Added TODO to un-comment this line of code.

Added TODO to un-comment this line of code.

2:35 pm

Dara Navaei

"FAPI_CHECK_FSM_READY_BUSY" is a macro.

"FAPI_CHECK_FSM_READY_BUSY" is a macro.

2:33 pm

Dara Navaei

Done.

Done.

Tuesday 30 Aug 2022
8:59 pm

Dara Navaei

DEN-13460 updated the software fault alarms of the FPGA persistent alarms

Options
    • -1
    • +1
    /NVDataMgmt.c
    • -0
    • +5
    /PersistentAlarm.c
8:46 pm

Dara Navaei

DEN-13460 updated the FPGA persistent alarms functions and fixed the system information CRC correction

Options
    • -1
    • +19
    /Common.h
    • -1
    • +1
    /NVDataMgmt.c
    • -70
    • +81
    /PersistentAlarm.c
    • -10
    • +10
    /PersistentAlarm.h
6:04 pm

Dara Navaei

Done.

Done.

Monday 29 Aug 2022
4:38 pm

wbracken  (deleted user)

What is the value of SEMAPHORE_IN_USE_TIMEOUT_MS? The timeout appears to only be check when getSemaphore is called. Seems like you could acquire the semaphore and the process that acquired the sema...

What is the value of SEMAPHORE_IN_USE_TIMEOUT_MS? The timeout appears to only be check when getSemaphore is called. Seems like you could acquire the semaphore and the process that acquired the semaphore could hold onto it for a time much longer than SEMAPHORE_IN_USE_TIMEOUT.

4:31 pm

wbracken  (deleted user)

Should this function handle invalid hex characters?

Should this function handle invalid hex characters?

3:57 pm

wbracken  (deleted user)

Set "status" to FALSE.

Set "status" to FALSE.

3:51 pm

wbracken  (deleted user)

Should this be removed?

Should this be removed?

3:47 pm

wbracken  (deleted user)

Should variables in if be reversed?

Should variables in if be reversed?

3:42 pm

wbracken  (deleted user)

Should this be in or not?

Should this be in or not?

2:56 pm

wbracken  (deleted user)

Some values have "U"?

Some values have "U"?

2:49 pm

wbracken  (deleted user)

Are we moving away from initializing via definition?

Are we moving away from initializing via definition?

Friday 26 Aug 2022
4:07 pm

wbracken  (deleted user)

Remove comment.

Remove comment.

1:40 pm

dcox  (deleted user)

When will it be uncommented?

When will it be uncommented?

1:38 pm

dcox  (deleted user)

U64 implies Unsigned, but this is signed.

U64 implies Unsigned, but this is signed.

12:24 pm

dcox  (deleted user)

Remove todo in comment if it is resolved.

Remove todo in comment if it is resolved.