hdfirmware

Clone Tools
  • last updated a few seconds ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
DEN-9480 addressed the code review comments

DEN-9480 addressed the code review comments

    • -24
    • +23
    /firmware/App/Controllers/Valves.c
Done.

Done.

Done.

Done.

Done.

Done.

It is not used for any decision making so it is only output.

It is not used for any decision making so it is only output.

It has to be input and output.

It has to be input and output.

Done.

Done.

Done.

Done.

Done.

Done.

Done.

Done.

This is actually an input because it is used to make a decision.

This is actually an input because it is used to make a decision.

Done.

Done.

Done.

Done.

Done.

Done.

Done.

Done.

Done.

Done.

Done.

Done.

Done.

Done.

Done.

Done.

Done.

Done.

Done.

Done.

Done.

Done.

Done.

Done.

remove postPassed

remove postPassed

Add dgPOSTResultReceived in Outputs

Add dgPOSTResultReceived in Outputs

Remove valvesPostionOverride from both Inputs and Outputs

Remove valvesPostionOverride from both Inputs and Outputs

Remove valvesStatus from Inputs

Remove valvesStatus from Inputs

Replace both Inputs and Outputs with valvesPostionOverride.

Replace both Inputs and Outputs with valvesPostionOverride.

Remove valvesPostionOverride from Inputs

Remove valvesPostionOverride from Inputs