Activity leahi-application/SDDs/Main_Treatment/FinalDiagram.dot

4:48 pm

Behrouz NematiPour

More
LEAHI-APPLICATION-LDT-1730-1
finished reviewing

4:34 pm

Thank you Stephen Quong That is a great catch. After your comment, I dug a little deeper. These two properties are actually defined as global properties/variables in this view and will get updated/...

Thank you Stephen Quong
That is a great catch.
After your comment, I dug a little deeper.
These two properties are actually defined as global properties/variables in this view and will get updated/adjusted by FW with other messages.
Although we do not use them for now, as they will change in pre-treatment and with the "Ultrafiltration Edit", we should keep them for later use.

Nicholas Ramirez
Please revert all changes to the minimum and maximum values.

I will also same comment in the following bug to address the System Engineers' bug report.
https://diality.atlassian.net/browse/LDT-1730?focusedCommentId=75775

5:24 pm

Stephen Quong and Tiffany Mejia

More
LEAHI-APPLICATION-LDT-1730-1
finished reviewing

5:24 pm

Stephen Quong

RESOLVED

4:00 pm

Nicholas Ramirez

2:56 pm

Stephen Quong

RESOLVED

2:06 pm

Stephen Quong

RESOLVED

2:06 pm

Nicholas Ramirez

good catch. pushed an update

2:04 pm

Stephen Quong

More
Re: LEAHI-APPLICATION-LDT-1730-1
commented on review

'val' and 'max' are being set differently than the previous version.

1:53 pm

Nicholas Ramirez

i reverted the min/max changes

1:52 pm

Nicholas Ramirez

More
e9bc210
changed 11 files
LDT-2428-Onboarding-Test-Message-and-Diag-Screen-View, bugfix/LDT-1730-ui-Main-Tx-Screen---Ultrafiltration-Details and 29 more LEAHI-APPLICATION-LDT-1730-1

LDT-1738 (UI) Main Tx Screen - Ultrafiltration Details - R&I - 05: DEV - Feature Implementation

Revert min/max changes

- -2
- +2
./FinalDiagram.dot
- History
- Source
- Diff
./FinalDiagram.dot
… 10 more files in changeset.

10:43 am

Nicholas Ramirez

regenerated this file so it should be updated

10:42 am

Nicholas Ramirez

Good catch. I have those updated now

10:42 am

Nicholas Ramirez

More
e356262
changed 4 files
LDT-2428-Onboarding-Test-Message-and-Diag-Screen-View, bugfix/LDT-1730-ui-Main-Tx-Screen---Ultrafiltration-Details and 29 more LEAHI-APPLICATION-LDT-1730-1

LDT-1738 (UI) Main Tx Screen - Ultrafiltration Details - R&I - 05: DEV - Feature Implementation

Address CR comments and update obsolete max properties

- -2
- +2
./FinalDiagram.dot
- History
- Source
- Diff
./FinalDiagram.dot
… 3 more files in changeset.

10:35 am

Stephen Quong

More
Re: LEAHI-APPLICATION-LDT-1730-1
commented on review

'minimum' is also referenced in: SDDs/Main_Treatment/FinalDiagram.dot

'minimum' is also referenced in:
SDDs/Main_Treatment/FinalDiagram.dot

10:35 am

Stephen Quong

More
Re: LEAHI-APPLICATION-LDT-1730-1
commented on review

'maximum' is also referenced in: SDDs/Main_Treatment/FinalDiagram.dot sources/gui/qml/pages/treatment/TreatmentUltrafiltrationItem.qml sources/gui/qml/pages/treatment/TreatmentStack.qml sources/gui...

'maximum' is also referenced in:
SDDs/Main_Treatment/FinalDiagram.dot
sources/gui/qml/pages/treatment/TreatmentUltrafiltrationItem.qml
sources/gui/qml/pages/treatment/TreatmentStack.qml
sources/gui/qml/pages/pretreatment/connection/PreTreatmentConnectionStack.qml

8:01 am