leahi-application / sources / model / dg / adjustment / settings

MAdjustDGRequests.h

Clone Tools

Stats

Commits this week: 0
Total Committers: 3
Last Commit: 11 Dec
Commits this week: 0

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Wednesday 10 Dec
3:07 pm

Nicholas Ramirez

okay will do

okay will do

3:07 pm

Nicholas Ramirez

okay acknowledged

okay acknowledged

1:44 pm

Behrouz NematiPour

No Action For Now: Same for the vError param: https://devapps.diality.us/cru/#LEAHI-APPLICATION-LDT-2727-1CFR-76762

No Action For Now:
Same for the vError param:
https://devapps.diality.us/cru/#LEAHI-APPLICATION-LDT-2727-1CFR-76762

1:43 pm

Behrouz NematiPour

No Action For Now: Please always use mError, since it is local to the script function, to be consistent with the rest. Also, usually it is a number, not a bool. It is fine for now, but later we sh...

No Action For Now:
Please always use mError, since it is local to the script function, to be consistent with the rest.
Also, usually it is a number, not a bool.

It is fine for now, but later we should create a decorator to cover these types of similarities.

Thursday 13 Nov
11:21 am

Nicholas Ramirez

updated

updated

11:21 am

Nicholas Ramirez

this method removed but updated elsewhere

this method removed but updated elsewhere

11:21 am

Nicholas Ramirez

updated

updated

11:20 am

Nicholas Ramirez

this was existing code.. Updated to use the DeviceController and made updates accordingly. And Tested and still works

this was existing code.. Updated to use the DeviceController and made updates accordingly. And Tested and still works

11:20 am

Nicholas Ramirez

updated

updated

11:20 am

Nicholas Ramirez

updated

updated

11:19 am

Nicholas Ramirez

updated

updated

11:19 am

Nicholas Ramirez

added

added

11:19 am

Nicholas Ramirez

the content for each page is now set to this container which will handle the margins for the container so all componenets using the SettingsBase will have the same margins and I do not have to spec...

the content for each page is now set to this container which will handle the margins for the container so all componenets using the SettingsBase will have the same margins and I do not have to specify them left, right, bottom in each of them.. I have done the same thing for other components that act as a container

11:17 am

Nicholas Ramirez

added comment

added comment

11:17 am

Nicholas Ramirez

updated

updated

11:17 am

Nicholas Ramirez

updated and added to fonts

updated and added to fonts

11:16 am

Nicholas Ramirez

updated logic so the grid view has an equal number of rows depending on the total number of visible items. Before row count was hard coded to 6 so if there was ex. 8 items the left column would sh...

updated logic so the grid view has an equal number of rows depending on the total number of visible items.

Before row count was hard coded to 6 so if there was ex. 8 items the left column would show 6 and the right 2.. Updated so the gridview will look as even as possible.

I hard coded the column to 2 columns since the design has 2 columns and added logic to the row count to make the 2 columns equal

11:13 am

Nicholas Ramirez

changed to int

changed to int

11:09 am

Nicholas Ramirez

This works. A few other qml files use this version of the import

This works. A few other qml files use this version of the import

8:41 am

Nicholas Ramirez

👍 Will do all these in the enhancement story

👍 Will do all these in the enhancement story

Wednesday 12 Nov
6:21 pm

Behrouz NematiPour

Why did the logic change? The order should be to fill in the first column, then go to the next, and it should not be by row.

Why did the logic change?
The order should be to fill in the first column, then go to the next, and it should not be by row.

6:19 pm

Behrouz NematiPour

why the rowcount is real?

why the rowcount is real?

6:18 pm

Behrouz NematiPour

IMPORTANT!!! Please test this on the device.

IMPORTANT!!!
Please test this on the device.

6:13 pm

Behrouz NematiPour

For signals and slots as we tlaked use blocks of onSomething: { aFunctionCall() } Unless there are multiple similar calls that need alignment in one line.

For signals and slots as we tlaked use blocks of 

onSomething: {
   aFunctionCall()
}


Unless there are multiple similar calls that need alignment in one line.

6:04 pm

Behrouz NematiPour

Why exposed? Shouldn't the SettingsBase decide where the children must anchor, or locate?

Why exposed?
Shouldn't the SettingsBase decide where the children must anchor, or locate?

6:02 pm

Behrouz NematiPour

Every time you use " * someValue ", please add a comment explaining why. @100, @101, @102 as well.

Every time you use " * someValue ", please add a comment explaining why.
@100, @101, @102 as well.

5:01 pm

Behrouz NematiPour

Can you help me understand why we did not use the DeviceController attribute to call the datetime set script? Or modify this function to use that design?

Can you help me understand why we did not use the DeviceController attribute to call the datetime set script?
Or modify this function to use that design?

4:57 pm

Behrouz NematiPour

These two lines can be moved to the geteopochUTC.

These two lines can be moved to the geteopochUTC.

4:56 pm

Behrouz NematiPour

Please make vDateTime optional; if not set, return the current datetime epoch. It is better to use the 'timeEvent' (right now, onSetDateUIFinished).

Please make vDateTime optional; if not set, return the current datetime epoch.
It is better to use the 'timeEvent' (right now, onSetDateUIFinished).

4:51 pm

Behrouz NematiPour

The view classes are QObject, and they already have an internal timer that you can start and use in the timer event. Therefore, this block of code needs to be moved to the timerEvent. I have creat...

The view classes are QObject, and they already have an internal timer that you can start and use in the timer event.
Therefore, this block of code needs to be moved to the timerEvent.

I have created a story as an enhancement to the date and time for the following:

  1. Since the SW Board is the only reference for the clock, we now need to send the date and time to both the TD and DD every second as a broadcast message
    • That message should be on a general channel so both get it instead of two separate messages.
    • If SW won't update the TD every second, and with a different epoch, TD will raise an alarm
      • We only need to know, but SW does not need to do anything about it
      • The Alarm infrastructure will automatically handle it
      • If disconnected, TD will play the alarm sound and turn on the alarm light.
  2. While we are sending the epoch as broadcast every second, and TD will raise an alarm if we don't, we need to get rid of the two requests, response messages, and send that epoch every second broadcast.
  3. As has been mentioned above, we need to update the disabled date and time on NTP
    • When switched to NO NTP, stop updating.
  4. A timezone needs to be added to the Date and time screen, since we already have NTP, so that we can update by timezone.
  5. Another comment: don't the datetime conversion, 'toString' function is slow, and that we can pass integer values instead, since we are going to use it every second?


LDT-2909: Service - SW - 01 - Enhancement - FW epoch Broadcast, TimeZone - R&I
LDT-2923: Service - SW - 02 - Enhancement - FW epoch Broadcast, TimeZone - Q&R