leahi-application / sources / model

hd

Clone Tools

Stats

Commits this week: 5
Total Committers: 6
Last Commit: 17:08
Commits this week: 5

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Today
4 hrs ago

Nicholas Ramirez

LDT-5589 Disinfection - SW - 01- Heat Disinfect - R&I - 03: DEV - Feature Implementation & Code Document [& Diagnostics]

update message id and remove obsoelte disinfect items

Options
    • -65
    • +0
    ./adjustment/disinfect/MDisinfectAdjustModeRequests.h
    • -49
    • +0
    ./adjustment/disinfect/MDisinfectAdjustModeResponse.cpp
    • -83
    • +0
    ./adjustment/disinfect/MDisinfectAdjustModeResponse.h
    • -1
    • +1
    ./adjustment/disinfect/MDisinfectAdjustStartRequests.h
    • -2
    • +2
    ./adjustment/disinfect/MDisinfectAdjustStartResponse.h
    • -13
    • +13
    ./alarm/MAlarmMapping.cpp
  7. … 17 more files in changeset.
5 hrs ago

Nicholas Ramirez

push alarms

Options
    • -16
    • +16
    ./alarm/MAlarmMapping.cpp
  2. … 2 more files in changeset.
5 hrs ago

Nicholas Ramirez

bn approves

bn approves

5 hrs ago

Nicholas Ramirez

BN approvo

BN approvo

11 hrs ago

Dara Navaei

LEAHI-APPLICATION-LDT-5586_Disinfection - SW - 01- Heat Disinfect - R&I
LEAHI-APPLICATION-LDT-5586_Disinfection - SW - 01- Heat Disinfect - R&I
12 hrs ago

Dara Navaei

Wednesday 19 Aug
9:24 pm

Dara Navaei , Tiffany Mejia , Stephen Quong and Nicholas Ramirez

8:07 pm

Behrouz NematiPour

LEAHI-APPLICATION-LDT-5618_SW Misc & Enhc - SW - Board Freeze - I&C
LEAHI-APPLICATION-LDT-5618_SW Misc & Enhc - SW - Board Freeze - I&C
8:06 pm

Behrouz NematiPour

Updated the Alarm Mapping with the staging.

Options
    • -16
    • +16
    ./alarm/MAlarmMapping.cpp
  2. … 4 more files in changeset.
4:50 pm

Nicholas Ramirez

LDT-5575 Service - SW - 01- Calibration - Hydraulics - R&I - 03: DEV - Feature Implementation & Code Document [& Diagnostics]

qml competed

Options
    • -2
    • +2
    ./adjustment/settings/MAdjustHDRequests.h
    • -2
    • +2
    ./adjustment/settings/MAdjustHDServiceModeResponse.h
  3. … 4 more files in changeset.
4:21 pm

Behrouz NematiPour

4:07 pm

Behrouz NematiPour

Adding Alarm Mapping, since the automation is now disabled for migrations.

Options
    • -24
    • +24
    ./alarm/MAlarmMapping.cpp
  2. … 4 more files in changeset.
3:04 pm

Dara Navaei

LEAHI-APPLICATION-LDT-5618_SW Misc & Enhc - SW - Board Freeze - I&C
LEAHI-APPLICATION-LDT-5618_SW Misc & Enhc - SW - Board Freeze - I&C
2:05 pm

Dara Navaei

LEAHI-APPLICATION-LDT-5572_Service - SW - 01- Calibration - Hydraulics - R&I
LEAHI-APPLICATION-LDT-5572_Service - SW - 01- Calibration - Hydraulics - R&I
1:51 pm

Nicholas Ramirez

updated

updated

12:49 pm

Behrouz NematiPour

APPROVED.

APPROVED.

12:49 pm

Behrouz NematiPour

RESOLVED. Added another comment regarding the same.

RESOLVED.
Added another comment regarding the same.

12:48 pm

Behrouz NematiPour

Nicholas Ramirez Thanks for the change to the ok and result. *To be consistent, could you please use ok instead of result, since all the other parts of the code use ok as an argument, and the fun...

Nicholas Ramirez
Thanks for the change to the ok and result.

  • To be consistent, could you please use ok instead of result, since all the other parts of the code use ok as an argument, and the function itself has ok as the parameter name.
  • Also move the: 
    ; if ( ! ok ) { goto invalid; }

    on the "same line" and "aligned" as the evaluating parameter, to keep the code clean.

12:40 pm

Behrouz NematiPour

APPROVED

APPROVED

12:28 pm

Behrouz NematiPour

12:28 pm

Behrouz NematiPour

Tuesday 18 Aug
4:24 pm

Nicholas Ramirez

updated

updated

4:24 pm

Nicholas Ramirez

updated

updated

4:24 pm

Nicholas Ramirez

updated

updated

3:50 pm

Nicholas Ramirez

3:50 pm

Stephen Quong

3:35 pm

Nicholas Ramirez

remove the ok and just check result and if any fails goto invalid

remove the ok and just check result and if any fails goto invalid

3:34 pm

Nicholas Ramirez

see if you can use payloadLen from MessageGlobals.h

see if you can use payloadLen from MessageGlobals.h

3:17 pm

Nicholas Ramirez

double check

double check

3:07 pm

Nicholas Ramirez

bn aproves

bn aproves