leahi-dialin

Clone Tools

Stats

Commits this week: 52
Total Committers: 15
Last Commit: 06 Feb
Commits this week: 52

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few minutes ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Friday 06 Feb
8:18 pm

Vendor - TEL - Sameer Poyil

for Dry Bicart , I have reserved the message ID long time back as 0x70 and its correct. I was confused after staging branch merged with my local branch, since all of my other message ID are used by...

for Dry Bicart , I have reserved the message ID long time back as 0x70 and its correct. I was confused after staging branch merged with my local branch, since all of my other message ID are used by other modules except BICART_DATA. please dis regard this question.

8:15 pm

Vendor - TEL - Sameer Poyil

This is a merge issue. when I updated the code and aligned to staging , this all change happened. Need to check with Dara

This is a merge issue. when I updated the code and aligned to staging , this all change happened. Need to check with Dara

3:24 pm

Zoltan Miskolci and Sean Nash

2:14 pm

Sean Nash

Can you review this with Michael G and find out if this is even needed? Can we remove? If not, what is it doing and why?

Can you review this with Michael G and find out if this is even needed? Can we remove? If not, what is it doing and why?

1:21 pm

Nicholas Ramirez

1:14 pm

Behrouz NematiPour and Stephen Quong

1:12 pm

Stephen Quong

1:11 pm

Nicholas Ramirez

1:11 pm

Stephen Quong

1:10 pm

Nicholas Ramirez

1:09 pm

Stephen Quong

1:09 pm

Nicholas Ramirez

12:54 pm

Vendor - TEL - Jashwant Gantyada

Merge branch 'LDT-2316-max-allowed-h12-power-needs-to-updated' into develop

Options
10:56 am

Vendor - TEL - Jashwant Gantyada

10:53 am

Zoltan Miskolci and Sean Nash

10:41 am

Sean Nash

Add a blank line between functions.

Add a blank line between functions.

9:47 am

Vendor - TEL - Jashwant Gantyada

LDT-2316 fixed code review comments

Options
    • -2
    • +1
    /leahi_dialin/td/modules/air_pump.py
9:47 am

Zoltan Miskolci

I see it as a list, don't know why it is named enum or what the original purpose of it was. It was never updated, so I added the update part at least, so it will at least reflect the current states...

I see it as a list, don't know why it is named enum or what the original purpose of it was.
It was never updated, so I added the update part at least, so it will at least reflect the current states instead of always stating zeros.

9:45 am

Zoltan Miskolci

I don't think it's an enum at all. It was a list, but it was never updated, so I added that part to it.

I don't think it's an enum at all. It was a list, but it was never updated, so I added that part to it.

9:37 am

Sean Nash

Is this staying? Is all of above replacing this class?

Is this staying? Is all of above replacing this class?

9:32 am

Vendor - TEL - Jashwant Gantyada

Done.

Done.

9:31 am

Vendor - TEL - Jashwant Gantyada

LDT-2316 addressed review comments

Options
    • -2
    • +4
    /leahi_dialin/td/modules/air_pump.py
9:30 am

Sean Nash

Is this a dynamic enum?

Is this a dynamic enum?

9:29 am

Sean Nash

What is happening here? Is this a dynamic enum? Where is it used?

What is happening here? Is this a dynamic enum? Where is it used?

9:27 am

Sean Nash

9:26 am

Sean Nash

Can we make 255 a constant with a name like MAX_AIR_PUMP_POWER_LEVEL to make it clear what we're doing here?

Can we make 255 a constant with a name like MAX_AIR_PUMP_POWER_LEVEL to make it clear what we're doing here?

9:25 am

Zoltan Miskolci

We agreed to change back the enums into the static variation. Why would that cover a class that has been implemented to mask the enums from direct access, so if they need to be changed to dynamic o...

We agreed to change back the enums into the static variation.
Why would that cover a class that has been implemented to mask the enums from direct access, so if they need to be changed to dynamic or renamed or anything, the other repositories that are using them through this class won't be affected or need any update.

9:17 am

Zoltan Miskolci

9:11 am

Zoltan Miskolci

9:02 am

Dara Navaei

LEAHI-DIALIN-LDT-2316_Max allowed H12 power needs to be updated
LEAHI-DIALIN-LDT-2316_Max allowed H12 power needs to be updated