Fisheye on leahi-dialin/leahi_dialin/dd/modules

leahi-dialin (LDT-3904-opmode-the-operation-mode-broad): - Updated events

Zoltan Miskolci — Tue, 05 May 2026 15:10:55 -0700

Zoltan Miskolci committed 75c9789 on branch LDT-3904-opmode-the-operation-mode-broad in leahi-dialin

- Updated events

· /leahi_dialin/common/generic_defs.py	(-2, +2)	\| History	\| Source	\| Diff
· /leahi_dialin/dd/modules/events.py	(-18, +14)	\| History	\| Source	\| Diff
· /leahi_dialin/fp/modules/events.py	(-56, +35)	\| History	\| Source	\| Diff
· /leahi_dialin/td/modules/events.py	(-57, +34)	\| History	\| Source	\| Diff

leahi-dialin (LDT-3904-opmode-the-operation-mode-broad): - Updated DD and TD module - Updaterd TDValvePosition enum

Zoltan Miskolci — Tue, 05 May 2026 14:25:28 -0700

Zoltan Miskolci committed 34b64ff on branch LDT-3904-opmode-the-operation-mode-broad in leahi-dialin

- Updated DD and TD module - Updaterd TDValvePosition enum

· /leahi_dialin/common/td_defs.py

(-6, +8)

| History

| Source

| Diff

· /leahi_dialin/dd/dialysate_delivery.py

(-8, +4)

| History

| Source

| Diff

· /leahi_dialin/dd/modules/balancing_chamber.py

(-1, +0)

| History

| Source

| Diff

· /leahi_dialin/dd/modules/blood_leak.py

(-1, +0)

| History

| Source

| Diff

· /leahi_dialin/dd/modules/concentrate_pump.py

(-27, +26)

| History

| Source

| Diff

· /leahi_dialin/dd/modules/conductivity_sensors.py

(-7, +6)

| History

| Source

| Diff

· /leahi_dialin/dd/modules/dialysate_pump.py

(-22, +21)

| History

| Source

| Diff

· /leahi_dialin/dd/modules/drybicart.py

(-1, +0)

| History

| Source

| Diff

· /leahi_dialin/dd/modules/gen_dialysate.py

(-1, +0)

| History

| Source

| Diff

· /leahi_dialin/dd/modules/heaters.py

(-11, +10)

| History

| Source

| Diff

· /leahi_dialin/dd/modules/levels.py

(-6, +4)

| History

| Source

| Diff

· /leahi_dialin/dd/modules/post_gen_dialysate.py

(-1, +0)

| History

| Source

| Diff

· /leahi_dialin/dd/modules/pre_gen_dialysate.py

(-1, +0)

| History

| Source

| Diff

· /leahi_dialin/dd/modules/pressure_sensors.py

(-7, +6)

| History

| Source

| Diff

· /leahi_dialin/dd/modules/rinse_pump.py

(-1, +0)

| History

| Source

| Diff

… 40 more files in changeset.

LEAHI-DIALIN-LDT-3854-1: reviewers finished

Tue, 05 May 2026 10:55:19 -0700

Raghu Kallala , Zoltan Miskolci and Michael Garthwaite finished reviewing LEAHI-DIALIN-LDT-3854-1

LEAHI-DIALIN-LDT-3854_(DD) Chamber F level sensor not reporting the level properly

LEAHI-DIALIN-LDT-3854-1: started by Dara Navaei

Dara Navaei — Tue, 05 May 2026 10:33:29 -0700

Dara Navaei started review LEAHI-DIALIN-LDT-3854-1

leahi-dialin (LDT-3854-dd-bicarb-chamber-f-level-fix): LDT-3854 dialin update for -chamber-f-level

Vendor - TEL - Sameer Poyil — Tue, 05 May 2026 10:26:09 -0700

Vendor - TEL - Sameer Poyil committed 344ffd4 on branch LDT-3854-dd-bicarb-chamber-f-level-fix, develop in leahi-dialin

LDT-3854 dialin update for -chamber-f-level

· /leahi_dialin/dd/modules/levels.py

(-5, +3)

| History

| Source

| Diff

LEAHI-DIALIN-LDT-3904-1: started by Dara Navaei

Dara Navaei — Mon, 04 May 2026 17:46:48 -0700

Dara Navaei started review LEAHI-DIALIN-LDT-3904-1

leahi-dialin (LDT-3904-opmode-the-operation-mode-broad): - Handler and import refactoring of DD module

Zoltan Miskolci — Mon, 04 May 2026 17:24:25 -0700

Zoltan Miskolci committed 6d104d3 on branch LDT-3904-opmode-the-operation-mode-broad in leahi-dialin

- Handler and import refactoring of DD module

· /leahi_dialin/common/alarm_defs.py

(-1, +1)

| History

| Source

| Diff

· /leahi_dialin/common/alarm_priorities.py

(-1, +1)

| History

| Source

| Diff

· /leahi_dialin/common/dd_defs.py

(-21, +1)

| History

| Source

| Diff

· /leahi_dialin/common/dd_defs_proxy.py

(-1, +2)

| History

| Source

| Diff

· /leahi_dialin/common/disp_defs.py

(-1, +1)

| History

| Source

| Diff

· /leahi_dialin/common/fp_defs.py

(-22, +1)

| History

| Source

| Diff

· /leahi_dialin/common/fp_defs_proxy.py

(-1, +2)

| History

| Source

| Diff

· /leahi_dialin/common/generic_defs.py

(-0, +57)

| History

| Source

· /leahi_dialin/common/global_vars.py

(-43, +0)

| History

| Source

| Diff

· /leahi_dialin/common/msg_defs.py

(-4, +5)

| History

| Source

| Diff

· /leahi_dialin/common/msg_ids.py

(-1, +1)

| History

| Source

| Diff

· /leahi_dialin/common/td_defs.py

(-21, +1)

| History

| Source

| Diff

· /leahi_dialin/common/td_defs_proxy.py

(-1, +2)

| History

| Source

| Diff

· /leahi_dialin/common/test_config_defs.py

(-1, +1)

| History

| Source

| Diff

· /leahi_dialin/dd/dialysate_delivery.py

(-33, +58)

| History

| Source

| Diff

… 31 more files in changeset.

LEAHI-DIALIN-LDT-4000-1: comment by Zoltan Miskolci "Update the header docc please"

Zoltan Miskolci — Fri, 01 May 2026 09:08:59 -0700

Zoltan Miskolci commented on LEAHI-DIALIN-LDT-4000-1

Update the header docc please

LEAHI-DIALIN-LDT-4000-1: comment by Zoltan Miskolci "DD Substitution Pump"

Zoltan Miskolci — Fri, 01 May 2026 09:08:37 -0700

Zoltan Miskolci commented on LEAHI-DIALIN-LDT-4000-1

DD Substitution Pump

LEAHI-DIALIN-LDT-4000-1: comment by Zoltan Miskolci "It's not really a start / stop command, when yo..."

Zoltan Miskolci — Fri, 01 May 2026 09:07:32 -0700

Zoltan Miskolci commented on LEAHI-DIALIN-LDT-4000-1

It's not really a start / stop command, when you are setting the speed.

LEAHI-DIALIN-LDT-4000-1: comment by Zoltan Miskolci "shouldn't this be "msg_id_dd_substitution_pump_..."

Zoltan Miskolci — Fri, 01 May 2026 09:05:50 -0700

Zoltan Miskolci commented on LEAHI-DIALIN-LDT-4000-1

shouldn't this be "msg_id_dd_substitution_pump_data"?

leahi-dialin (LDT-4000-hdf-fw-implementation-1-4): LDT-4000: updated message IDs. Updated test config for beta 1.9 and 2.0. implemented substitution pump module

Michael Garthwaite — Thu, 30 Apr 2026 16:54:17 -0700

Michael Garthwaite committed d0391ac on branch LDT-4000-hdf-fw-implementation-1-4, develop in leahi-dialin

LDT-4000: updated message IDs. Updated test config for beta 1.9 and 2.0. implemented substitution pump module

· /leahi_dialin/common/msg_ids.py	(-1, +19)	\| History	\| Source	\| Diff
· /leahi_dialin/common/test_config_defs.py	(-1, +1)	\| History	\| Source	\| Diff
· /leahi_dialin/dd/dialysate_delivery.py	(-1, +3)	\| History	\| Source	\| Diff
· /leahi_dialin/dd/modules/substitution_pump.py	(-0, +112)	\| History	\| Source

LEAHI-DIALIN-LDT-3984-2: closed by Vendor - TEL - Sameer Poyil

Vendor - TEL - Sameer Poyil — Thu, 30 Apr 2026 16:33:47 -0700

Vendor - TEL - Sameer Poyil Closed LEAHI-DIALIN-LDT-3984-2

LEAHI-DIALIN-LDT-3984-2: reviewers finished

Thu, 30 Apr 2026 16:28:42 -0700

Michael Garthwaite and Raghu Kallala finished reviewing LEAHI-DIALIN-LDT-3984-2

LEAHI-DIALIN-LDT-3984_(DD, SW) D46 reads 0 with and without liquid in chamber

LEAHI-DIALIN-LDT-3984-2: started by Dara Navaei

Dara Navaei — Thu, 30 Apr 2026 15:34:38 -0700

Dara Navaei started review LEAHI-DIALIN-LDT-3984-2

leahi-dialin (LDT-3904-opmode-the-operation-mode-broad): LDT-3984-unit-test-failure-fix

Vendor - TEL - Sameer Poyil — Thu, 30 Apr 2026 15:28:58 -0700

Vendor - TEL - Sameer Poyil committed b8ea59d on branch LDT-3854-dd-bicarb-chamber-f-level-fix, LDT-3904-opmode-the-operation-mode-broad and 4 more in leahi-dialin

LDT-3984-unit-test-failure-fix

· /leahi_dialin/dd/modules/levels.py

(-1, +1)

| History

| Source

| Diff

LEAHI-DIALIN-LDT-4000-1: started by Dara Navaei

Dara Navaei — Thu, 30 Apr 2026 14:32:36 -0700

Dara Navaei started review LEAHI-DIALIN-LDT-4000-1

LEAHI-DIALIN-LDT-3984-1: closed by Vendor - TEL - Sameer Poyil

Vendor - TEL - Sameer Poyil — Thu, 30 Apr 2026 14:23:40 -0700

Vendor - TEL - Sameer Poyil Closed LEAHI-DIALIN-LDT-3984-1

leahi-dialin (LDT-4000-hdf-fw-implementation-1-4): LDT-4000: fixed unit testing

Michael Garthwaite — Thu, 30 Apr 2026 14:22:36 -0700

Michael Garthwaite committed 15c9d63 on branch LDT-4000-hdf-fw-implementation-1-4, develop in leahi-dialin

LDT-4000: fixed unit testing

· /leahi_dialin/dd/modules/levels.py

(-1, +1)

| History

| Source

| Diff

LEAHI-DIALIN-LDT-3984-1: comment by Zoltan Miskolci "What's the point of this line if you overwrite ..."

Zoltan Miskolci — Tue, 28 Apr 2026 09:17:20 -0700

Zoltan Miskolci commented on LEAHI-DIALIN-LDT-3984-1

What's the point of this line if you overwrite the lvl_sen value in the next 2 lines?
I think the second lvl_sen is not needed, the one without the offset.

LEAHI-DIALIN-LDT-3984-1: comment by Zoltan Miskolci "LAST_DD_LEVL is in FW not in dialin. In dialin..."

Zoltan Miskolci — Tue, 28 Apr 2026 09:25:40 -0700

Zoltan Miskolci replied to Raghu Kallala in LEAHI-DIALIN-LDT-3984-1

LAST_DD_LEVL is in FW not in dialin.
In dialin, you use the Num_of_levels, so this one is correct here.
Example:
In this case Num_of_levels is 4 (D6,D63,D98,D46), if in the override adding 4 to the fp level sensor, which is 0, the payload will provide 4, which will be between the FIRST_FP_LEVL and LAST_FP_LEVL FW value as P25 index is 4.

LEAHI-DIALIN-LDT-3984-1: comment by Zoltan Miskolci "Why increment the number when you didn't add a ..."

Zoltan Miskolci — Tue, 28 Apr 2026 09:15:57 -0700

Zoltan Miskolci commented on LEAHI-DIALIN-LDT-3984-1

Why increment the number when you didn't add a new sensor?

LEAHI-DIALIN-LDT-3984-1: comment by Raghu Kallala "This should be LAST_DD_LEVL not NUM_OF_LEVELS i..."

Raghu Kallala — Tue, 28 Apr 2026 09:01:04 -0700

Raghu Kallala commented on LEAHI-DIALIN-LDT-3984-1

This should be LAST_DD_LEVL not NUM_OF_LEVELS if DD and FP levels are in same enum

LEAHI-DIALIN-LDT-3984-1: comment by Raghu Kallala "LEVEL_OFFSET?"

Raghu Kallala — Tue, 28 Apr 2026 09:00:08 -0700

Raghu Kallala commented on LEAHI-DIALIN-LDT-3984-1

LEVEL_OFFSET?

LEAHI-DIALIN-LDT-3984-1: reviewers resumed

Mon, 27 Apr 2026 20:46:21 -0700

Sean Nash and Raghu Kallala resumed reviewing LEAHI-DIALIN-LDT-3984-1

LEAHI-DIALIN-LDT-3984_(DD, SW) D46 reads 0 with and without liquid in chamber

leahi-dialin (LDT-3904-opmode-the-operation-mode-broad): LDT-3984 fix for conductivie level sensors d46, d63,d98

Vendor - TEL - Sameer Poyil — Mon, 27 Apr 2026 20:44:56 -0700

Vendor - TEL - Sameer Poyil committed 03cf6f1 on branch LDT-3854-dd-bicarb-chamber-f-level-fix, LDT-3904-opmode-the-operation-mode-broad and 6 more in leahi-dialin

LDT-3984 fix for conductivie level sensors d46, d63,d98

· /leahi_dialin/common/dd_defs.py	(-5, +5)	\| History	\| Source	\| Diff
· /leahi_dialin/common/fp_defs.py	(-1, +2)	\| History	\| Source	\| Diff
· /leahi_dialin/dd/modules/levels.py	(-3, +2)	\| History	\| Source	\| Diff
· /leahi_dialin/fp/modules/levels.py	(-1, +3)	\| History	\| Source	\| Diff

leahi-dialin (LDT-3904-opmode-the-operation-mode-broad): LDT-3984 conductive level sensor dialin implementation

Vendor - TEL - Sameer Poyil — Fri, 24 Apr 2026 22:45:49 -0700

Vendor - TEL - Sameer Poyil committed 106e58f on branch LDT-3854-dd-bicarb-chamber-f-level-fix, LDT-3904-opmode-the-operation-mode-broad and 6 more in leahi-dialin

LDT-3984 conductive level sensor dialin implementation

· /leahi_dialin/common/msg_ids.py	(-1, +2)	\| History	\| Source	\| Diff
· /leahi_dialin/dd/modules/levels.py	(-0, +27)	\| History	\| Source	\| Diff
· /leahi_dialin/fp/modules/levels.py	(-3, +5)	\| History	\| Source	\| Diff

LEAHI-DIALIN-LDT-3352-1: closed by Zoltan Miskolci

Zoltan Miskolci — Fri, 24 Apr 2026 10:40:01 -0700

Zoltan Miskolci Closed LEAHI-DIALIN-LDT-3352-1

LEAHI-DIALIN-LDT-3984-1: started by Dara Navaei

Dara Navaei — Thu, 23 Apr 2026 08:02:29 -0700

Dara Navaei started review LEAHI-DIALIN-LDT-3984-1

leahi-dialin (LDT-3904-opmode-the-operation-mode-broad): LDT-3984 aligning D46 with DD firmware

Vendor - TEL - Sameer Poyil — Thu, 23 Apr 2026 08:00:45 -0700

Vendor - TEL - Sameer Poyil committed 23ad7f4 on branch LDT-3854-dd-bicarb-chamber-f-level-fix, LDT-3904-opmode-the-operation-mode-broad and 6 more in leahi-dialin

LDT-3984 aligning D46 with DD firmware

· /leahi_dialin/common/dd_defs.py	(-4, +4)	\| History	\| Source	\| Diff
· /leahi_dialin/dd/modules/levels.py	(-3, +3)	\| History	\| Source	\| Diff