Fisheye on leahi-dialin/leahi_dialin/ro/modules

LEAHI-DIALIN-LDT-2655-1: reviewers finished

Mon, 30 Mar 2026 09:39:06 -0700

Sean Nash finished reviewing LEAHI-DIALIN-LDT-2655-1

LEAHI-DIALIN-LDT-2655_Cannot override conductivity sensor temperature from the conductivity module

LEAHI-DIALIN-LDT-2655-1: comment by Michael Garthwaite "yeah its obsolete. This is an old branch that r..."

Michael Garthwaite — Mon, 16 Mar 2026 10:04:25 -0700

Michael Garthwaite replied to Sean Nash in LEAHI-DIALIN-LDT-2655-1

yeah its obsolete. This is an old branch that recently got synced with latest staging. It looks like the CR doesn't recognize the correct changes from staging. There should only be 1 file change ( conductivity sensors ).

LEAHI-DIALIN-LDT-2655-1: reviewers joined LEAHI-DIALIN-LDT-2655_Cannot override conductivity...

Wed, 04 Mar 2026 12:46:36 -0800

Dara Navaei joined LEAHI-DIALIN-LDT-2655-1

LEAHI-DIALIN-LDT-2655_Cannot override conductivity sensor temperature from the conductivity module

LEAHI-DIALIN-LDT-2655-1: reviewers removed from LEAHI-DIALIN-LDT-2655_Cannot override conductivity...

Wed, 04 Mar 2026 12:46:36 -0800

Dara Navaei removed Michael Garthwaite from LEAHI-DIALIN-LDT-2655-1

LEAHI-DIALIN-LDT-2655_Cannot override conductivity sensor temperature from the conductivity module

LEAHI-DIALIN-LDT-2655-1: comment by Sean Nash "Why do we have an "ro" and an "fp" folder? Is ..."

Sean Nash — Tue, 09 Dec 2025 14:26:46 -0800

Sean Nash commented on LEAHI-DIALIN-LDT-2655-1

Why do we have an "ro" and an "fp" folder? Is "ro" folder obsolete (replaced by "fp")?

LEAHI-DIALIN-LDT-2655-1: started by Dara Navaei

Dara Navaei — Mon, 08 Dec 2025 08:15:35 -0800

Dara Navaei started review LEAHI-DIALIN-LDT-2655-1

LEAHI-DIALIN-LDT-237-1: closed by Behrouz NematiPour

Behrouz NematiPour — Thu, 24 Apr 2025 16:04:58 -0700

Behrouz NematiPour Closed LEAHI-DIALIN-LDT-237-1

LEAHI-DIALIN-LDT-237-1: reviewers finished

Thu, 24 Apr 2025 16:04:25 -0700

Dara Navaei finished reviewing LEAHI-DIALIN-LDT-237-1

LEAHI-DIALIN-LDT-237 - Simulator Dialin

LEAHI-DIALIN-LEAH-261-1: closed by Michael Garthwaite

Michael Garthwaite — Wed, 23 Apr 2025 16:29:37 -0700

Michael Garthwaite Closed LEAHI-DIALIN-LEAH-261-1

LEAHI-DIALIN-LDT-237-1: reviewers finished

Wed, 23 Apr 2025 16:15:22 -0700

Tiffany Mejia and Michael Garthwaite finished reviewing LEAHI-DIALIN-LDT-237-1

LEAHI-DIALIN-LDT-237 - Simulator Dialin

LEAHI-DIALIN-LEAH-261-1: reviewers finished

Wed, 23 Apr 2025 16:02:54 -0700

Tiffany Mejia and Sean Nash finished reviewing LEAHI-DIALIN-LEAH-261-1

LEAHI-DIALIN-LEAH-261_FW RO Flow Sensor Driver

leahi-dialin (feature/LDT-713-general-alarm-requirements-sw): test

Behrouz NematiPour — Wed, 23 Apr 2025 15:49:25 -0700

Behrouz NematiPour committed 1a719e5 on branch master, LDT-1195-dd-is-balancing-chamber-switching and 84 more in leahi-dialin

test

· /leahi_dialin/fp/__init__.py

(-0, +22)

| History

| Source

| Diff

· /leahi_dialin/fp/modules/__init__.py

(-0, +0)

| History

| Source

| Diff

· /leahi_dialin/fp/modules/boost_pump.py

(-0, +255)

| History

| Source

| Diff

· /leahi_dialin/fp/modules/conductivity_sensors.py

(-0, +230)

| History

| Source

| Diff

· /leahi_dialin/fp/modules/constants.py

(-0, +18)

| History

| Source

| Diff

· /leahi_dialin/fp/modules/flow_sensors.py

(-0, +175)

| History

| Source

| Diff

· /leahi_dialin/fp/modules/levels.py

(-0, +128)

| History

| Source

| Diff

· /leahi_dialin/fp/modules/pressure_sensors.py

(-0, +220)

| History

| Source

| Diff

· /leahi_dialin/fp/modules/valves.py

(-0, +294)

| History

| Source

| Diff

· /leahi_dialin/fp/reverse_osmosis.py

(-0, +248)

| History

| Source

| Diff

· /leahi_dialin/ro/__init__.py

(-22, +0)

| History

| Source

| Diff

· /leahi_dialin/ro/modules/__init__.py

(-0, +0)

| History

| Source

| Diff

· /leahi_dialin/ro/modules/boost_pump.py

(-255, +0)

| History

| Source

| Diff

· /leahi_dialin/ro/modules/conductivity_sensors.py

(-230, +0)

| History

| Source

| Diff

· /leahi_dialin/ro/modules/constants.py

(-18, +0)

| History

| Source

| Diff

… 5 more files in changeset.

LEAHI-DIALIN-LEAH-261-1: started by Michael Garthwaite

Michael Garthwaite — Wed, 23 Apr 2025 15:16:55 -0700

Michael Garthwaite started review LEAHI-DIALIN-LEAH-261-1

LEAHI-DIALIN-LDT-237-1: reviewers removed from LEAHI-DIALIN-LDT-237 - Simulator Dialin

Wed, 23 Apr 2025 14:46:59 -0700

Behrouz NematiPour removed amanesh (deleted user) from LEAHI-DIALIN-LDT-237-1

LEAHI-DIALIN-LDT-237 - Simulator Dialin

LEAHI-DIALIN-LEAH-261-1: comment by Michael Garthwaite "fixed. Thanks!"

Michael Garthwaite — Wed, 23 Apr 2025 14:26:07 -0700

Michael Garthwaite replied to Sean Nash in LEAHI-DIALIN-LEAH-261-1

fixed. Thanks!

leahi-dialin (): LDT-242 Main Treatment Screen - SW - Simulator Cleanup - 05: DEV - Feature Implementation...

Behrouz NematiPour — Wed, 23 Apr 2025 13:54:30 -0700

Behrouz NematiPour committed 35450f4 on branch in leahi-dialin

LDT-242 Main Treatment Screen - SW - Simulator Cleanup - 05: DEV - Feature Implementation

- Rename the RO to FP.

· /leahi_dialin/fp/__init__.py

(-0, +22)

| History

| Source

· /leahi_dialin/fp/modules/__init__.py

(-0, +0)

| History

| Source

· /leahi_dialin/fp/modules/boost_pump.py

(-0, +255)

| History

| Source

· /leahi_dialin/fp/modules/conductivity_sensors.py

(-0, +230)

| History

| Source

· /leahi_dialin/fp/modules/constants.py

(-0, +18)

| History

| Source

· /leahi_dialin/fp/modules/flow_sensors.py

(-0, +175)

| History

| Source

· /leahi_dialin/fp/modules/levels.py

(-0, +128)

| History

| Source

· /leahi_dialin/fp/modules/pressure_sensors.py

(-0, +220)

| History

| Source

· /leahi_dialin/fp/modules/valves.py

(-0, +294)

| History

| Source

· /leahi_dialin/fp/reverse_osmosis.py

(-0, +248)

| History

| Source

· /leahi_dialin/ro/__init__.py

(-22, +0)

| History

| Source

| Diff

· /leahi_dialin/ro/modules/__init__.py

(-0, +0)

| History

| Source

| Diff

· /leahi_dialin/ro/modules/boost_pump.py

(-255, +0)

| History

| Source

| Diff

· /leahi_dialin/ro/modules/conductivity_sensors.py

(-230, +0)

| History

| Source

| Diff

· /leahi_dialin/ro/modules/constants.py

(-18, +0)

| History

| Source

| Diff

… 5 more files in changeset.

LEAHI-DIALIN-LDT-237-1: started by Dara Navaei

Dara Navaei — Sat, 05 Apr 2025 20:18:19 -0700

Dara Navaei started review LEAHI-DIALIN-LDT-237-1

LEAHI-DIALIN-LEAH-261-1: comment by Sean Nash "Remove extra blank line."

Sean Nash — Mon, 24 Feb 2025 09:49:44 -0800

Sean Nash commented on LEAHI-DIALIN-LEAH-261-1

Remove extra blank line.

LEAHI-DIALIN-LEAH-261-1: comment by Sean Nash "function header?"

Sean Nash — Mon, 24 Feb 2025 09:47:55 -0800

Sean Nash commented on LEAHI-DIALIN-LEAH-261-1

function header?

LEAHI-DIALIN-LEAH-261-1: comment by Sean Nash "We should remove DG references throughout. If ..."

Sean Nash — Mon, 24 Feb 2025 09:44:39 -0800

Sean Nash commented on LEAHI-DIALIN-LEAH-261-1

We should remove DG references throughout. If f/w doesn't call for some of these yet, lets just remove them for now.

leahi-dialin (feature/LDT-713-general-alarm-requirements-sw): WIP on develop...

Michael Garthwaite — Fri, 21 Feb 2025 08:23:54 -0800

Michael Garthwaite committed 0f08c28 on branch master, LDT-1195-dd-is-balancing-chamber-switching and 84 more in leahi-dialin

WIP on develop

Renamed RO class and sub modules to use FP to be in line with sub system names

· /leahi_dialin/__init__.py

(-1, +1)

| History

| Source

| Diff

· /leahi_dialin/fp/__init__.py

(-0, +1)

| History

| Source

· /leahi_dialin/fp/filtration_purification.py

(-0, +250)

| History

| Source

· /leahi_dialin/fp/modules/__init__.py

(-0, +0)

| History

| Source

· /leahi_dialin/fp/modules/boost_pump.py

(-0, +256)

| History

| Source

· /leahi_dialin/fp/modules/conductivity_sensors.py

(-0, +230)

| History

| Source

· /leahi_dialin/fp/modules/constants.py

(-0, +18)

| History

| Source

· /leahi_dialin/fp/modules/flow_sensors.py

(-0, +175)

| History

| Source

· /leahi_dialin/fp/modules/levels.py

(-0, +135)

| History

| Source

· /leahi_dialin/fp/modules/pressure_sensors.py

(-0, +220)

| History

| Source

· /leahi_dialin/fp/modules/valves.py

(-0, +294)

| History

| Source

· /leahi_dialin/protocols/CAN.py

(-10, +10)

| History

| Source

| Diff

· /leahi_dialin/ro/__init__.py

(-1, +0)

| History

| Source

| Diff

· /leahi_dialin/ro/modules/__init__.py

(-0, +0)

| History

| Source

| Diff

· /leahi_dialin/ro/modules/boost_pump.py

(-255, +0)

| History

| Source

| Diff

… 9 more files in changeset.

LEAHI-DIALIN-LEAH-261-1: started by Dara Navaei

Dara Navaei — Fri, 14 Feb 2025 09:26:45 -0800

Dara Navaei started review LEAHI-DIALIN-LEAH-261-1

leahi-dialin (LDT-2655-fix_conductivity_override): Merge branch 'LEAH-261-fw-ro-flow-sensor-driver' into develop

Michael Garthwaite — Thu, 13 Feb 2025 14:18:41 -0800

Michael Garthwaite committed dfbb4f0 on branch LDT-2655-fix_conductivity_override, develop in leahi-dialin

Merge branch 'LEAH-261-fw-ro-flow-sensor-driver' into develop

· /leahi_dialin/dd/modules/piston_pump.py	(-6, +13)	\| History	\| Source	\| Diff
· /leahi_dialin/dd/proxies/td_proxy.py	(-2, +8)	\| History	\| Source	\| Diff
· /leahi_dialin/ro/modules/boost_pump.py	(-34, +32)	\| History	\| Source	\| Diff
· /leahi_dialin/ro/modules/levels.py	(-9, +10)	\| History	\| Source	\| Diff
· /leahi_dialin/ro/modules/valves.py	(-54, +54)	\| History	\| Source	\| Diff
· /leahi_dialin/ro/reverse_osmosis.py	(-3, +3)	\| History	\| Source	\| Diff

LEAHI-DIALIN-LEAH-136-3: closed by Michael Garthwaite

Michael Garthwaite — Mon, 10 Feb 2025 08:40:11 -0800

Michael Garthwaite Closed LEAHI-DIALIN-LEAH-136-3

LEAHI-DIALIN-LEAH-136-3: reviewers finished

Fri, 07 Feb 2025 09:59:02 -0800

Sean Nash finished reviewing LEAHI-DIALIN-LEAH-136-3

LEAH-136-dial-ro-base-object

LEAHI-DIALIN-LEAH-136-3: reviewers finished

Thu, 06 Feb 2025 10:18:51 -0800

Tiffany Mejia finished reviewing LEAHI-DIALIN-LEAH-136-3

LEAH-136-dial-ro-base-object

LEAHI-DIALIN-LEAH-136-3: comment by Michael Garthwaite "my bad. Now its fixed! I'll probably change the..."

Michael Garthwaite — Thu, 06 Feb 2025 10:00:14 -0800

Michael Garthwaite replied to Sean Nash in LEAHI-DIALIN-LEAH-136-3

my bad. Now its fixed! I'll probably change the whole RO directory to something like FP in a future update to stay in sync with the naming of the subsystems

LEAHI-DIALIN-LEAH-136-3: comment by Michael Garthwaite "my bad. Now its fixed!"

Michael Garthwaite — Thu, 06 Feb 2025 09:59:19 -0800

Michael Garthwaite replied to Sean Nash in LEAHI-DIALIN-LEAH-136-3

my bad. Now its fixed!

LEAHI-DIALIN-LEAH-136-3: comment by Michael Garthwaite "my bad. Now its fixed!"

Michael Garthwaite — Thu, 06 Feb 2025 09:59:12 -0800

Michael Garthwaite replied to Sean Nash in LEAHI-DIALIN-LEAH-136-3

my bad. Now its fixed!

LEAHI-DIALIN-LEAH-136-3: comment by Michael Garthwaite "my bad. Now its fixed!"

Michael Garthwaite — Thu, 06 Feb 2025 09:58:55 -0800

Michael Garthwaite replied to Sean Nash in LEAHI-DIALIN-LEAH-136-3

my bad. Now its fixed!