Fisheye on leahi-dialin/leahi_dialin/utils

LEAHI-DIALIN-LDT-4160-1: reviewers resumed

Fri, 26 Jun 2026 13:43:13 -0700

Michael Garthwaite resumed reviewing LEAHI-DIALIN-LDT-4160-1

LEAHI-DIALIN-LDT-4160_[Request] Get function for full detailed Alarm Table

LEAHI-DIALIN-LDT-4484-1: comment by Behrouz NematiPour "I am happy to see that this old code is improvi..."

Behrouz NematiPour — Thu, 25 Jun 2026 17:33:21 -0700

Behrouz NematiPour commented on LEAHI-DIALIN-LDT-4484-1

I am happy to see that this old code is improving.
I would recommend using the Conversion module instead of strings and DataTypes, as it handles everything automatically.
Examples can be found in the following file in this CR:
https://devapps.diality.us/cru/#LEAHI-DIALIN-LDT-4484-1CFR-84688

LEAHI-DIALIN-LDT-4484-1: comment by Behrouz NematiPour "Please add a docstring for the function. inclu..."

Behrouz NematiPour — Thu, 25 Jun 2026 17:18:50 -0700

Behrouz NematiPour commented on LEAHI-DIALIN-LDT-4484-1

Please add a docstring for the function.
including the intention and parameters with their intentions.

LEAHI-DIALIN-LDT-4484-1: comment by Behrouz NematiPour "Same for CanChannels. The Channels we are refe..."

Behrouz NematiPour — Thu, 25 Jun 2026 17:16:40 -0700

Behrouz NematiPour commented on LEAHI-DIALIN-LDT-4484-1

Same for CanChannels.
The Channels we are referring to here are Leahi's or Denali's.
Channels mainly have no meaning beyond their priorities when a collision occurs.

LEAHI-DIALIN-LDT-4484-1: comment by Behrouz NematiPour "I recommend DenaliMessage or LeahiMessage, as C..."

Behrouz NematiPour — Thu, 25 Jun 2026 16:00:32 -0700

Behrouz NematiPour commented on LEAHI-DIALIN-LDT-4484-1

I recommend DenaliMessage or LeahiMessage, as CanMessage is generic, whereas Leahi/Denali indicate that the protocol is also implemented in the message we are sending.
I'm not sure why the name was changed, as it is a lot of change.
Also, there is no CAN Message.
There is a CAN Frame and a Leahi/Denali Message.

leahi-dialin (LDT-3735-non-volatile-memory): updated process functions debug part

Zoltan Miskolci — Wed, 24 Jun 2026 16:20:01 -0700

Zoltan Miskolci committed c41ad46 on branch LDT-3735-non-volatile-memory in leahi-dialin

updated process functions debug part

· /leahi_dialin/utils/abstract_classes.py

(-11, +16)

| History

| Source

| Diff

leahi-dialin (LDT-3735-non-volatile-memory): - Updated institutional record and system record handler

Zoltan Miskolci — Wed, 24 Jun 2026 16:08:28 -0700

Zoltan Miskolci committed c8bafcb on branch LDT-3735-non-volatile-memory in leahi-dialin

- Updated institutional record and system record handler

· /leahi_dialin/dd/modules/records.py	(-22, +22)	\| History	\| Source	\| Diff
· /leahi_dialin/utils/abstract_classes.py	(-11, +13)	\| History	\| Source	\| Diff

leahi-dialin (LDT-3735-non-volatile-memory): updated institution records enum

Zoltan Miskolci — Tue, 23 Jun 2026 11:10:16 -0700

Zoltan Miskolci committed 41805cd on branch LDT-3735-non-volatile-memory in leahi-dialin

updated institution records enum

· /leahi_dialin/common/generic_defs.py	(-6, +8)	\| History	\| Source	\| Diff
· /leahi_dialin/utils/abstract_classes.py	(-3, +6)	\| History	\| Source	\| Diff

LEAHI-DIALIN-LDT-4484-1: comment by Zoltan Miskolci "updated"

Zoltan Miskolci — Tue, 23 Jun 2026 10:40:49 -0700

Zoltan Miskolci replied to Raghu Kallala in LEAHI-DIALIN-LDT-4484-1

updated

LEAHI-DIALIN-LDT-4484-1: comment by Raghu Kallala "Remove extra spaces before comment"

Raghu Kallala — Tue, 23 Jun 2026 10:31:47 -0700

Raghu Kallala commented on LEAHI-DIALIN-LDT-4484-1

Remove extra spaces before comment

leahi-dialin (LDT-3735-non-volatile-memory): added conversion for part and serial number

Zoltan Miskolci — Tue, 23 Jun 2026 10:18:53 -0700

Zoltan Miskolci committed ee914de on branch LDT-3735-non-volatile-memory in leahi-dialin

added conversion for part and serial number

· /leahi_dialin/dd/modules/records.py	(-6, +4)	\| History	\| Source	\| Diff
· /leahi_dialin/utils/conversions.py	(-0, +10)	\| History	\| Source	\| Diff

leahi-dialin (LDT-3735-non-volatile-memory): fixing copy paste issue

Zoltan Miskolci — Tue, 23 Jun 2026 09:44:50 -0700

Zoltan Miskolci committed 0593f17 on branch LDT-3735-non-volatile-memory in leahi-dialin

fixing copy paste issue

· /leahi_dialin/dd/modules/records.py	(-2, +2)	\| History	\| Source	\| Diff
· /leahi_dialin/utils/abstract_classes.py	(-1, +1)	\| History	\| Source	\| Diff

leahi-dialin (LDT-3735-non-volatile-memory): adding TD records

Zoltan Miskolci — Tue, 23 Jun 2026 09:27:15 -0700

Zoltan Miskolci committed 0bc2d39 on branch LDT-3735-non-volatile-memory in leahi-dialin

adding TD records

· /leahi_dialin/common/generic_defs.py	(-6, +8)	\| History	\| Source	\| Diff
· /leahi_dialin/common/msg_ids.py	(-12, +27)	\| History	\| Source	\| Diff
· /leahi_dialin/dd/modules/records.py	(-59, +14)	\| History	\| Source	\| Diff
· /leahi_dialin/td/modules/records.py	(-25, +1)	\| History	\| Source	\| Diff
· /leahi_dialin/utils/abstract_classes.py	(-10, +45)	\| History	\| Source	\| Diff

leahi-dialin (LDT-3735-non-volatile-memory): -Added TD records skeleton - Moved CRC calculation to base class

Zoltan Miskolci — Mon, 22 Jun 2026 16:21:25 -0700

Zoltan Miskolci committed 5ebadf2 on branch LDT-3735-non-volatile-memory in leahi-dialin

-Added TD records skeleton - Moved CRC calculation to base class

· /leahi_dialin/dd/modules/records.py	(-61, +12)	\| History	\| Source	\| Diff
· /leahi_dialin/td/modules/records.py	(-0, +986)	\| History	\| Source
· /leahi_dialin/td/treatment_delivery.py	(-0, +2)	\| History	\| Source	\| Diff
· /leahi_dialin/utils/abstract_classes.py	(-0, +56)	\| History	\| Source	\| Diff

leahi-dialin (LDT-4160-alarm_table): bool handling

Zoltan Miskolci — Mon, 22 Jun 2026 14:29:07 -0700

Zoltan Miskolci committed 412ee5c on branch LDT-4160-alarm_table in leahi-dialin

bool handling

· /leahi_dialin/td/modules/alarms.py	(-17, +17)	\| History	\| Source	\| Diff
· /leahi_dialin/utils/abstract_classes.py	(-2, +2)	\| History	\| Source	\| Diff

leahi-dialin (LDT-3735-non-volatile-memory): - Updated msg ids - Updated record handlers

Zoltan Miskolci — Tue, 16 Jun 2026 17:12:13 -0700

Zoltan Miskolci committed 87ffed5 on branch LDT-3735-non-volatile-memory in leahi-dialin

- Updated msg ids - Updated record handlers

· /leahi_dialin/common/msg_ids.py	(-14, +36)	\| History	\| Source	\| Diff
· /leahi_dialin/dd/modules/records.py	(-65, +302)	\| History	\| Source	\| Diff
· /leahi_dialin/utils/abstract_classes.py	(-0, +9)	\| History	\| Source	\| Diff

LEAHI-DIALIN-LDT-4721-1: closed by Zoltan Miskolci

Zoltan Miskolci — Tue, 16 Jun 2026 09:53:10 -0700

Zoltan Miskolci Closed LEAHI-DIALIN-LDT-4721-1

LEAHI-DIALIN-LDT-4612-1: closed by Vendor - TEL - Sameer Poyil

Vendor - TEL - Sameer Poyil — Tue, 16 Jun 2026 07:40:58 -0700

Vendor - TEL - Sameer Poyil Closed LEAHI-DIALIN-LDT-4612-1

leahi-dialin (LDT-4733-request-add-variables): Merge branch 'LDT-4721-extra_param' into staging

Zoltan Miskolci — Mon, 15 Jun 2026 16:37:30 -0700

Zoltan Miskolci committed 78b7d4b on branch LDT-3735-non-volatile-memory, LDT-4003-hdf-fw-implementation-4-4 and 13 more in leahi-dialin

Merge branch 'LDT-4721-extra_param' into staging

· /leahi_dialin/dd/modules/drybicart.py	(-2, +2)	\| History	\| Source	\| Diff
· /leahi_dialin/utils/abstract_classes.py	(-4, +9)	\| History	\| Source	\| Diff

leahi-dialin (develop): Merge branch 'LDT-4721-extra_param' into develop

Zoltan Miskolci — Mon, 15 Jun 2026 16:33:55 -0700

Zoltan Miskolci committed 8ef0478 on branch develop in leahi-dialin

Merge branch 'LDT-4721-extra_param' into develop

· /leahi_dialin/common/dd_defs.py	(-7, +8)	\| History	\| Source	\| Diff
· /leahi_dialin/common/msg_ids.py	(-1, +1)	\| History	\| Source	\| Diff
· /leahi_dialin/dd/modules/balancing_chamber.py	(-1, +2)	\| History	\| Source	\| Diff
· /leahi_dialin/dd/modules/blood_leak.py	(-1, +1)	\| History	\| Source	\| Diff
· /leahi_dialin/dd/modules/dialysate_pump.py	(-20, +20)	\| History	\| Source	\| Diff
· /leahi_dialin/dd/modules/drybicart.py	(-2, +2)	\| History	\| Source	\| Diff
· /leahi_dialin/dd/modules/events.py	(-1, +1)	\| History	\| Source	\| Diff
· /leahi_dialin/dd/modules/gen_dialysate.py	(-1, +1)	\| History	\| Source	\| Diff
· /leahi_dialin/dd/modules/temperature_sensors.py	(-0, +2)	\| History	\| Source	\| Diff
· /leahi_dialin/dd/modules/voltages.py	(-1, +10)	\| History	\| Source	\| Diff
· /leahi_dialin/fp/modules/boost_pump.py	(-1, +1)	\| History	\| Source	\| Diff
· /leahi_dialin/fp/modules/events.py	(-1, +1)	\| History	\| Source	\| Diff
· /leahi_dialin/fp/modules/ro_pump.py	(-1, +0)	\| History	\| Source	\| Diff
· /leahi_dialin/td/modules/events.py	(-1, +1)	\| History	\| Source	\| Diff
· /leahi_dialin/td/modules/pressure_sensors.py	(-6, +5)	\| History	\| Source	\| Diff
· /leahi_dialin/td/modules/syringe_pump.py	(-38, +1)	\| History	\| Source	\| Diff
· /leahi_dialin/utils/abstract_classes.py	(-4, +9)	\| History	\| Source	\| Diff

LEAHI-DIALIN-LDT-4612-1: reviewers finished

Mon, 15 Jun 2026 15:59:09 -0700

Zoltan Miskolci finished reviewing LEAHI-DIALIN-LDT-4612-1

LEAHI-DIALIN-LDT-4612_Dialysate Composition (Dry Bicarbonate) - FW Iteration - 4/1:

LEAHI-DIALIN-LDT-4160-1: started by Dara Navaei

Dara Navaei — Mon, 15 Jun 2026 15:32:29 -0700

Dara Navaei started review LEAHI-DIALIN-LDT-4160-1

LEAHI-DIALIN-LDT-4721-1: reviewers finished

Mon, 15 Jun 2026 14:35:40 -0700

Raghu Kallala and Michael Garthwaite finished reviewing LEAHI-DIALIN-LDT-4721-1

LEAHI-DIALIN-LDT-4721_Add extra parameter to start pregen request

leahi-dialin (LDT-4733-request-add-variables): Fixed non working modules

Zoltan Miskolci — Mon, 15 Jun 2026 13:50:54 -0700

Zoltan Miskolci committed 60a4cdf on branch LDT-3735-non-volatile-memory, LDT-4003-hdf-fw-implementation-4-4 and 13 more in leahi-dialin

Fixed non working modules

· /leahi_dialin/td/modules/pressure_sensors.py	(-6, +5)	\| History	\| Source	\| Diff
· /leahi_dialin/td/modules/syringe_pump.py	(-38, +1)	\| History	\| Source	\| Diff
· /leahi_dialin/utils/abstract_classes.py	(-2, +4)	\| History	\| Source	\| Diff

leahi-dialin (LDT-4733-request-add-variables): fixes

Zoltan Miskolci — Mon, 15 Jun 2026 11:02:07 -0700

Zoltan Miskolci committed f1b8b4e on branch LDT-3735-non-volatile-memory, LDT-4003-hdf-fw-implementation-4-4 and 13 more in leahi-dialin

fixes

· /leahi_dialin/dd/modules/balancing_chamber.py	(-1, +2)	\| History	\| Source	\| Diff
· /leahi_dialin/dd/modules/blood_leak.py	(-1, +1)	\| History	\| Source	\| Diff
· /leahi_dialin/dd/modules/drybicart.py	(-3, +3)	\| History	\| Source	\| Diff
· /leahi_dialin/dd/modules/gen_dialysate.py	(-1, +1)	\| History	\| Source	\| Diff
· /leahi_dialin/dd/modules/voltages.py	(-1, +10)	\| History	\| Source	\| Diff
· /leahi_dialin/fp/modules/boost_pump.py	(-1, +1)	\| History	\| Source	\| Diff
· /leahi_dialin/utils/abstract_classes.py	(-2, +5)	\| History	\| Source	\| Diff

LEAHI-DIALIN-LDT-4612-1: comment by Zoltan Miskolci "Rename to CanChannels"

Zoltan Miskolci — Thu, 11 Jun 2026 09:10:33 -0700

Zoltan Miskolci commented on LEAHI-DIALIN-LDT-4612-1

Rename to CanChannels

LEAHI-DIALIN-LDT-4612-1: comment by Zoltan Miskolci "Rename to CanChannels"

Zoltan Miskolci — Thu, 11 Jun 2026 09:10:39 -0700

Zoltan Miskolci commented on LEAHI-DIALIN-LDT-4612-1

Rename to CanChannels

LEAHI-DIALIN-LDT-4612-1: comment by Vendor - TEL - Sameer Poyil "Let it be there. Because of this, i could not c..."

Vendor - TEL - Sameer Poyil — Mon, 15 Jun 2026 07:52:09 -0700

Vendor - TEL - Sameer Poyil replied to Zoltan Miskolci in LEAHI-DIALIN-LDT-4612-1

Let it be there. Because of this, i could not complete the 30+ data broadcast.

LEAHI-DIALIN-LDT-4612-1: comment by Vinayakam Mani "align the indent or remove blank space before ="

Vinayakam Mani — Fri, 12 Jun 2026 13:35:58 -0700

Vinayakam Mani commented on LEAHI-DIALIN-LDT-4612-1

align the indent or remove blank space before =

LEAHI-DIALIN-LDT-4612-1: comment by Vinayakam Mani "remove blank space before ="

Vinayakam Mani — Fri, 12 Jun 2026 13:33:27 -0700

Vinayakam Mani commented on LEAHI-DIALIN-LDT-4612-1

remove blank space before =