yeah its obsolete. This is an old branch that recently got synced with latest staging. It looks like the CR doesn't recognize the correct changes from staging. There should only be 1 file change ( conductivity sensors ).

· /leahi_dialin/common/__init__.py	(-4, +4)	| History	| Source	| Diff
· /leahi_dialin/fp/modules/valves.py	(-134, +98)	| History	| Source	| Diff
· /leahi_dialin/fp/modules/water_pumps.py	(-72, +40)	| History	| Source	| Diff
· /leahi_dialin/protocols/CAN.py	(-16, +0)	| History	| Source	| Diff
· /leahi_dialin/protocols/__init__.py	(-1, +1)	| History	| Source	| Diff
· /leahi_dialin/utils/__init__.py	(-1, +1)	| History	| Source	| Diff
· /tests/data_capture_helpers/fp_helpers.py	(-5, +8)	| History	| Source	| Diff

]]> Wed, 04 Mar 2026 12:46:36 -0800 https://devapps.diality.us/cru/LEAHI-DIALIN-LDT-2655-1 https://devapps.diality.us/cru/LEAHI-DIALIN-LDT-2655-1 Dara Navaei joined LEAHI-DIALIN-LDT-2655-1 LEAHI-DIALIN-LDT-2655_Cannot override conductivity sensor temperature from the conductivity module ]]> Wed, 04 Mar 2026 12:46:36 -0800 https://devapps.diality.us/cru/LEAHI-DIALIN-LDT-2655-1 https://devapps.diality.us/cru/LEAHI-DIALIN-LDT-2655-1 Dara Navaei removed Michael Garthwaite from LEAHI-DIALIN-LDT-2655-1 LEAHI-DIALIN-LDT-2655_Cannot override conductivity sensor temperature from the conductivity module ]]> Mon, 09 Feb 2026 10:34:41 -0800 Zoltan Miskolci https://devapps.diality.us/cru/LEAHI-DIALIN-LDT-3350-1 https://devapps.diality.us/cru/LEAHI-DIALIN-LDT-3350-1 Zoltan Miskolci Closed LEAHI-DIALIN-LDT-3350-1 ]]> Sat, 07 Feb 2026 16:46:15 -0800 https://devapps.diality.us/cru/LEAHI-DIALIN-LDT-3350-1 https://devapps.diality.us/cru/LEAHI-DIALIN-LDT-3350-1 Dara Navaei finished reviewing LEAHI-DIALIN-LDT-3350-1 LEAHI-DIALIN-LDT-3350_[Leahi-Dialin] Add from_str function to the enums ]]> Fri, 06 Feb 2026 09:23:57 -0800 Zoltan Miskolci https://devapps.diality.us/cru/LEAHI-DIALIN-LDT-3350-1/#c27081 https://devapps.diality.us/cru/LEAHI-DIALIN-LDT-3350-1/#c27081 Zoltan Miskolci replied to Dara Navaei in LEAHI-DIALIN-LDT-3350-1

We agreed to change back the enums into the static variation.
Why would that cover a class that has been implemented to mask the enums from direct access, so if they need to be changed to dynamic or renamed or anything, the other repositories that are using them through this class won't be affected or need any update.

Did we not decide to revert all the changes back and the redesign the whole concept again?

· /leahi_dialin/common/alarm_priorities.py	(-0, +1)	| History	| Source	| Diff
· /leahi_dialin/common/msg_defs.py	(-0, +1)	| History	| Source	| Diff
· /leahi_dialin/common/msg_ids.py	(-0, +1)	| History	| Source	| Diff
· /leahi_dialin/common/test_config_defs.py	(-0, +2)	| History	| Source	| Diff
· /leahi_dialin/dd/modules/blood_leak.py	(-0, +1)	| History	| Source	| Diff
· /leahi_dialin/td/modules/alarms.py	(-0, +1)	| History	| Source	| Diff
· /leahi_dialin/utils/base.py	(-6, +4)	| History	| Source	| Diff
· /leahi_dialin/utils/nv_ops_utils.py	(-1, +2)	| History	| Source	| Diff

]]> Wed, 04 Feb 2026 13:32:52 -0800 Zoltan Miskolci https://devapps.diality.us/changelog/leahi-dialin?cs=3cb0fa0dd63440b9368f2315abd2d8344c6131f2 https://devapps.diality.us/changelog/leahi-dialin?cs=3cb0fa0dd63440b9368f2315abd2d8344c6131f2 Zoltan Miskolci committed 3cb0fa0 on branch develop in leahi-dialin Removed ignore from dialinenum

· /leahi_dialin/utils/base.py

(-1, +1)

| History

| Source

| Diff

]]> Tue, 03 Feb 2026 15:55:46 -0800 Behrouz NematiPour https://devapps.diality.us/cru/LEAHI-DIALIN-LDT-3350-1/#c26993 https://devapps.diality.us/cru/LEAHI-DIALIN-LDT-3350-1/#c26993 Behrouz NematiPour replied to Behrouz NematiPour in LEAHI-DIALIN-LDT-3350-1

Look in the td_defs.py for the same comment.

Look in the td_defs.py for the same comment.

Look in the td_defs.py for the same comment.

Look in the td_defs.py for the same comment.

This design is incorrect,
For common codes, a proxy or a wrapper class should have been implemented.
We will keep it for now to unblock the rest of the team.

This is incorrect.
We should not create many objects for all the Enum classes in an API, and we should not use memory that may not even be in use.
We will keep it for now to unblock the rest of the team.

When building locally without all the parameters the generated name throws an error during python pip install.
So this ensures that if no parameter is added, it uses the default name which is compatible with pip install.
The " -+. " sequence is throwing an error.

removed commented out line

It's a class containing all the enums of the def file.
Yes we need them as many other Framework and huge amount of code are using them.

Obviously not.
You were reminding me about backwards compatibility. This variable and class ensures that even with this major refactor to the enum structure, the current codebase remains working.

Yes, they are aliases that are used for example in Dialin's temperature sensor module to decide which msg id to use for the override.
Updating an alias's value when adding new entries to the enum is easier then changing the last or first sensor type across Dialin modules, which could be forgotten or missed.

DialinEnum from_str function using it to match a strung to an enum member. Converting the string to enum for cleaner code in test cases.

Yes

Not sure about this change. This script is used during the automated builds. Do you use this script anywhere else?

Treatment Params have been removed from firmware.

Are these part of FPTemperatureSensorName class?

same

same