leahi-testsuites

Clone Tools

Stats

Commits this week: 2
Total Committers: 5
Last Commit: 05:44
Commits this week: 2

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Friday 13 Feb
11:41 am

Behrouz NematiPour

if it is not in the if block add an empty line.

if it is not in the if block add an empty line.

11:40 am

Behrouz NematiPour

If all timeouts are set to 3000, please set it as the default for the function parameter to avoid passing it everywhere.

If all timeouts are set to 3000, please set it as the default for the function parameter to avoid passing it everywhere.

11:38 am

Behrouz NematiPour

should this file be removed?

should this file be removed?

11:36 am

Behrouz NematiPour

That was a great idea to make it a function. *I would also use different (4) parameters and give them a relevant, short name, so users in the code can set them as false or true without knowing th...

That was a great idea to make it a function.

  • I would also use different (4) parameters and give them a relevant, short name, so users in the code can set them as false or true without knowing the -q meaning.
  • It also gives the application flexibility to change the CLI switches without affecting the rest of the test, and only this function would need to be changed.


How should be developed:

def aut(vDisableTimeout, vDisableCheckIn, vDisableAcknow, vDisableSDFail)


How users use it:

aut(vDisableTimeout = True)

FYI the entire CLI switches:

* Options:
 *   -h, --help                           Displays help on commandline options.
 *   --help-all                           Displays help including Qt specific
 *                                        options.
 *   -v, --version                        Displays version information.
 *   -c, --canOut                         Show the Can Frame Output
 *   -m, --msgOut                         Show the Message Output
 *   -l, --logOut                         Show the Logs Output
 *   -0, --enable-keep-awake              Enable send low priority, empty message
 *                                        on the CANBus just to keep UI board CAN
 *                                        driver awake
 *   -i, --fake-interval <interval>       Test fake message interval(ms)
 *   -f, --fake-message <data>            Test fake message data
 *                                        will use default sequenced long fake
 *                                        message if set to 00(default)
 *                                        will used only if correct integer value
 *                                        assigned for interval option
 *   -b, --fake-message-seq-at-begin      Test fake message sequence at the
 *                                        beginning of the frame
 *   -u, --disable-unhandled-report       Disable unhandled messages report as an
 *                                        error in the log
 *   -d, --disable-dialin-unhandled       Disable the Dialin messages logged as
 *                                        unhandled
 *   -q, --disable-timeout                Disables communication timeout
 *   -a, --disable-alarm-no-minimize      Disables alarm no minimize
 *   -S, --disable-sd-card-fail-log-stop  disable-sd-card-fail-log-stop
 *   -C, --disable-cloudsync-fail-stop    disable-cloudsync-fail-stop
 *   -k, --disable-check-in-log           Disables Check-In Log
 *   -K, --disable-acknow-log             Disables Acknowledgment Log
 *   -D, --enable-dry-demo                Enables Dry-Demo Mode
 *   -A, --active-can-bus <CANBus>        Sets the Active CANBus [Shall start with
 *                                        'can' or 'vcan]
 *   -E, --enable-manufacturing           Enables the manufacturing mode to
 *                                        configure the system for the first time.
 *   -R, --use-root-home                  In case the application is not in
 *                                        Manufacturing Setup but needs to use root
 *                                        home folder for configurations.
 *   -U, --enable-update-mode             Enables the update mode to update only
 *                                        necessary files during the update and
 *                                        keep the rest.
 *   -x, --use-log-long-name              Use the log long file name format
 *                                        <date>_<time>_<serial>_<mode>
 *   -y, --use-log-cloud-upload           Use the log cloud upload
 *   -z, --use-log-compression            Use the log compression
 *   -L, --use-log-unhandled-only         Use the unhandled messages only to log
11:22 am

Behrouz NematiPour

I don't think anything other than the container, and [ id or objectName ] should be in the object definition dictionary. If, as an example, the passwordCharacter is changed to #, the object cannot ...

I don't think anything other than the container, and [ id or objectName ] should be in the object definition dictionary.
If, as an example, the passwordCharacter is changed to #, the object cannot be found. same for echoMode.

11:18 am

Behrouz NematiPour

Isn't it better to name it like "findAllChildrenById"? Children instead of Objects? *And why do we add the parent, too? *That could be because you are using a recursive function, and I am not s...
  • Isn't it better to name it like "findAllChildrenById"? Children instead of Objects?
  • And why do we add the parent, too?
    • That could be because you are using a recursive function, and I am not sure that is necessary.
  • Any object in QML has "id", do we need to check that, since it is not like the "objectName"
  • How could all id of the children be the same since there is no RegEx here?
10:53 am

Behrouz NematiPour

translatable. I won't repeat the same comment, but I see the same pattern elsewhere.

translatable.
I won't repeat the same comment, but I see the same pattern elsewhere.

10:51 am

Behrouz NematiPour

Multiple lines of the texts here are translatable. I think we need to create a separate Python file for text-only content, so we can load different versions of it depending on the language we set b...

Multiple lines of the texts here are translatable.
I think we need to create a separate Python file for text-only content, so we can load different versions of it depending on the language we set before each test.
Additionally, another idea is to separate any text verification into a translation test case for the entire application using the Python file I mentioned above.
Nicholas Ramirez What are your thoughts on that?

Tuesday 10 Feb
12:00 am

Vendor - TEL - Divya Sree Nidamamidi

Removed the duplicate objects

Removed the duplicate objects

Monday 09 Feb
6:00 am

Vendor - TEL - Shivaprasad Basavaraju

updated to utility.aut("-q")

updated to utility.aut("-q")

5:58 am

Vendor - TEL - Shivaprasad Basavaraju

updated as per comment

updated as per comment

5:57 am

Vendor - TEL - Shivaprasad Basavaraju

updated to utility.aut("-q")

updated to utility.aut("-q")

5:54 am

Vendor - TEL - Shivaprasad Basavaraju

updated to utility.aut("-q")

updated to utility.aut("-q")

5:53 am

Vendor - TEL - Shivaprasad Basavaraju

updated to utility.aut("-q")

updated to utility.aut("-q")

5:53 am

Vendor - TEL - Shivaprasad Basavaraju

updated to utility.aut("-q")

updated to utility.aut("-q")

5:53 am

Vendor - TEL - Shivaprasad Basavaraju

updated to utility.aut("-q")

updated to utility.aut("-q")

5:52 am

Vendor - TEL - Shivaprasad Basavaraju

updated as per comment

updated as per comment

Friday 06 Feb
2:00 pm

Nicholas Ramirez

these look like duplicates of already existing object. This CR is for End of treatment and shouldnt have any pre treatment names under this section

these look like duplicates of already existing object.

This CR is for End of treatment and shouldnt have any pre treatment names under this section

1:52 pm

Nicholas Ramirez

removed commented out code

removed commented out code

Thursday 05 Feb
4:43 pm

Nicholas Ramirez

3:25 pm

Behrouz NematiPour

3:23 pm

Behrouz NematiPour

ok them be careful to always use it as: import squish NOT the following as has been stated: from squish import *

ok them be careful to always use it as:

import squish

NOT the following as has been stated:

from squish import  *
10:25 am

Nicholas Ramirez

i believe it is necessary for a custom module.. https://doc.qt.io/squish/python-notes.html#squish-funcs-in-py-modules

i believe it is necessary for a custom module.. https://doc.qt.io/squish/python-notes.html#squish-funcs-in-py-modules

10:20 am

Vendor - TEL - Divya Sree Nidamamidi

Removed the from squish import * line and keeping the import squish in utility.py and navigation.py files

Removed the from squish import * line and keeping the import squish in utility.py and navigation.py files

10:19 am

Vendor - TEL - Divya Sree Nidamamidi

without squish import in utility file scripts will fail so added import squish line in utility.py and navigation.py file

without squish import in utility file scripts will fail so added import squish line in utility.py and navigation.py file

9:41 am

Behrouz NematiPour

Please remove squish import everywhere. It is also duplicate here.

Please remove squish import everywhere.
It is also duplicate here.

Wednesday 04 Feb
2:33 pm

Nicholas Ramirez

remove argument and only pass in arguments. name is always "leahi" so set it in here

remove argument and only pass in arguments.
name is always "leahi" so set it in here

2:32 pm

Nicholas Ramirez

update to utility.aut()

update to utility.aut()

2:32 pm

Nicholas Ramirez

update to utility.aut("-E")

update to utility.aut("-E")

2:31 pm

Nicholas Ramirez

update to utility.aut()

update to utility.aut()