Clone Tools
  • last updated a few minutes ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Uploaded the report

Uploaded the report

LDT-2743 Service - SW - 02 - Service - Q&R - 15: SIT - Software Integration Tests - Squish Qt

  1. … 1 more file in changeset.
try catch is avoided as per suggestion

try catch is avoided as per suggestion

try catch is removed

try catch is removed

Moved all the constants to config.py file

Moved all the constants to config.py file

Removed the line

Removed the line

Method name is changed and added docstring and method is available in navigation.py file

Method name is changed and added docstring and method is available in navigation.py file

Method is moved to navigation.py file

Method is moved to navigation.py file

this function also contains Wi-Fi Screen Parameters and Navigate to Wi-Fi Screen from Device Settings is not required in others test scripts

this function also contains Wi-Fi Screen Parameters and Navigate to Wi-Fi Screen from Device Settings is not required in others test scripts

updated

updated

code is aligned

code is aligned

All strings are placed in config.py

All strings are placed in config.py

All strings are placed in config.py

All strings are placed in config.py

LDT -2973 Heparin - SW - 02 - Q&R - 15: SIT - Software Integration Tests - Squish Qt

  1. … 2 more files in changeset.
Merge remote-tracking branch 'origin/staging' into feature/LDT-2971-Heparin

  1. … 1 more file in changeset.
LDT -2973 Heparin - SW - 02 - Q&R - 15: SIT - Software Integration Tests - Squish Qt

  1. … 1 more file in changeset.
move this to navigation.py?

move this to navigation.py?

Please upload report to https://diality.atlassian.net/browse/LDT-2743

Please upload report to https://diality.atlassian.net/browse/LDT-2743

Please add a docstring for this function. And the naming seems like to be better like: navigation_pageIndicator_step(vStep_name)

Please add a docstring for this function.
And the naming seems like to be better like:

navigation_pageIndicator_step(vStep_name)
Same (translation)

Same (translation)

The translatable strings shall be defined in a global space. Generally, please make sure this is handled everywhere.

The translatable strings shall be defined in a global space.
Generally, please make sure this is handled everywhere.

should this method be moved to navigation.py?

should this method be moved to navigation.py?

remove commented out line

remove commented out line

please move these into the config.py to be consistent with other test cases

please move these into the config.py to be consistent with other test cases

When appropriate, align the code.

When appropriate, align the code.

As a general note, avoid try-catch. Your code should be prepared for exceptions, not to be surprised.

As a general note, avoid try-catch.
Your code should be prepared for exceptions, not to be surprised.

Why do you need try-catch?

Why do you need try-catch?

Why do you need this? Is any editor used other than Squish? We need to make sure it is running in the Squish IDE and with its tools on the build server. Preferably, remove it to be consistent.

Why do you need this?
Is any editor used other than Squish?
We need to make sure it is running in the Squish IDE and with its tools on the build server.
Preferably, remove it to be consistent.

Added the line

Added the line

Added the line

Added the line