td-firmware

Clone Tools

Stats

Commits this week: 19
Total Committers: 13
Last Commit: 11:56
Commits this week: 19

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Today
4 hrs ago

Zoltan Miskolci , Vendor - TEL - Jashwant Gantyada and Sean Nash

9 hrs ago

Raghu Kallala

Had that question. Thanks Changed to else block

Had that question. Thanks
Changed to else block

9 hrs ago

Raghu Kallala

Updated

Updated

9 hrs ago

Raghu Kallala

This will be gone once we have institutional records, do you still want me to move it to a separate func?

This will be gone once we have institutional records, do you still want me to move it to a separate func?

9 hrs ago

Raghu Kallala

Fixed

Fixed

Wednesday 18 Feb
10:09 pm

Sean Nash

Can we uncomment these and send msg?

Can we uncomment these and send msg?

10:08 pm

Sean Nash

Can we uncomment this and send the limits to the UI?

Can we uncomment this and send the limits to the UI?

10:06 pm

Sean Nash

Should we cast these to (S32)?

Should we cast these to (S32)?

10:04 pm

Sean Nash

These 2 last values have already been used above. Change to 154 and 155.

These 2 last values have already been used above. Change to 154 and 155.

10:02 pm

Sean Nash

Can this stuff down here be done in a separate function that is called here? This function is too big.

Can this stuff down here be done in a separate function that is called here? This function is too big.

10:02 pm

Sean Nash

Should this just be an "else" to above condition?

Should this just be an "else" to above condition?

9:58 pm

Sean Nash

When do you plan on removing this?

When do you plan on removing this?

9:56 pm

Sean Nash

Just a heads up that all message handling functions in Leahi have the same prototype - just different function names (i.e. BOOL funcName( MESSAGE_T *message)) and that includes all Dialin command m...

Just a heads up that all message handling functions in Leahi have the same prototype - just different function names (i.e. BOOL funcName( MESSAGE_T *message)) and that includes all Dialin command message handlers like these.

9:48 pm

Sean Nash

This param has been renamed to HEPARIN_STOP_TIME which is a couple rows below so we don't need to add this.

This param has been renamed to HEPARIN_STOP_TIME which is a couple rows below so we don't need to add this.

9:47 pm

Sean Nash

We will not have this saline bolus state in Leahi.

We will not have this saline bolus state in Leahi.

9:45 pm

Sean Nash

This alarm does not belong here. Put it back where it was before. In the next table below, the alarms are sorted by rank. But this property table is sorted by alarm ID #.

This alarm does not belong here. Put it back where it was before.
In the next table below, the alarms are sorted by rank. But this property table is sorted by alarm ID #.

9:43 pm

Sean Nash

Why did you move it. The alarm is #30 so it should stay here where you had it before.

Why did you move it. The alarm is #30 so it should stay here where you had it before.

11:32 am

Vendor - TEL - Arpita Srivastava

This code review contains known issues, and it is not yet ready for a detailed review.

This code review contains known issues, and it is not yet ready for a detailed review.

Tuesday 17 Feb
1:32 pm

Raghu Kallala

fixed

fixed

1:32 pm

Raghu Kallala

reworded

reworded

1:32 pm

Raghu Kallala

Updated

Updated

11:48 am

Vendor - TEL - Varshini Nagabooshanam

Based on the Denali properties, I have written the following.

Based on the Denali properties, I have written the following.

11:06 am

Raghu Kallala

replace with else block

replace with else block

10:53 am

Raghu Kallala

convert to switch case

convert to switch case

10:45 am

Raghu Kallala

set treatment modality.

set treatment modality.

10:07 am

Sean Nash

Priority doesn't look right. Should be High I think. Check properties from Denali project.

Priority doesn't look right. Should be High I think. Check properties from Denali project.

10:00 am

Dara Navaei

LEAHI-TD-FIRMWARE-LDT-3539_Air Infusion - TD
LEAHI-TD-FIRMWARE-LDT-3539_Air Infusion - TD
10:00 am

Vendor - TEL - Sameer Poyil

/// -is this does not recognize by doxygen ?

/// -is this does not recognize by doxygen ?

9:53 am

Vendor - TEL - Sameer Poyil

Friday 13 Feb
4:04 pm

Sean Nash