td-firmware

Clone Tools
  • last updated a few seconds ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
necessary?

necessary?

use response.x for these.

use response.x for these.

use response.duration.

use response.duration.

Already set this above.

Already set this above.

I don't see you changing the GoalL. Recommend you delete that variable and use local presUFVolumeMl instead.

I don't see you changing the GoalL. Recommend you delete that variable and use local presUFVolumeMl instead.

no need to respond.

no need to respond.

don't need response to a response.

don't need response to a response.

don't need this if statement either and don't need what's inside the if.

don't need this if statement either and don't need what's inside the if.

Don't need this if statement or flag.

Don't need this if statement or flag.

use separate time than stability (even if same right now).

use separate time than stability (even if same right now).

Move to transition function and remove this if statement.

Move to transition function and remove this if statement.

do 2 data with the p1 and p2 pressures.

do 2 data with the p1 and p2 pressures.

Remove extra blank line.

Remove extra blank line.

Remove if statement. Always set valve to pos A.

Remove if statement. Always set valve to pos A.

Want to stop air pump, not end air trap control.

Want to stop air pump, not end air trap control.

Don't want to start air trap control. Want to turn on the air pump at max power (100.0%)

Don't want to start air trap control. Want to turn on the air pump at max power (100.0%)

Put this stuff in transition function for this state. Remove venousSetupStateEntered flag.

Put this stuff in transition function for this state. Remove venousSetupStateEntered flag.

change flag to tubeSetLeakChecksStarted

change flag to tubeSetLeakChecksStarted

Shouldn't this be the pressure sensor normal setup state?

Shouldn't this be the pressure sensor normal setup state?

initialize start time for next state. Should we set a flag indicating we completed the tube set checks?

initialize start time for next state. Should we set a flag indicating we completed the tube set checks?

Call your transition function for new state here.

Call your transition function for new state here.

state removed.

state removed.

Don't need this flag or this if statement.

Don't need this flag or this if statement.

Think about including data.

Think about including data.

Needed?

Needed?

Still need cmd to barcode reader to scan.

Still need cmd to barcode reader to scan.

Not a CAN msg to UI. It's a command to barcode reader via fpga. Not implement yet, so TODO comment.

Not a CAN msg to UI. It's a command to barcode reader via fpga. Not implement yet, so TODO comment.

remove if statement. No occlusion sensor

remove if statement. No occlusion sensor

DrySelfTests

DrySelfTests

move to a private publish function.

move to a private publish function.