td-firmware

Clone Tools

Stats

Commits this week: 50
Total Committers: 15
Last Commit: 05 May
Commits this week: 50

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few minutes ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Tuesday 05 May
6:54 pm

Sean Nash

I don't see you changing the GoalL. Recommend you use local presUFVolumeMl instead.

I don't see you changing the GoalL. Recommend you use local presUFVolumeMl instead.

6:52 pm

Sean Nash

2 lines above/below banner

2 lines above/below banner

6:48 pm

Sean Nash

remove blank line.

remove blank line.

6:25 pm

Sean Nash

use response.x for these.

use response.x for these.

6:25 pm

Sean Nash

use response.duration.

use response.duration.

6:24 pm

Sean Nash

Already set this above.

Already set this above.

4:37 pm

Vendor - TEL - Praneeth Bunne

LDT-1886: Addressed code review comments

Options
    • -21
    • +21
    /firmware/App/Modes/ModePostTreat.c
    • -29
    • +29
    /firmware/App/Modes/ModePreTreat.c
    • -1
    • +1
    /firmware/App/Modes/ModePreTreat.h
    • -9
    • +11
    /firmware/App/Services/AlarmMgmtSWFaults.h
    • -4
    • +2
    /firmware/App/Services/Messaging.c
    • -21
    • +42
    /firmware/App/Services/StateServices/TubeSetAutoEject.c
    • -2
    • +2
    /firmware/App/Services/StateServices/TubeSetAutoEject.h
    • -17
    • +32
    /firmware/App/Services/StateServices/TubeSetInstall.c
3:58 pm

Sean Nash

no need to respond.

no need to respond.

3:58 pm

Sean Nash

don't need response to a response.

don't need response to a response.

3:54 pm

Sean Nash

don't need this if statement either and don't need what's inside the if.

don't need this if statement either and don't need what's inside the if.

3:49 pm

Sean Nash

Don't need this if statement or flag.

Don't need this if statement or flag.

3:46 pm

Sean Nash

use separate time than stability (even if same right now).

use separate time than stability (even if same right now).

3:42 pm

Sean Nash

Move to transition function and remove this if statement.

Move to transition function and remove this if statement.

3:40 pm

Sean Nash

do 2 data with the p1 and p2 pressures.

do 2 data with the p1 and p2 pressures.

3:36 pm

Sean Nash

Remove extra blank line.

Remove extra blank line.

3:35 pm

Sean Nash

Remove if statement. Always set valve to pos A.

Remove if statement. Always set valve to pos A.

3:32 pm

Sean Nash

Want to stop air pump, not end air trap control.

Want to stop air pump, not end air trap control.

3:29 pm

Sean Nash

Don't want to start air trap control. Want to turn on the air pump at max power (100.0%)

Don't want to start air trap control. Want to turn on the air pump at max power (100.0%)

3:24 pm

Sean Nash

Put this stuff in transition function for this state. Remove venousSetupStateEntered flag.

Put this stuff in transition function for this state. Remove venousSetupStateEntered flag.

3:21 pm

Sean Nash

change flag to tubeSetLeakChecksStarted

change flag to tubeSetLeakChecksStarted

3:20 pm

Sean Nash

Shouldn't this be the pressure sensor normal setup state?

Shouldn't this be the pressure sensor normal setup state?

3:11 pm

Sean Nash

initialize start time for next state. Should we set a flag indicating we completed the tube set checks?

initialize start time for next state. Should we set a flag indicating we completed the tube set checks?

3:03 pm

Sean Nash

Call your transition function for new state here.

Call your transition function for new state here.

2:56 pm

Sean Nash

state removed.

state removed.

2:36 pm

Sean Nash

Don't need this flag or this if statement.

Don't need this flag or this if statement.

2:28 pm

Sean Nash

Think about including data.

Think about including data.

2:27 pm

Sean Nash

Needed?

Needed?

2:25 pm

Sean Nash

Still need cmd to barcode reader to scan.

Still need cmd to barcode reader to scan.

2:24 pm

Sean Nash

Not a CAN msg to UI. It's a command to barcode reader via fpga. Not implement yet, so TODO comment.

Not a CAN msg to UI. It's a command to barcode reader via fpga. Not implement yet, so TODO comment.

2:23 pm

Sean Nash

remove if statement. No occlusion sensor

remove if statement. No occlusion sensor