td-firmware

Clone Tools
  • last updated a few seconds ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Please typecast alarmID to resolve warning. ALARM_T alarm = getAlarmProperties( ( ALARM_ID_T )alarmID );

Please typecast alarmID to resolve warning.

ALARM_T alarm = getAlarmProperties( ( ALARM_ID_T )alarmID );

Fix merge conflict stuff here.

Fix merge conflict stuff here.

Fix merge conflict stuff here.

Fix merge conflict stuff here.

this function should not return anything.

this function should not return anything.

Please rename all the sPump registers as h10 for consistency.

Please rename all the sPump registers as h10 for consistency.

Add bpMeasurementReady, bpDriverError and pendingBPCommand to outputs.

Add bpMeasurementReady, bpDriverError and pendingBPCommand to outputs.

Where is testBatteryI2cStatusOverride (from BatteryDriver)?

Where is testBatteryI2cStatusOverride (from BatteryDriver)?

Add blank line before return statement.

Add blank line before return statement.

Fixed

Fixed

Added

Added

Fixed

Fixed

Fixed

Fixed

Fixed

Fixed

Not required here since we are initializing in the main

Not required here since we are initializing in the main

Yes removed

Yes removed

Fixed

Fixed

Fixed

Fixed

please add message id.

please add message id.

We should set all TD actuators here, not just blood pump.

We should set all TD actuators here, not just blood pump.

fpgaActuatorSetPoints is an output. Input is none.

fpgaActuatorSetPoints is an output.
Input is none.

please remove extra line

please remove extra line

Output is none

Output is none

Please add message id.

Please add message id.

Output is none

Output is none

Message id MSG_ID_OFF_BUTTON_PRESS_REQUEST looks wrong

Message id MSG_ID_OFF_BUTTON_PRESS_REQUEST looks wrong

I think we should accept this as long as we're in pre-tx: install state. User might confirm before auto-load finishes and that's ok.

I think we should accept this as long as we're in pre-tx: install state. User might confirm before auto-load finishes and that's ok.

Change "SetupConnection" to "SetupTubingSetConnection"

Change "SetupConnection" to "SetupTubingSetConnection"

Recommend changing "SETUP_CONNECTION" to "SETUP_TUBING_SET_CONNECTIONS" in these 2 msg ID names.

Recommend changing "SETUP_CONNECTION" to "SETUP_TUBING_SET_CONNECTIONS" in these 2 msg ID names.

Include "BPModule.h".

Include "BPModule.h".