LEAHI-TD-FIRMWARE-LDT-4072_Power Loss - FW Implementation - 2/3:

Activity

LEAHI-TD-FIRMWARE-LDT-4072-2 98

Keyboard shortcuts  
  • Summarize the review outcomes (optional)
     
    #permalink

    Details

    Warning: no files are visible, they have all been filtered.
    Participant Role Time Spent Comments Latest Comment
    Author & Moderator 22h 46m 2 Yes, these are low-priority alarms
    Reviewer - 0% reviewed 6m    
    Reviewer - Complete 4h 6m 57 Add comments to right.
    Reviewer - 0% reviewed 0m    
    Reviewer - 0% reviewed      
    Reviewer - 0% reviewed      
    Reviewer - 0% reviewed      
    Reviewer - 0% reviewed      
    Reviewer - 0% reviewed      
    Reviewer - 0% reviewed 5m    
    Reviewer - 0% reviewed      
    Reviewer - 96% reviewed 2h 36m 39 Why are we changing the rank of an existing alarm?
    Total   29h 42m 98  
    #permalink

    Objectives

    There are no specific objectives for this review.

    Branches in review

    #permalink

    Issues Raised From Comments

    Key Summary State Assignee
    #permalink

    General Comments

    There are no general comments on this review.
    /AlarmDefs.h Changed 7
    Open in IDE #permalink
    /MsgDefs.h Changed 2
    Open in IDE #permalink
    /firmware/App/Drivers/BatteryDriver.c Added 30
    Open in IDE #permalink
    /firmware/App/Drivers/BatteryDriver.h Added 13
    Open in IDE #permalink
    /firmware/App/Monitors/Battery.c Added 28
    Open in IDE #permalink
    /firmware/App/Monitors/Battery.h Added 3
    Open in IDE #permalink
    /firmware/App/Monitors/BatteryMonitor.c Deleted 8
    Open in IDE #permalink
    /firmware/App/Monitors/BatteryMonitor.h Deleted 3
    Open in IDE #permalink
    /firmware/App/Services/AlarmMgmtSWFaults.h Changed 1
    Open in IDE #permalink
    /firmware/App/Services/Messaging.c Changed 1
    Open in IDE #permalink
    /firmware/App/Tasks/TaskBG.c Changed 2
    Open in IDE #permalink
    /firmware/source/sys_main.c Changed
    Open in IDE #permalink

    Review updated: Reload | Ignore | Collapse

    You cannot reload the review while writing a comment.

    Log time