td-firmware

Clone Tools
  • last updated a few seconds ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
LDT-3126-blood-prime-td

    • -7
    • +58
    /firmware/App/Modes/StateTxBloodPrime.c
    • -0
    • +1
    /firmware/App/Modes/StateTxBloodPrime.h
in other files when they use string and/or math headers they had specified a comment describing which functions are used from the headers.

in other files when they use string and/or math headers they had specified a comment describing which functions are used from the headers.

I am resolving it, but according to Sean, if we have a state which is just asking it to go to the next state, we might not need the state to be declared.

I am resolving it, but according to Sean, if we have a state which is just asking it to go to the next state, we might not need the state to be declared.

it is used for publish function in the bottom of this function publishAirPumpData();

it is used for publish function in the bottom of this function publishAirPumpData();

fixed

fixed

Bamboo Commit: Updated TDCommon.h with build versions from Bamboo.

Merge branch LDT-1903-air-trap-level-control---td---0 into develop

LDT-1903 Air Trap feature updates

    • -5
    • +10
    /firmware/App/Controllers/AirTrap.c
LDT-2118-main-treatment-screen---td---vectorcast-tests-2-10-2026 : Added and modified test cases for Airpump.c

its a standard c library , for that no need to comment. using ceil() function

its a standard c library , for that no need to comment. using ceil() function

This is a default framework for all modules, even though there is nothing right now, left it as it is.

This is a default framework for all modules, even though there is nothing right now, left it as it is.

I don't see it being used in this state. Do we need this?

I don't see it being used in this state. Do we need this?

LDT-3126: Fixes to state machine.

    • -54
    • +58
    /firmware/App/Modes/StateTxBloodPrime.c
    • -2
    • +1
    /firmware/App/Modes/StateTxBloodPrime.h
I don't think we need a start state as this state is doing nothing. It is just transitioning to the next state. We can just directly start from the next state.

I don't think we need a start state as this state is doing nothing. It is just transitioning to the next state. We can just directly start from the next state.

I think we have to define macros for magic number.

I think we have to define macros for magic number.

Why NUM_OF_?

Why NUM_OF_?

Variable name suggests it is an action/cmd from UI. Comment suggests it is the number of actions. Which is it? And we should initialize in the init function - not here.

Variable name suggests it is an action/cmd from UI. Comment suggests it is the number of actions. Which is it?
And we should initialize in the init function - not here.

I think we have to include a comment specifying what function is being used from this file.

I think we have to include a comment specifying what function is being used from this file.

Is this really a timer counter? Looks like a flow rate.

Is this really a timer counter? Looks like a flow rate.

Updated

Updated

Added back

Added back

Updated

Updated

LDT-3126-blood-prime-td

    • -48
    • +93
    /firmware/App/Modes/StateTxBloodPrime.c
Bamboo Commit: Updated TDCommon.h with build versions from Bamboo.

Merge branch LDT-1903-air-trap-level-control---td---0 into develop

LDT-1903 Air Trap updates

Bamboo Commit: Updated TDCommon.h with build versions from Bamboo.