td-firmware

Clone Tools
  • last updated a few seconds ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
LDT-1903 Air Trap adjust the air trap lower delay start time after fill complete

Added

Added

Updated

Updated

LDT-3126-blood-prime-td

    • -1
    • +2
    /firmware/App/Modes/StateTxBloodPrime.c
Add a blank line after declarations.

Add a blank line after declarations.

What I meant was that we don't care which blood prime state we're in - what we care about is that we are in treatment mode and priming blood - otherwise this message doesn't make sense and we shoul...

What I meant was that we don't care which blood prime state we're in - what we care about is that we are in treatment mode and priming blood - otherwise this message doesn't make sense and we should reject it because we're not in the right state.
if ( ( MODE_TREA == getCurrentOperationMode() ) && ( TREATMENT_BLOOD_PRIME_STATE == getTreatmentState() ) )

LDT-3126-blood-prime-td

Removed

Removed

Added

Added

Yes, Updated

Yes, Updated

Replaced

Replaced

LDT-3126-blood-prime-td

    • -16
    • +16
    /firmware/App/Modes/StateTxBloodPrime.c
This should be invalid state (or something like that).

This should be invalid state (or something like that).

These are the correct min/max values, but we can't use literals like this. Our coding standard calls these "magic numbers". What we want to do is call getU32TreatmentParamLowerRangeLimit() and getU...

These are the correct min/max values, but we can't use literals like this. Our coding standard calls these "magic numbers". What we want to do is call getU32TreatmentParamLowerRangeLimit() and getU32TreatmentParamUpperRangeLimit() functions from the TxParams service.

I think what matters is that we are in Treatment: Blood Prime state. I think any of the 3 blood prime states is ok for this message.

I think what matters is that we are in Treatment: Blood Prime state. I think any of the 3 blood prime states is ok for this message.

I think result and accepted are essentially the same. We should just have one flag and only set to TRUE if everything is correct.

I think result and accepted are essentially the same. We should just have one flag and only set to TRUE if everything is correct.

Updated

Updated

LDT-3126-blood-prime-td

    • -11
    • +28
    /firmware/App/Modes/StateTxBloodPrime.c
Bamboo Commit: Updated TDCommon.h with build versions from Bamboo.

Merge branch LDT-1903-air-trap-level-control---td---0 into develop

    • -4
    • +11
    /firmware/App/Controllers/AirPump.c
Bamboo Commit: Updated TDCommon.h with build versions from Bamboo.

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

Merge branch LDT-1903-air-trap-level-control---td---0 into staging

Still need to range check the rate, reject if out of range, accept and assign if in range.

Still need to range check the rate, reject if out of range, accept and assign if in range.

I should have said "before test messages" instead of "first". But where you put them is fine so I will resolve.

I should have said "before test messages" instead of "first". But where you put them is fine so I will resolve.

Bamboo Commit: Updated TDCommon.h with build versions from Bamboo.

Merge branch 'develop' of bitbucket.org:diality-cloud/td-firmware into develop

Merge branch 'LDT-1394-blood-flow-rate-h4-rotor-count' into develop