td-firmware

Clone Tools
  • last updated a few minutes ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
LEAHI-TD-FIRMWARE-LDT-2749_Ability to Enable Air Bubble Alarm in Standby Mode
LEAHI-TD-FIRMWARE-LDT-2749_Ability to Enable Air Bubble Alarm in Standby Mode
Updated

Updated

Added

Added

reverted back

reverted back

This code is removed and not required

This code is removed and not required

If you change this line to "if ( ++airPumpStallCounter >= AIR_PUMP_STALL_PERSISTENCE )", you can remove the if statement above.

If you change this line to "if ( ++airPumpStallCounter >= AIR_PUMP_STALL_PERSISTENCE )", you can remove the if statement above.

I was thinking that comment should go above the first if statement.

I was thinking that comment should go above the first if statement.

Updated

Updated

Define what 3 means (#define up top). If 3 means 3 x 50ms general task interval, define it as shown below: #define AIR_PUMP_STALL_PERSISTENCE ( 150 / TASK_GENERAL_INTERVAL ) ///< How long stall con...

Define what 3 means (#define up top). If 3 means 3 x 50ms general task interval, define it as shown below:
#define AIR_PUMP_STALL_PERSISTENCE ( 150 / TASK_GENERAL_INTERVAL ) ///< How long stall condition must persist before alarming.

OR use persistent alarm.

Added

Added

Add a comment explaining what we're looking for here (i.e. we are commanding air pump to run but zero measured pump speed indicates it is not running).

Add a comment explaining what we're looking for here (i.e. we are commanding air pump to run but zero measured pump speed indicates it is not running).

Added

Added

Should probably initialize your new stall counter variable.

Should probably initialize your new stall counter variable.

Sean Nash I need your help for writing this Alarm properties.

Sean Nash I need your help for writing this Alarm properties.

Wrong place.

Wrong place.

I'll drop by and we can set properties together.

I'll drop by and we can set properties together.

Added

Added

Updated

Updated

Sorry, Updated

Sorry, Updated

Updated, if this is wrong then I need your help

Updated, if this is wrong then I need your help

Match properties from Denali where you can. The priorities should both be HIGH. The rank for the warning should be a higher number. The alarm should be TRUE for no resume and no rinseback. So, I kn...

Match properties from Denali where you can. The priorities should both be HIGH. The rank for the warning should be a higher number. The alarm should be TRUE for no resume and no rinseback. So, I know these properties aren't correct.
One thing I don't think we should copy from Denali though - I think the warning should not be TRUE for the STOP property so that we stay in blood prime state.

Add a blank line after declaration.

Add a blank line after declaration.