td-firmware

Clone Tools

Stats

Commits this week: 18
Total Committers: 15
Last Commit: 28 Apr
Commits this week: 18

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Tuesday 28 Apr
9:13 pm

Vendor - TEL - Vijay Pamula

LDT-3970: remove extra whitespace and blank lines

Options
    • -6
    • +2
    /firmware/App/Modes/StateTxDialysis.c
    • -1
    • +0
    /firmware/App/Monitors/Pressures.h
8:33 pm

Vendor - TEL - Vijay Pamula

LDT-3970: Adressed code review comments

Options
    • -225
    • +0
    /firmware/App/Modes/ModeTreatment.c
    • -3
    • +0
    /firmware/App/Modes/ModeTreatment.h
    • -41
    • +41
    /firmware/App/Modes/StateTxDialysis.c
    • -169
    • +0
    /firmware/App/Monitors/Pressures.c
    • -1
    • +1
    /firmware/App/Monitors/Pressures.h
    • -0
    • +1
    /firmware/App/Services/Messaging.c
    • -65
    • +0
    /firmware/App/Services/Messaging.h
    • -0
    • +428
    /firmware/App/Services/TxParams.c
    • -0
    • +62
    /firmware/App/Services/TxParams.h
6:13 pm

Sean Nash and Vinayakam Mani

3:43 pm

Raghu Kallala

LDT-473 removed confirmation field from tx param list

Options
    • -1
    • +0
    /firmware/App/Services/TxParams.c
3:37 pm

Raghu Kallala

LDT-473 removed confirmation field from tx param list

Options
    • -7
    • +7
    /firmware/App/Services/TxParams.c
    • -1
    • +1
    /firmware/App/Services/TxParams.h
2:31 pm

Sean Nash

???

???

2:30 pm

Sean Nash

Do we need a parameter for confirmation?

Do we need a parameter for confirmation?

9:23 am

Vendor - TEL - Praneeth Bunne

LDT-1886: Addressed code review comments

Options
    • -8
    • +9
    /firmware/App/Modes/ModePostTreat.c
    • -9
    • +15
    /firmware/App/Modes/ModePreTreat.c
    • -0
    • +1
    /firmware/App/Services/AlarmMgmtSWFaults.h
Monday 27 Apr
8:08 am

Raghu Kallala

LDT-473 updated tx params payload. Added confirmation field

Options
    • -1
    • +9
    /firmware/App/Services/TxParams.c
    • -0
    • +1
    /firmware/App/Services/TxParams.h
Sunday 26 Apr
3:41 pm

Sean Nash

It looks like you deleted it instead of fixing it.

It looks like you deleted it instead of fixing it.

3:40 pm

Sean Nash

Need to request syringe pump to start a seek before we go to seek state. It's not implemented yet, so just put a TODO comment for now.

Need to request syringe pump to start a seek before we go to seek state. It's not implemented yet, so just put a TODO comment for now.

3:39 pm

Sean Nash

Need to check heparin bolus volume > 0 too.

Need to check heparin bolus volume > 0 too.

3:38 pm

Sean Nash

Don't we need to check this too still?

Don't we need to check this too still?

3:37 pm

Sean Nash

Do we need to reset authStartTime here before we go to next state?

Do we need to reset authStartTime here before we go to next state?

3:35 pm

Sean Nash

Put positive case first ( TRUE == ...), then alarm and reject cases.

Put positive case first ( TRUE == ...), then alarm and reject cases.

3:33 pm

Sean Nash

No occlusion sensor in Leahi. Delete variable and references to it.

No occlusion sensor in Leahi. Delete variable and references to it.

3:32 pm

Sean Nash

We should now send the scanned text to the UI s/w for authentication before we go to next state where we wait for UI response.

We should now send the scanned text to the UI s/w for authentication before we go to next state where we wait for UI response.

3:31 pm

Sean Nash

Remove extra l at end of flag name (mis-spelled). And why are we sending this flag with scan event? Seems like the Received flag is what you want here.

Remove extra l at end of flag name (mis-spelled). And why are we sending this flag with scan event? Seems like the Received flag is what you want here.

3:26 pm

Sean Nash

The barcode reader is under TD f/w control via the FPGA (not implemented yet). So asking UI s/w to do a scan doesn't make sense.

The barcode reader is under TD f/w control via the FPGA (not implemented yet). So asking UI s/w to do a scan doesn't make sense.

3:25 pm

Sean Nash

What is this flag for? And why is it only set here and not above where test passed. Also, we are going to the loaded check state, but we are not requesting a scan first.

What is this flag for? And why is it only set here and not above where test passed.
Also, we are going to the loaded check state, but we are not requesting a scan first.

3:21 pm

Sean Nash

Local declarations should come first - move up above reset function above.

Local declarations should come first - move up above reset function above.

3:16 pm

Sean Nash

Leahi doesn't have occlusion sensor, so don't need this if statement. Not sure we need this start state. Maybe we can start in the wait for door close state.

Leahi doesn't have occlusion sensor, so don't need this if statement. Not sure we need this start state. Maybe we can start in the wait for door close state.

3:07 pm

Sean Nash

start state function has same description as wait for door close state function. We shouldn't need 2 states to ensure door is closed.

start state function has same description as wait for door close state function. We shouldn't need 2 states to ensure door is closed.

3:03 pm

Sean Nash

I meant that you should move this function up, not init function down.

I meant that you should move this function up, not init function down.

3:02 pm

Sean Nash

Change to initDrySelfTests() and move to top (should be first function).

Change to initDrySelfTests() and move to top (should be first function).

3:00 pm

Sean Nash

prime state not yet implemented. comment this out w/ TODO comment and add an assignemtn to Rx state here for now.

prime state not yet implemented. comment this out w/ TODO comment and add an assignemtn to Rx state here for now.

2:57 pm

Sean Nash

Why is this commented out?

Why is this commented out?

2:48 pm

Sean Nash

Is this permanent? If so, just delete commented code. If not, add a TODO comment to remind us to come back to this later.

Is this permanent? If so, just delete commented code. If not, add a TODO comment to remind us to come back to this later.

1:32 pm

Sean Nash

Remove blank line.

Remove blank line.

1:31 pm

Sean Nash

Move this transition function call to the transitionToPostTreatmentMode function below.

Move this transition function call to the transitionToPostTreatmentMode function below.