td-firmware

Clone Tools
  • last updated a few seconds ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
LDT-3959: Removed dead test code.

    • -216
    • +0
    /firmware/App/Tasks/TaskGeneral.c
LDT-3952: Fixed bug where moving average overflows its buffer when target flow is zero.

    • -22
    • +11
    /firmware/App/Controllers/BloodFlow.c
LDT-3970: Addressed Code review comments

    • -45
    • +45
    /firmware/App/Modes/StateTxDialysis.c
    • -10
    • +10
    /firmware/App/Services/Messaging.h
    • -216
    • +216
    /firmware/App/Services/TxParams.c
LDT-3505: Aligned syringe pump function definitions with declarations

    • -494
    • +505
    /firmware/App/Controllers/SyringePump.c
    • -1
    • +2
    /firmware/App/Controllers/SyringePump.h
LDT-3505: Merged latest staging into LDT-3505

    • -7
    • +7
    /firmware/App/Controllers/SyringePump.c
    • -10
    • +45
    /firmware/App/Modes/ModeTreatment.c
LDT-3505: Added syringe Pump exec in priority task

    • -2
    • +3
    /firmware/App/Controllers/SyringePump.c
Bamboo Commit: Updated TDCommon.h with build versions from Bamboo.

LDT-4188 resolved merge conflicts on develop

LDT-4188 updated tx param response as we are not storing confirmation into stagedparams

    • -11
    • +11
    /firmware/App/Services/TxParams.c
LDT-1886: Refactored install and eject into tubesetinstall and tubeseteject services

    • -242
    • +14
    /firmware/App/Modes/ModePostTreat.c
    • -142
    • +20
    /firmware/App/Modes/ModePreTreat.c
    • -0
    • +309
    /firmware/App/Services/StateServices/TubeSetAutoEject.c
    • -0
    • +58
    /firmware/App/Services/StateServices/TubeSetAutoEject.h
    • -0
    • +269
    /firmware/App/Services/StateServices/TubeSetInstall.c
    • -0
    • +56
    /firmware/App/Services/StateServices/TubeSetInstall.h
Updated to ml/min, except for broadcast in treatment mode

Updated to ml/min, except for broadcast in treatment mode

LDT-4188 converted UF rate to ml per min in all TD modules which interacts with DD. Broadcast is still in L per hr

    • -12
    • +12
    /firmware/App/Modes/StateTxDialysis.c
I don't think you want stored (old) value here. You want value from first message before confirmation.

I don't think you want stored (old) value here. You want value from first message before confirmation.

LDT-2240-disposable-tube-set-self-test

    • -1
    • +1
    /firmware/App/Services/TxDrySelfTests.c
    • -1
    • +1
    /firmware/App/Services/TxDrySelfTests.h
LDT-2240-disposable-tube-set-self-test

    • -2
    • +2
    /firmware/App/Services/TxDrySelfTests.c
    • -3
    • +3
    /firmware/App/Services/TxDrySelfTests.h
What TD does with UF rate is mostly to tell DD what rate we want. DD wants mL/min. TD can keep L/hr and convert to mL/min every time it needs to send DD a message or it can keep mL/min and convert ...

What TD does with UF rate is mostly to tell DD what rate we want. DD wants mL/min. TD can keep L/hr and convert to mL/min every time it needs to send DD a message or it can keep mL/min and convert to L/hr every time it needs to send UI a message. Either way works for me.

LDT-2240-disposable-tube-set-self-test

    • -0
    • +1222
    /firmware/App/Services/TxDrySelfTests.c
    • -0
    • +55
    /firmware/App/Services/TxDrySelfTests.h
    • -1527
    • +0
    /firmware/App/Modes/StatePreTxDrySelfTests.c
    • -55
    • +0
    /firmware/App/Modes/StatePreTxDrySelfTests.h
Changed to U32

Changed to U32

we are sending a message ack as response in the handler of this message request

we are sending a message ack as response in the handler of this message request

LDT-4188 removed type conversion for sub mode

LDT-4188 addressed review comments

Other existing set functions in TD is using UF in liter and rate in L/hr Shall I change all of them? Which might impact how systems is sending this info(L/hr or ml/min) in their scripts

Other existing set functions in TD is using UF in liter and rate in L/hr

Shall I change all of them? Which might impact how systems is sending this info(L/hr or ml/min) in their scripts

I think DD (and TD) want mL/min and UI wants L/hr. TxParams should have already calculated this rate (in mL/min) and should probably have a get function you can call from here to access it. When se...

I think DD (and TD) want mL/min and UI wants L/hr. TxParams should have already calculated this rate (in mL/min) and should probably have a get function you can call from here to access it. When sending UF rate to UI, we would convert back to L/hr first, but everywhere else we would work with mL/min.

Remove extra blank line.

Remove extra blank line.

Remove extra space before function name.

Remove extra space before function name.

This is not a Dialin message, so move up above all of these "test" functions.

This is not a Dialin message, so move up above all of these "test" functions.

Why is this in TDCommon? It should probably be in MessagePayloads.h or DDDefs.h so both DD and TD f/w can share this payload structure. And the common definitions should be added to appropriate dox...

Why is this in TDCommon? It should probably be in MessagePayloads.h or DDDefs.h so both DD and TD f/w can share this payload structure. And the common definitions should be added to appropriate doxygen group.

LDT-4188 rearranged variable declarations