· /firmware/App/Modes/ModePreTreat.c	(-13, +195)	| History	| Source	| Diff
· /firmware/App/Modes/ModePreTreat.h	(-3, +3)	| History	| Source	| Diff
· /firmware/App/Services/AlarmMgmtSWFaults.h	(-3, +12)	| History	| Source	| Diff
· /firmware/App/Services/FpgaTD.c	(-14, +253)	| History	| Source	| Diff
· /firmware/App/Services/Messaging.c	(-2, +20)	| History	| Source	| Diff
· /firmware/App/Services/StateServices/DrySelfTests.c	(-0, +1156)	| History	| Source
· /firmware/App/Services/StateServices/DrySelfTests.h	(-0, +55)	| History	| Source
· /firmware/App/Services/DrySelfTests.c	(-1156, +0)	| History	| Source	| Diff
· /firmware/App/Services/DrySelfTests.h	(-55, +0)	| History	| Source	| Diff

]]> Tue, 26 May 2026 10:01:34 -0700 Zoltan Miskolci https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-2240-1/#c29328 https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-2240-1/#c29328 Zoltan Miskolci commented on LEAHI-TD-FIRMWARE-LDT-2240-1

Shouldn't this file contain the incoming request and associate it to the corresponding function?
And that function will trigger the response sending part.

Declaring the response here instead seems out of regular design scheme.

These alarms are in the wrong place. Their enums are 187..199. So they should be at the very end of this table, not here near the beginning.

Remove this blank line.

I missed updating this earlier, I’ll push the updated code.

Can't have 3 values. Maximum 2 values allowed.

Removedd

added

Updated

Remove start state.

Updated

updated

Yes, removed

Removed

yes, removed

Changed

Removed

Removed

Removed

Added

Added

Updated

Updated

Added

Updated

Updated

no need to respond.

don't need response to a response.

don't need this if statement either and don't need what's inside the if.

Don't need this if statement or flag.