this function should not return anything.

Please rename all the sPump registers as h10 for consistency.

Add bpMeasurementReady, bpDriverError and pendingBPCommand to outputs.

Where is testBatteryI2cStatusOverride (from BatteryDriver)?

Add blank line before return statement.

Fixed

Added

Fixed

Fixed

Fixed

Not required here since we are initializing in the main

Yes removed

Fixed

Fixed

· /firmware/App/Controllers/BPModule.c	(-2, +2)	| History	| Source	| Diff
· /firmware/App/Drivers/BPDriver.c	(-2, +2)	| History	| Source	| Diff
· /firmware/App/Modes/ModePreTreat.c	(-2, +0)	| History	| Source	| Diff
· /firmware/App/Modes/ModeTreatment.c	(-1, +0)	| History	| Source	| Diff
· /firmware/App/Services/AlarmMgmtSWFaults.h	(-1, +1)	| History	| Source	| Diff
· /firmware/App/Services/AlarmMgmtTD.c	(-1, +1)	| History	| Source	| Diff
· /firmware/App/Services/FpgaTD.c	(-12, +12)	| History	| Source	| Diff
· /firmware/App/Tasks/TaskGeneral.c	(-2, +4)	| History	| Source	| Diff
· /firmware/source/sys_main.c	(-2, +2)	| History	| Source	| Diff

]]> Wed, 24 Jun 2026 14:34:26 -0700 Vendor - TEL - Arpita Srivastava https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-4033-1/#c30127 https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-4033-1/#c30127 Vendor - TEL - Arpita Srivastava commented on LEAHI-TD-FIRMWARE-LDT-4033-1

fpgaActuatorSetPoints is an output.
Input is none.

Include "BPModule.h".

BPModule is just one of the controllers - move this up into the controllers section.

We should not comment this out.

It's still here. Do we need to initialize it here too or is it sufficient to initialize once from main at startup?

We are already executing this from TaskGeneral.c. Remove from here.

Monitor is mis-spelled. Should be Control anyway. Move prior to execAlarmMgmt() above.

I think all flags are outputs (not just adult).

These look like outputs to me (not inputs).

Merge these 3 override functions (and message IDs) into one "array style" override function.

( void )

Change 0xFFFFFFFF to HEX_32_BIT_FULL_SCALE

Swap the order of these two.

· /firmware/App/Controllers/HemoDiaFiltration.c	(-48, +94)	| History	| Source	| Diff
· /firmware/App/Controllers/HemoDiaFiltration.h	(-14, +36)	| History	| Source	| Diff
· /firmware/App/Modes/ModePreTreat.c	(-1, +2)	| History	| Source	| Diff
· /firmware/App/Modes/ModeTreatment.c	(-1, +2)	| History	| Source	| Diff
· /firmware/App/Modes/StateTxDialysis.c	(-2, +9)	| History	| Source	| Diff
· /firmware/App/Modes/StateTxPaused.c	(-1, +2)	| History	| Source	| Diff
· /firmware/App/Services/AlarmMgmtSWFaults.h	(-0, +1)	| History	| Source	| Diff
· /firmware/App/Services/DDInterface.c	(-6, +16)	| History	| Source	| Diff
· /firmware/App/Services/DDInterface.h	(-2, +3)	| History	| Source	| Diff
· /firmware/App/Tasks/TaskGeneral.c	(-0, +4)	| History	| Source	| Diff

]]> Thu, 18 Jun 2026 09:02:33 -0700 Dara Navaei https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-4003-1 https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-4003-1 Dara Navaei started review LEAHI-TD-FIRMWARE-LDT-4003-1 ]]>