td-firmware / firmware

App

Clone Tools

Stats

Commits this week: 31
Total Committers: 15
Last Commit: 08 May
Commits this week: 31

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few minutes ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Thursday 07 May
3:20 pm

Michael Garthwaite

11:12 am

Sean Nash

Remove start state.

Remove start state.

10:30 am

Vendor - TEL - Varshini Nagabooshanam

Updated

Updated

10:29 am

Vendor - TEL - Varshini Nagabooshanam

updated

updated

10:29 am

Vendor - TEL - Varshini Nagabooshanam

Yes, removed

Yes, removed

10:29 am

Vendor - TEL - Varshini Nagabooshanam

Removed

Removed

10:28 am

Vendor - TEL - Varshini Nagabooshanam

yes, removed

yes, removed

10:28 am

Vendor - TEL - Varshini Nagabooshanam

Changed

Changed

10:28 am

Vendor - TEL - Varshini Nagabooshanam

Removed

Removed

10:28 am

Vendor - TEL - Varshini Nagabooshanam

Removed

Removed

10:27 am

Vendor - TEL - Varshini Nagabooshanam

Removed

Removed

10:27 am

Vendor - TEL - Varshini Nagabooshanam

Added

Added

10:27 am

Vendor - TEL - Varshini Nagabooshanam

Added

Added

10:27 am

Vendor - TEL - Varshini Nagabooshanam

Updated

Updated

10:27 am

Vendor - TEL - Varshini Nagabooshanam

Updated

Updated

10:27 am

Vendor - TEL - Varshini Nagabooshanam

Added

Added

10:26 am

Vendor - TEL - Varshini Nagabooshanam

Updated

Updated

10:25 am

Vendor - TEL - Varshini Nagabooshanam

Updated

Updated

Wednesday 06 May
5:55 pm

Sean Nash

Same comment as duration confirmation. compare uf rate too.

Same comment as duration confirmation. compare uf rate too.

5:44 pm

Sean Nash

Also check uf rate from confirmation message (request) is still the same as validated uf rate. WARNING - uf rate will be a float and we shouldn't use == operator on floats.

Also check uf rate from confirmation message (request) is still the same as validated uf rate.
WARNING - uf rate will be a float and we shouldn't use == operator on floats.

5:38 pm

Sean Nash

I think validated variable here should be L/Hr and assigned to response.ufRate so that when we get confirmation, we can compare rates with same units.

I think validated variable here should be L/Hr and assigned to response.ufRate so that when we get confirmation, we can compare rates with same units.

5:38 pm

Sean Nash

I think validated variable here should be L/Hr and assigned to response.ufRate so that when we get confirmation, we can compare rates with same units.

I think validated variable here should be L/Hr and assigned to response.ufRate so that when we get confirmation, we can compare rates with same units.

11:43 am

Sean Nash

Treatment mode will also need one of these (later). Should we add PreTx to the function name to differentiate?

Treatment mode will also need one of these (later). Should we add PreTx to the function name to differentiate?

Tuesday 05 May
6:54 pm

Sean Nash

I don't see you changing the GoalL. Recommend you use local presUFVolumeMl instead.

I don't see you changing the GoalL. Recommend you use local presUFVolumeMl instead.

6:52 pm

Sean Nash

2 lines above/below banner

2 lines above/below banner

6:48 pm

Sean Nash

remove blank line.

remove blank line.

6:25 pm

Sean Nash

use response.x for these.

use response.x for these.

6:25 pm

Sean Nash

use response.duration.

use response.duration.

6:24 pm

Sean Nash

Already set this above.

Already set this above.

3:58 pm

Sean Nash

no need to respond.

no need to respond.