Activity td-firmware/firmware/App

Can we please break this line as to match our standard of 100 columns? SET_ALARM_WITH_2_U32_DATA( ALARM_ID_TD_AIR_PUMP_STALL, currentAirPumpPowerLevel, getU32OverrideValue( &currentAirPumpRPM ) );

Can we please break this line as to match our standard of 100 columns?

SET_ALARM_WITH_2_U32_DATA( ALARM_ID_TD_AIR_PUMP_STALL,
currentAirPumpPowerLevel,
getU32OverrideValue( &currentAirPumpRPM ) );

11:02 am

Vendor - TEL - Varshini Nagabooshanam

More
d94c532
changed 4 files
LDT-4033-patient-vitals-fw-implementation LEAHI-TD-FIRMWARE-LDT-4033-1

Merge conflicts

- -4
- +4
./Modes/ModeTreatment.c
- History
- Source
- Diff
./Modes/ModeTreatment.c
- -5
- +7
./Services/AlarmMgmtSWFaults.h
- History
- Source
- Diff
./Services/AlarmMgmtSWFaults.h
- -11
- +22
./Services/FpgaTD.c
- History
- Source
- Diff
./Services/FpgaTD.c
- -1
- +3
./Services/Messaging.c
- History
- Source
- Diff
./Services/Messaging.c

10:52 am

Vendor - TEL - Arpita Srivastava

More
Re: LEAHI-TD-FIRMWARE-LDT-4072-2
commented on review

use FALSE

10:52 am

Vendor - TEL - Arpita Srivastava

More
Re: LEAHI-TD-FIRMWARE-LDT-4072-2
commented on review

use FALSE

10:39 am

Vendor - TEL - Arpita Srivastava

More
Re: LEAHI-TD-FIRMWARE-LDT-4072-2
commented on review

It looks like the rows may be misaligned with the alarm ID declarations. For example, ALARM_ID_TD_BATTERY_CHARGER_ERROR_DETECTED is declared as 204.

It looks like the rows may be misaligned with the alarm ID declarations.
For example, ALARM_ID_TD_BATTERY_CHARGER_ERROR_DETECTED is declared as 204.

10:22 am

Vendor - TEL - Varshini Nagabooshanam

More
7bb4651
changed 4 files
LDT-4149-pinch-valves-fw-implementation LEAHI-TD-FIRMWARE-LDT-4149-1

Changes

- -9
- +6
./Controllers/Valves.c
- History
- Source
- Diff
./Controllers/Valves.c
- -48
- +42
./Drivers/PinchValve.c
- History
- Source
- Diff
./Drivers/PinchValve.c
- -1
- +1
./Drivers/PinchValve.h
- History
- Source
- Diff
./Drivers/PinchValve.h
- -1
- +0
./Modes/ModeStandby.c
- History
- Source
- Diff
./Modes/ModeStandby.c

10:13 am

Vendor - TEL - Arpita Srivastava

More
Re: LEAHI-TD-FIRMWARE-LDT-4063-1
commented on review

When we send any message to UI, usually add the message id in the doxygen header like this. @details \b Message \b Sent: MSG_ID_TD_RESP_TREATMENT_PARAMS_TO_VALIDATE Please refer to the function s...

When we send any message to UI, usually add the message id in the doxygen header like this.

@details \b Message \b Sent: MSG_ID_TD_RESP_TREATMENT_PARAMS_TO_VALIDATE

Please refer to the function sendTreatmentParamsResponse()

10:05 am

Vendor - TEL - Arpita Srivastava

More
Re: LEAHI-TD-FIRMWARE-LDT-4063-1
commented on review

When we send any message to UI, usually add the message id in the doxygen header like this. *@details \b Message \b Sent: MSG_ID_TD_RESP_TREATMENT_PARAMS_TO_VALIDATE Please refer to the functi...

When we send any message to UI, usually add the message id in the doxygen header like this.

@details \b Message \b Sent: MSG_ID_TD_RESP_TREATMENT_PARAMS_TO_VALIDATE

Please refer to the function sendTreatmentParamsResponse()

10:05 am

Vendor - TEL - Arpita Srivastava

More
Re: LEAHI-TD-FIRMWARE-LDT-4063-1
commented on review

When we send any message to UI, usually add the message id in the doxygen header like this. *@details \b Message \b Sent: MSG_ID_TD_RESP_TREATMENT_PARAMS_TO_VALIDATE Please refer to the functi...

When we send any message to UI, usually add the message id in the doxygen header like this.

@details \b Message \b Sent: MSG_ID_TD_RESP_TREATMENT_PARAMS_TO_VALIDATE

Please refer to the function sendTreatmentParamsResponse()

9:55 am

Vendor - TEL - Arpita Srivastava

More
Re: LEAHI-TD-FIRMWARE-LDT-4063-1
commented on review

It looks like the rows may be misaligned with the alarm ID declarations. For example, ALARM_ID_TD_SAFETY_SHUTDOWN_POST_TEST_FAILED is declared as 207.

It looks like the rows may be misaligned with the alarm ID declarations.
For example, ALARM_ID_TD_SAFETY_SHUTDOWN_POST_TEST_FAILED is declared as 207.

9:53 am