td-firmware

firmware

Clone Tools

Stats

Commits this week: 41
Total Committers: 13
Last Commit: 05 Mar
Commits this week: 41

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few minutes ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Thursday 05 Mar
4:27 pm

Vendor - TEL - Varshini Nagabooshanam

LDT-1415-pressures-monitoring-td-updates

Options
    • -0
    • +37
    ./App/Monitors/Pressures.c
    • -0
    • +2
    ./App/Monitors/Pressures.h
    • -0
    • +1
    ./App/Services/Messaging.c
3:47 pm

Dara Navaei

LEAHI-TD-FIRMWARE-LDT-1415_Pressures Monitoring - TD
LEAHI-TD-FIRMWARE-LDT-1415_Pressures Monitoring - TD
3:10 pm

Vendor - TEL - Varshini Nagabooshanam

LDT-1415-pressures-monitoring-td-2

Options
    • -9
    • +20
    ./App/Drivers/PressureSensor.c
    • -5
    • +37
    ./App/Monitors/Pressures.c
    • -2
    • +4
    ./App/Monitors/Pressures.h
    • -2
    • +4
    ./App/Services/Messaging.c
    • -3
    • +3
    ./App/TDCommon.h
1:49 pm

Sean Nash

blank line before return.

blank line before return.

1:49 pm

Sean Nash

Blank line after declarations.

Blank line after declarations.

1:16 pm

Sean Nash

9:23 am

Dara Navaei

Bamboo Commit: Updated TDCommon.h with build versions from Bamboo.

Options
    • -1
    • +1
    ./App/TDCommon.h
9:19 am

Sean Nash

Merge branch 'LDT-3126-blood-prime-td' into develop

Options
    • -15
    • +231
    ./App/Modes/StateTxBloodPrime.c
    • -1
    • +2
    ./App/Services/Messaging.c
Wednesday 04 Mar
8:22 pm

Vendor - TEL - Sameer Poyil

9:40 am

Vendor - TEL - Varshini Nagabooshanam

Updated

Updated

9:40 am

Vendor - TEL - Varshini Nagabooshanam

LDT-2932-dd-td-TMP-reported-by-Dialin-FW-is-incorrect

Options
    • -1
    • +1
    ./App/Monitors/Pressures.c
5:47 am

Dara Navaei

Bamboo Commit: Updated TDCommon.h with build versions from Bamboo.

Options
    • -1
    • +1
    ./App/TDCommon.h
4:01 am

Dara Navaei

LEAHI-TD-FIRMWARE-LDT-1903_Air Trap Level Control - TD - 04: DEV - Feature Implementation
LEAHI-TD-FIRMWARE-LDT-1903_Air Trap Level Control - TD - 04: DEV - Feature Implementation
Tuesday 03 Mar
9:42 pm

Vendor - TEL - Sameer Poyil

Merge branch LDT-1903-air-trap-level-control-delay-adjust-after-fill-fix---td---0 into branch develop

Options
    • -2
    • +2
    ./App/Controllers/AirPump.c
    • -2
    • +2
    ./App/Drivers/GLXferPump.h
    • -2
    • +2
    ./App/Services/FpgaTD.c
    • -2
    • +2
    ./App/Services/FpgaTD.h
9:21 pm

Vendor - TEL - Sameer Poyil

LDT-1903 Air Trap adjust the air trap lower delay start time after fill complete

Options
    • -3
    • +4
    ./App/Controllers/AirTrap.c
4:44 pm

Sean Nash

4:42 pm

Vendor - TEL - Varshini Nagabooshanam

Added

Added

4:42 pm

Vendor - TEL - Varshini Nagabooshanam

Updated

Updated

4:41 pm

Vendor - TEL - Varshini Nagabooshanam

LDT-3126-blood-prime-td

Options
    • -1
    • +2
    ./App/Modes/StateTxBloodPrime.c
4:35 pm

Sean Nash

Add a blank line after declarations.

Add a blank line after declarations.

4:35 pm

Sean Nash

What I meant was that we don't care which blood prime state we're in - what we care about is that we are in treatment mode and priming blood - otherwise this message doesn't make sense and we shoul...

What I meant was that we don't care which blood prime state we're in - what we care about is that we are in treatment mode and priming blood - otherwise this message doesn't make sense and we should reject it because we're not in the right state.
if ( ( MODE_TREA == getCurrentOperationMode() ) && ( TREATMENT_BLOOD_PRIME_STATE == getTreatmentState() ) )

4:21 pm

Vendor - TEL - Varshini Nagabooshanam

LDT-3126-blood-prime-td

Options
    • -2
    • +2
    ./App/Services/Messaging.c
2:55 pm

Vendor - TEL - Varshini Nagabooshanam

Removed

Removed

2:55 pm

Vendor - TEL - Varshini Nagabooshanam

Added

Added

2:55 pm

Vendor - TEL - Varshini Nagabooshanam

Yes, Updated

Yes, Updated

2:55 pm

Vendor - TEL - Varshini Nagabooshanam

Replaced

Replaced

2:54 pm

Vendor - TEL - Varshini Nagabooshanam

LDT-3126-blood-prime-td

Options
    • -16
    • +16
    ./App/Modes/StateTxBloodPrime.c
2:11 pm

Sean Nash

This should be invalid state (or something like that).

This should be invalid state (or something like that).

2:11 pm

Sean Nash

These are the correct min/max values, but we can't use literals like this. Our coding standard calls these "magic numbers". What we want to do is call getU32TreatmentParamLowerRangeLimit() and getU...

These are the correct min/max values, but we can't use literals like this. Our coding standard calls these "magic numbers". What we want to do is call getU32TreatmentParamLowerRangeLimit() and getU32TreatmentParamUpperRangeLimit() functions from the TxParams service.

2:08 pm

Sean Nash

I think what matters is that we are in Treatment: Blood Prime state. I think any of the 3 blood prime states is ok for this message.

I think what matters is that we are in Treatment: Blood Prime state. I think any of the 3 blood prime states is ok for this message.